From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by sourceware.org (Postfix) with ESMTP id D5D13385F02A for ; Sat, 21 Mar 2020 01:41:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5D13385F02A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-209-CK9lb8FONNK_ne2j1BmYpg-1; Fri, 20 Mar 2020 21:41:07 -0400 X-MC-Unique: CK9lb8FONNK_ne2j1BmYpg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95EA9100550E; Sat, 21 Mar 2020 01:41:06 +0000 (UTC) Received: from ovpn-113-200.phx2.redhat.com (ovpn-113-200.phx2.redhat.com [10.3.113.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDB415C3FD; Sat, 21 Mar 2020 01:41:05 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2][gcc] libgccjit: handle long literals in playback::context::new_string_literal From: David Malcolm To: Andrea Corallo Cc: "jit@gcc.gnu.org" , nd , "gcc-patches@gcc.gnu.org" Date: Fri, 20 Mar 2020 21:41:05 -0400 In-Reply-To: <87tv2x9nmi.fsf_-_@arm.com> References: <878skb263l.fsf@arm.com> <87tv2x9nmi.fsf_-_@arm.com> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-27.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2020 01:41:10 -0000 On Mon, 2020-03-09 at 22:20 +0000, Andrea Corallo wrote: > Hi all, > > second version of the patch for the 200 characters limit for literal > strings addressing comments. > > make check-jit is passing clean. > > Best Regards > Andrea > > gcc/jit/ChangeLog > 2020-??-?? Andrea Corallo > > * jit-playback.h > (gcc::jit::playback::context m_recording_ctxt): Remove > m_char_array_type_node field. > * jit-playback.c > (playback::context::context) Remove m_char_array_type_node from > member > initializer list. > (playback::context::new_string_literal) Fix logic to handle > string > length > 200. > > gcc/testsuite/ChangeLog > 2020-??-?? Andrea Corallo > > * jit.dg/all-non-failing-tests.h: Add test-long-string- > literal.c. > * jit.dg/test-long-string-literal.c: New testcase. > diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h b/gcc/testsuite/jit.dg/all-non-failing-tests.h index 0272e6f846f..1b3d5618779 100644 --- a/gcc/testsuite/jit.dg/all-non-failing-tests.h +++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h @@ -220,6 +220,13 @@ #undef create_code #undef verify_code +/* test-long-string-literal.c */ +#define create_code create_code_long_string_literal +#define verify_code verify_code_long_string_literal +#include "test-long-string-literal.c" +#undef create_code +#undef verify_code + Please adjust where you add this so that these things are in alphabetical order. An entry also needs to be added to the "testcases" array at the end of the header for this to do anything. OK with that change. David