From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 02F723861835 for ; Wed, 10 Jan 2024 23:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02F723861835 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02F723861835 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704929500; cv=none; b=oqUuOVGDCePw2L4alViw3HoLOiHKi8cW7/U37WUU7/qXrF0pWcoiwrHZAHy68sVAMGOPAqO9rG/32gsnm9Q6Qoz5G8e3KmrDKh5O0Iu6j6tV+bqbqrZLO5fMpJtygTT/K0bwyuW2GpJGGcFbTw5qX+A8DecS7+yuh/5UKvafZuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704929500; c=relaxed/simple; bh=fMUIGBI8fzf22jjCC9OIMzfUud1uRfDwxc6O/N2XNLQ=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=NCq/5OxTFqhjGuBNjjU5He1mZvd0T55TcQHMFIwEmlV+u4lXwbro1A7gkQ2aP8AW2U3I2/L8YlW9JIZ6i8PDge2k9oYdoP8CyIsVXVNJ+HO9JfnI9Hj7uaM5Cra6sPjrkYneL5l/NUMNQSFTu0oyw++YiiXEyrx07MWIU5nUmJ0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704929498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ohxr+KsttmkBg2mCvpl9PkFmyVLpdGFGnwE+7Wx4hf0=; b=QNk3eZL8gnRdJUeZJnrTRWlcdYgDEE18D3qsUu0Y6pcEOKUUD/AxVJsF6PoU+byZ8dHQRt g6A/697tgySUHtR10vVh2fSlp1xXCwdMb2IWVeQn4+9QLawiC+Or2DEwX6UMxHjVTChsmm 7GKOvSDi3NG2drCFHEugl4l7iTaVk5g= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-MiBdtBhhMJy--l4zOxQ1LA-1; Wed, 10 Jan 2024 18:31:36 -0500 X-MC-Unique: MiBdtBhhMJy--l4zOxQ1LA-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3bbaf0ee0d9so6300062b6e.1 for ; Wed, 10 Jan 2024 15:31:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704929496; x=1705534296; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ohxr+KsttmkBg2mCvpl9PkFmyVLpdGFGnwE+7Wx4hf0=; b=qc9YceAVH8i/G9F6ct3U/Kfv1dYpy7Oa/i6JEpUwd5fxoOHKi1wescPcjqYuJuimHn 5cDKLzYt0NSN3DGR/g4o1wkrGPgq4KpkDcY7qJKAxSZRbi4OplSa1BeGt6TolK7LWvAk rnxvgF+72K6r+M6zjvNoqtv7iUyxreVJUaJBZfx6K9sMgBYEVgAKDuHqj7zQs+oqqnOY Xl8oB98p7TGxbt1d08WN9YMTcu8ek6i+7aQCmBzMhZyUzVCafOCPSiTHuUwj3/CKaLob d0aoAknjr0A5UjBXnbkVYf+HSfmbFnCAXnWK65PtsYIVQqZs0YebVFEkNtWA+WqeV6qA llmQ== X-Gm-Message-State: AOJu0Yyu6AhlOLynvmGkbmWcsRy7X8tvgeKM1Ept9ZQx6Ev7tr0NKtS2 Yi+K8pfgTDipO4E65bCv6UetjbX6aZyfnmht56ciJjIH/vyO9V7Z9kVBRfvEMjoObK+sqFxtnMV IqhbII82LCHgjyA4= X-Received: by 2002:a05:6808:1185:b0:3bc:9f3:aef7 with SMTP id j5-20020a056808118500b003bc09f3aef7mr322305oil.105.1704929496260; Wed, 10 Jan 2024 15:31:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqnmlOheSxeFyLxBr8iyJa6Lmxcob3yWidZCC8L3NqGhYJbsATwPuAAq+vzC0uHHM4pF6qrg== X-Received: by 2002:a05:6808:1185:b0:3bc:9f3:aef7 with SMTP id j5-20020a056808118500b003bc09f3aef7mr322296oil.105.1704929496002; Wed, 10 Jan 2024 15:31:36 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id w11-20020a0cff0b000000b0067f626a5b2esm2068693qvt.74.2024.01.10.15.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 15:31:35 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add missing builtins needed by optimizations From: David Malcolm To: Antoni Boucher , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Wed, 10 Jan 2024 18:31:33 -0500 In-Reply-To: <73a2fc40fa7db02da413580f2c0a7fda23c6b817.camel@zoho.com> References: <785979e06c0e554b85720d4563c8246f1d30077f.camel@redhat.com> <73a2fc40fa7db02da413580f2c0a7fda23c6b817.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-01-10 at 17:02 -0500, Antoni Boucher wrote: > Just to make sure since we are in stage 4. Are we? I haven't seen an announcement, and it looked from https://gcc.gnu.org/pipermail/gcc/2024-January/243117.html that we might be pushing back the date for it. > Does that mean I can merge it? This one is very low risk, so please go ahead and merge it. >=20 > In general, how would I know if it's OK to merge? > If the patch is in the state Accepted on patchwork, does that mean > it's > always OK to merge no matter the stage we're in? AIUI, the status in patchwork is purely to help keep track of patch reviews; whether or not a patch is suitable to push at a given time is probably on a case-by-case basis (the key question being "how likely is merging the patch going to cause problems") Dave >=20 > On Tue, 2024-01-09 at 11:35 -0500, David Malcolm wrote: > > On Fri, 2023-12-22 at 09:39 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch adds missing builtins needed by optimizations. > > > Thanks for the review. > >=20 > > The patch looks good to me. > >=20 > > Thanks! > > Dave > >=20 >=20