From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 689EA385841C for ; Wed, 10 Jan 2024 23:44:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 689EA385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 689EA385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704930268; cv=none; b=DW6SnC264bi02XzmxIk9SxnGxJxT003VYWj6KZ0IkvkcVOWFg6Hla/pzx19LPW7B/RPK/PfZ6yCUuaAiqTuZTo1zVjHxeseAJV5wfk/0zvq63DiAhRQqX0TA/5fjotXuuWCzXIHm087TbStLIQyPniUvM98v43syR3QKpfJNDM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704930268; c=relaxed/simple; bh=4uAuL5LwW50fgX+j33d/kUTz2xmoaJTmf5Wid85UqKQ=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=XqqX/I5yQgsk5cXaHamC5MkuEVTo3bColC70K7mbUIzINAUBHLHlZQTKxa46f9PSANkNCX34GYESKmWxgbQSNSVPZXCAv85dbgZdJyX2K6qIjmyGfMw+1bINmIs51DVUJ8vbnfmBuZL4++AiidbaBZPFzX410WRmBP1JFe+Cfd8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704930266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bzeqCwqG0olXtaE5NjhXTvZVXZCeVMwB8a4eXOCgpWg=; b=jBUzngmBi/N5Fg0HPJhWCwkrshQkxaGeKdbnB+AQ/RXvnZqUpf7CPoWKetO7QGWc4dNwN8 spARvXamx8HjEdMK4vA52/FIsN1kjaYHXz7gMRTHpip3i/Qecpo6sVXw0hWUs7W9488o5W JAUuT9UYtTbinIhwLDzHwz7aaDyvhSw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-ulbAfv_kOjShJtgzTb9bJA-1; Wed, 10 Jan 2024 18:44:24 -0500 X-MC-Unique: ulbAfv_kOjShJtgzTb9bJA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-68107efdd1dso55082906d6.0 for ; Wed, 10 Jan 2024 15:44:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704930264; x=1705535064; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bzeqCwqG0olXtaE5NjhXTvZVXZCeVMwB8a4eXOCgpWg=; b=mzFTanVIkLjrrEpA3F8URnP0l+NQoGX/mJnJ5m9JULYZN54CURN/9jRYhaJcN2p+5c 7SZBTbB8lUFa6jk2Q+7w/tFQB3EDxXtiwpZj1Xq4EV5BaY9UbqJel8O+vQ0PkWpVPH2S GX7NrJV9OanEXD57nCeQiaVO10rydxKWRSZUm/ndmrkC8NiwEg6Bws4Qn8uK9vQiIVvn yBzh5fO9E4ccyyjHdLs1WyRq27ZSeD9kWPT4vmvHEJFYcjhpbqw3Or/GaGHPajOIrsAf gOxAq1hsqEIoLHifTGLkd1yFAZo3KC7SefkP3Nz0Yf0uDExtR7PkulZ8Qyb5SkqvulYT f6Fw== X-Gm-Message-State: AOJu0Yw1PaJNzShY1povtiuyZbEuB1gCkkFYqYzT+W8Gf9NAuA/9WqKu U5I1iz6M2vW25cVLg3GozHncrc2MKSoQI+tQVEJymX/b2zNKnlUSBFA+jJPZrrML37PC4LH7b6s SY0c7d6Cu2N+lvWM= X-Received: by 2002:a05:6214:ac6:b0:67f:8273:978c with SMTP id g6-20020a0562140ac600b0067f8273978cmr435245qvi.10.1704930264322; Wed, 10 Jan 2024 15:44:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEl+9Kickb6KFg0uVUIcWr1jVHeDBvlTUt/Z6UgSao2c33Em6paT0/dMPEdpkdHx1ocmk9zEg== X-Received: by 2002:a05:6214:ac6:b0:67f:8273:978c with SMTP id g6-20020a0562140ac600b0067f8273978cmr435241qvi.10.1704930264095; Wed, 10 Jan 2024 15:44:24 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id f4-20020a056214164400b00680b3818c53sm2040862qvw.141.2024.01.10.15.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 15:44:23 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: David Malcolm To: Antoni Boucher , Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 10 Jan 2024 18:44:22 -0500 In-Reply-To: <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote: > David: Ping in case you missed this patch. For some reason it's not showing up in patchwork (or, at least, I can't find it there). Do you have a URL for it there? Sorry about this Dave >=20 > On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: > > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches > > wrote: > > >=20 > > > Hi. > > > This patch adds support for machine-dependent builtins in > > > libgccjit > > > (bug 108762). > > >=20 > > > There are two things I don't like in this patch: > > >=20 > > > =C2=A01. There are a few functions copied from the C frontend > > > (common_mark_addressable_vec and a few others). > > >=20 > > > =C2=A02. Getting a target builtin only works from the second > > > compilation > > > since the type information is recorded at the first compilation. > > > I > > > couldn't find a way to get the builtin data without using the > > > langhook. > > > It is necessary to get the type information for type checking and > > > instrospection. > > >=20 > > > Any idea how to fix these issues? > >=20 > > Seems like you should do this patch in a few steps; that is split > > it > > up. > > Definitely split out GCC_JIT_TYPE_BFLOAT16 support. > > I also think the vector support should be in a different patch too. > >=20 > > Splitting out these parts would definitely make it easier for > > review > > and make incremental improvements. > >=20 > > Thanks, > > Andrew Pinski > >=20 > >=20 > >=20 > > >=20 > > > Thanks for the review. >=20