From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124392 invoked by alias); 4 Jul 2019 15:53:11 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 124328 invoked by uid 89); 4 Jul 2019 15:53:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Dave X-Spam-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00044.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 15:53:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cH+xHHLxCoFYoS4hW/Ef5geLYhpgGKavbdA9CDQEgA=; b=N+ji0Xyqwpj1YpGews7vbWxRvSaKFwX08jp6NCLumIsMjAbkAzWPxN+FQJJRhRTV4mja1IBMpfwcJ8O+TVGvkBIb2DFpMNwEWB3zoeiUEQhNgfy23wGEOWO/pHJoau5wu9A8JwgB+5X0Z5js+AKHXklRNa6j5aEciOc2yBtyudw= Received: from VI1PR0802CA0029.eurprd08.prod.outlook.com (2603:10a6:800:a9::15) by AM6PR08MB4898.eurprd08.prod.outlook.com (2603:10a6:20b:cd::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.17; Thu, 4 Jul 2019 15:53:04 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::203) by VI1PR0802CA0029.outlook.office365.com (2603:10a6:800:a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Thu, 4 Jul 2019 15:53:03 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Thu, 4 Jul 2019 15:53:02 +0000 Received: ("Tessian outbound a713653e08e1:v23"); Thu, 04 Jul 2019 15:53:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4362dbddc87bd7bd X-CR-MTA-TID: 64aa7808 Received: from 4270052acaa1.1 (cr-mta-lb-1.cr-mta-net [104.47.4.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C3A67DE-5BE1-4112-A6A7-9C8F1FF28D0A.1; Thu, 04 Jul 2019 15:52:55 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4270052acaa1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Thu, 04 Jul 2019 15:52:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cH+xHHLxCoFYoS4hW/Ef5geLYhpgGKavbdA9CDQEgA=; b=N+ji0Xyqwpj1YpGews7vbWxRvSaKFwX08jp6NCLumIsMjAbkAzWPxN+FQJJRhRTV4mja1IBMpfwcJ8O+TVGvkBIb2DFpMNwEWB3zoeiUEQhNgfy23wGEOWO/pHJoau5wu9A8JwgB+5X0Z5js+AKHXklRNa6j5aEciOc2yBtyudw= Received: from VE1PR08MB5070.eurprd08.prod.outlook.com (20.179.29.148) by VE1PR08MB4943.eurprd08.prod.outlook.com (10.255.158.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Thu, 4 Jul 2019 15:52:53 +0000 Received: from VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::34f5:a093:3356:52f5]) by VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::34f5:a093:3356:52f5%7]) with mapi id 15.20.2032.019; Thu, 4 Jul 2019 15:52:53 +0000 From: Andrea Corallo To: Andrea Corallo CC: David Malcolm , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd Subject: Re: [PATCH][gcc] libgccjit: add bitfield support Thread-Topic: [PATCH][gcc] libgccjit: add bitfield support Thread-Index: AQHVGfH2i3Pw/ZC3+E2HQL7V8/ROg6ahhbSAgAmIuICAAF7HAIACfYAAgAAkQoCAAZ56gIALH6aA Date: Tue, 01 Jan 2019 00:00:00 -0000 Message-ID: References: <1560865833.3885.8.camel@redhat.com> <1561410326.3885.34.camel@redhat.com> <1561555015.13494.10.camel@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0409.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::13) To VE1PR08MB5070.eurprd08.prod.outlook.com (2603:10a6:803:105::20) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.37] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: cb544f5a-a3a8-4d4b-d405-08d70097b266 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4943; X-MS-TrafficTypeDiagnostic: VE1PR08MB4943:|AM6PR08MB4898: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; x-forefront-prvs: 0088C92887 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(53754006)(189003)(199004)(99286004)(52116002)(486006)(5660300002)(8936002)(66066001)(6506007)(26005)(386003)(72206003)(86362001)(2906002)(186003)(68736007)(6862004)(14454004)(478600001)(6512007)(256004)(2616005)(53936002)(476003)(229853002)(14444005)(446003)(6200100001)(76176011)(44832011)(102836004)(11346002)(7736002)(305945005)(25786009)(3846002)(66946007)(4326008)(64756008)(66446008)(66556008)(66476007)(54906003)(6486002)(73956011)(6116002)(316002)(36756003)(6246003)(37006003)(8676002)(6436002)(81156014)(81166006)(71200400001)(71190400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4943;H:VE1PR08MB5070.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: jtKMmVFG+o52IZhphqzrWWpCLCknWXesIb4f/OngYzQPDcefLZDC+GCcOBBV+WtbhkdqeyvISUMjxKTOSkUUNKAaP9Q4o7q4hQgOOCdX6x/R+coHRbGMjUbvuDmEbMjebKJx5GdDljETh0ZxJ1CxD8zs+xbtgQGZRBN5hwssSaLPDUEONwhps/74CpVCvcujx18uaVbGACsHgQ0sNJzsAcEXMHMjy9aAM00hBzygrPHyG+8z4yGeezqom0okTQcpyLbJbgcD5PxFnrYFZbpZmcr1p5uBC3mgeJQ+Me/LZfUBeasJPrnvawFHMJykkiFJcUpNzpLIBNrWWhj0b9DbE8xm8T3eiksJ+Y3iP+cFdPEmxliF1jPGOX+xGRVgPgjcrmw5sVBAu7FJNjNNDY/QFQ9x0Pv/oKt7EF6QTJpS/W0= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4943 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(376002)(396003)(136003)(346002)(39860400002)(2980300002)(53754006)(189003)(199004)(2906002)(316002)(5660300002)(25786009)(305945005)(6486002)(7736002)(229853002)(70206006)(37006003)(8676002)(6116002)(3846002)(81166006)(6512007)(81156014)(54906003)(356004)(23756003)(76130400001)(8936002)(8746002)(36756003)(86362001)(36906005)(70586007)(6246003)(102836004)(4326008)(2616005)(63350400001)(486006)(72206003)(50466002)(336012)(26826003)(47776003)(14454004)(66066001)(14444005)(478600001)(6200100001)(186003)(76176011)(126002)(11346002)(476003)(446003)(6862004)(450100002)(63370400001)(386003)(22756006)(26005)(6506007)(99286004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB4898;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 26bea5c5-937c-402d-2878-08d70097ac38 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:AM6PR08MB4898; NoDisclaimer: True X-Forefront-PRVS: 0088C92887 X-Microsoft-Antispam-Message-Info: 8RsKeIfQ1Kw/smR7VAYkLQvSdZhhyyFdLpZHmUEXVOnfHDhjkFFs+1k4py0xjQHpe/ggjal1qG+wW33mN4+aEuz0y7pjRWr8gaodL++G9D1HGJT0YqyguG1VoP39gr0UrCYXi7TpVeKHv9cTprsdPZ0sSgJSvrfCzdYEzYMQva30wxiDPAnyHvmOhxrj1vjAPh97VrwtXuFfdDr3LUxeiMMAcsVy4tlQJAVGVsxv0idhG3u2+KyAGNW6S5t1rxIuK7jcMn1zU9rYaMPep/BZIWQZjtpV+gtPnDa6VeJoqPi7aUvOTVjEhmzns9YDAgOF+tATJBAJ1DHkTlXqEOBb5R4+0dAVoPalx+1RWU9rTMBIdl7DNN20BPSNcebBbFJVMijGf6okBr6l2FAfZILB18eIhkuseiHHrfiGzgUve/I= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2019 15:53:02.7778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb544f5a-a3a8-4d4b-d405-08d70097b266 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4898 X-SW-Source: 2019-q3/txt/msg00003.txt.bz2 Andrea Corallo writes: > Hi Dave, > last version for this patch addressing the suggestion about the > JIT_BIT_FIELD macros comment description. > > Thank you for all the suggestions. > > Regarding the write access please see my previous answer into the binary > op patch thread. > > Bests > Andrea > > > 2019-06-20 Andrea Corallo andrea.corallo@arm.com > > * docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag. > * docs/topics/types.rst: Add gcc_jit_context_new_bitfield. > * jit-common.h (namespace recording): Add class bitfield. > * jit-playback.c: > (DECL_JIT_BIT_FIELD, SET_DECL_JIT_BIT_FIELD): Add macros. > (playback::context::new_bitfield): New method. > (playback::compound_type::set_fields): Add bitfield support. > (playback::lvalue::mark_addressable): Was jit_mark_addressable make this > a method of lvalue plus return a bool to communicate success. > (playback::lvalue::get_address): Check for jit_mark_addressable return > value. > * jit-playback.h (new_bitfield): New method. > (class bitfield): New class. > (class lvalue): Add jit_mark_addressable method. > * jit-recording.c (recording::context::new_bitfield): New method. > (recording::bitfield::replay_into): New method. > (recording::bitfield::write_to_dump): Likewise. > (recording::bitfield::make_debug_string): Likewise. > (recording::bitfield::write_reproducer): Likewise. > * jit-recording.h (class context): Add new_bitfield method. > (class field): Make it derivable by class bitfield. > (class bitfield): Add new class. > * libgccjit++.h (class context): Add new_bitfield method. > * libgccjit.c (struct gcc_jit_bitfield): New structure. > (gcc_jit_context_new_bitfield): New function. > * libgccjit.h > (LIBGCCJIT_HAVE_gcc_jit_context_new_bitfield) New macro. > (gcc_jit_context_new_bitfield): New function. > * libgccjit.map (LIBGCCJIT_ABI_12) New ABI tag. > > > 2019-06-20 Andrea Corallo andrea.corallo@arm.com > > * jit.dg/all-non-failing-tests.h: Add test-accessing-bitfield.c. > * jit.dg/test-accessing-bitfield.c: New testcase. > * jit.dg/test-error-gcc_jit_context_new_bitfield-invalid-type.c: > Likewise. > * jit.dg/test-error-gcc_jit_context_new_bitfield-invalid-width.c: > Likewise. > * jit.dg/test-error-gcc_jit_lvalue_get_address-bitfield.c: > Likewise. Hi all, committed into trunk as r273086. Bests Andrea