From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64874 invoked by alias); 5 Feb 2019 21:40:55 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 64845 invoked by uid 89); 5 Feb 2019 21:40:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mid, paperwork, bumping X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80072.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Feb 2019 21:40:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MJQHDdETmJHp2rpg5Yiw9aOTwsjfW6Iu1nCBN8KsnEk=; b=r3nBjLQpyVUbCUWWwMOH16la5m4lEZ6GFPv9RZ16a0xbokoeQvEz2HungP9Z747wRH5axjQRGgArJGO94IKB6Y0wfUjN3CATW2KCYRM9UGmX4v71HrB51N8QgNsZcHraZMJnbCbrjbVi7ZTrIe5Lmochjh700cL4G9kl9unKeUg= Received: from AM5PR0801MB1986.eurprd08.prod.outlook.com (10.168.158.13) by AM5PR0801MB2001.eurprd08.prod.outlook.com (10.168.158.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.22; Tue, 5 Feb 2019 21:40:50 +0000 Received: from AM5PR0801MB1986.eurprd08.prod.outlook.com ([fe80::505f:eb69:8237:fc4]) by AM5PR0801MB1986.eurprd08.prod.outlook.com ([fe80::505f:eb69:8237:fc4%4]) with mapi id 15.20.1580.019; Tue, 5 Feb 2019 21:40:50 +0000 From: Andrea Corallo To: David Malcolm CC: Andrea Corallo , Jakub Jelinek , Richard Biener , nd , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Subject: Re: Late-breaking jit features (was Re: [PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option) Thread-Topic: Late-breaking jit features (was Re: [PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option) Thread-Index: AQHUunKsXQWocOcXuUK8AfmDr0bNBKXMHFMAgACD8oCAAARlgIAE6kUAgAAzEYA= Date: Tue, 01 Jan 2019 00:00:00 -0000 Message-ID: References: <1549055472.29992.9.camel@redhat.com> <1549120723.29992.14.camel@redhat.com> <20190202153427.GD2135@tucnak> <1549391878.29992.19.camel@redhat.com> In-Reply-To: <1549391878.29992.19.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0292.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::16) To AM5PR0801MB1986.eurprd08.prod.outlook.com (2603:10a6:203:4b::13) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM5PR0801MB2001;6:GD/j0/9jd1GSp0KDcJWvwiRWV1HJybTHCwE5D/iVeKDpm4fxUvIL3qKkURFQxTjbLnYnMGGf4KvsDtZFv9m6gnFDPcaNf1OQthtDWsULfYI/K1NU3kRLV72hphZieKrDpLtSXQDeEOGCfGuP9S6w8wUKR3uYY8mD0vSAMkybingMbqc1n7Ok8+V05dd3vhiTXcjlP0crN7PN5UoVK3Dq2Q3Kb61YGfnFMR83cK9WK9WTkZDwzfQvitwFY2Ml+vf+c5uRsEKciyEyxitfzYz47iOvxlkbgnc0Z+dHsKlz2umuhQAzM99FzVdXH6b92CeY7GsdT5OZL8Ckkk6kNb4/OQGOtwE4heBY2qHSF6XEdz9pkglFBMveWs8evw+SLpCXqWGoWt74PciScBspZaoXzfS4H0xbo2U6GIkB98QKgiVwrGJ/CztBNWp32QZ8inl2w0Km4CKb2L26b7vieNodew==;5:24uvY2YMyjpC1TD6sZWJSeG949J7uBfTHyIkpJLgq7zJ60+2soyol7SKQGTpiTd2RuHlJ6E9n+A89BOHtDGy5d+/pfeO+QMwhQJgoY19RkWEjGiuSMGVn332woLO+yMTx0zm5E3ibuZWSeNmrfNt6nzZFJfBSNY+bB9Ibq4R+QlGfV3SK0iLne0luNd3wjmuUhsgVM2rmXm1Ghv7D1YEjA==;7:vmjZYUxFrlKqfK5W8yINvhEFsj4qzcBY6VBptNyOgGAeV2zw6ojr8sU8belf7K2qhm9v4mDkQGtass6DsPTx/o7j2fGO/xBEz3BieIAHL7/exxKI/bSumZXm9EMgZ8wN65aVwrVCxtP2jZ3NmBmtVg== x-ms-office365-filtering-correlation-id: ae4d6021-7146-4447-4378-08d68bb29820 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM5PR0801MB2001; x-ms-traffictypediagnostic: AM5PR0801MB2001: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0939529DE2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(136003)(366004)(376002)(39860400002)(346002)(189003)(199004)(486006)(3846002)(4326008)(44832011)(316002)(54906003)(6116002)(105586002)(97736004)(305945005)(68736007)(66066001)(6512007)(11346002)(476003)(478600001)(2616005)(26005)(52116002)(446003)(229853002)(6306002)(76176011)(2906002)(36756003)(6916009)(99286004)(86362001)(102836004)(93886005)(6246003)(14454004)(53936002)(81166006)(6486002)(81156014)(8676002)(25786009)(256004)(71190400001)(386003)(71200400001)(72206003)(106356001)(6506007)(186003)(7736002)(14444005)(6436002)(966005)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB2001;H:AM5PR0801MB1986.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6JQYrzjZKr3kX+HgZ63CYoX612j8oKtJOMvcdiGaz6/xxFzKvV+W6Rw+0e87jFKv2o2i2WJMSZ8fwVFeYWPvnmdM4ve1ICS0Y3beIfx48AAXs3AR7uXvJRarjEX6d0MNU2wYMWhYFhrQwWk9n8feaRBU90ABhX2/+inTV3rDjo0/20PzakJf3BFpBUmic4FnN/oMx05CrjaJEtzf7VVnypKh3uWraDQYC7culMWi2eqGW/PpPABg2R47GvMJp9GGBtitt+zQ/cF5i3h67b2gFxsXlH+qLRkNx19Vp8IXYVaLH2ekgWNGI7ha6RfIFSfKy7Hfmg3+YBhJzb6PRb1nNq/wcAckS5nhwXXeDK/k8KKfHv3hXJNBYbU4L7KkMXc7o0IuKw4dS/jxzwPM4z/nvzvDW8h9kVH1wVGxOsLPn4A= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae4d6021-7146-4447-4378-08d68bb29820 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2019 21:40:47.5830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2001 X-SW-Source: 2019-q1/txt/msg00058.txt.bz2 David Malcolm writes: > On Sat, 2019-02-02 at 16:34 +0100, Jakub Jelinek wrote: >> On Sat, Feb 02, 2019 at 10:18:43AM -0500, David Malcolm wrote: >> > > > Alternatively, should these patches go into a branch of queued >> > > > jit >> > > > changes for gcc 10? >> > > >> > > Is there anything like an ABI involved? If so we should avoid >> > > breaking it all the time. Otherwise JIT is not release critical >> > > and >> > > thus if you break it in the wrong moment it's your own fault. >> > >> > The two patches each add a new API entrypoint, but libgccjit uses >> > symbol-versioning to extend the ABI, without bumping the SONAME: >> > https://gcc.gnu.org/onlinedocs/jit/topics/compatibility.html >> > So it's not an ABI break as such. >> >> I'd say it depends on how quickly the copyright paperwork can be >> done, the >> patch can't be added until that is resolved. While gccjit is not >> release >> critical, it would be nice not to break it late, so say if it can be >> committed by end of February/mid March, I guess it is fine, given the >> assumption we'd like to release mid April to end of April, if it >> can't be >> done by then, might be better to postpone to GCC 10. >> >> Jakub > > Jakub and Richard: thanks. > > I've double-checked the gcc_jit_context_add_driver_option patch and it > looks good (it's a different patch that we're waiting on paperwork > for). > > Andrea: are you able to commit this, or should I do this on your > behalf? > > Dave Hi David, I have no repo write access so if you could push it that would be great. Thanks a lot Andrea