From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62]) by sourceware.org (Postfix) with ESMTPS id 60387395A439; Wed, 18 Mar 2020 22:53:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60387395A439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaTGE7V46ebRhsKb8FYfEZR6miXyVspjsauv9tWGb4o=; b=OPJXMAH2smncLPmlldCrvVrb9rX71LaEZfmQ+KRj1ePkwhgqv/XSSMnFWEgKL71UGdW5B4ZhZ3cq6zlC6yCmm8GH2tTqT00NgEeQaG/d8atk+JVKRCGhG8t8PAc6l4DCLElcRfTGxH4sRMOmF2LpEAnedyUFsqOMNYlWD7QIgj4= Received: from AM3PR05CA0152.eurprd05.prod.outlook.com (2603:10a6:207:3::30) by DB7PR08MB3420.eurprd08.prod.outlook.com (2603:10a6:10:4a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.16; Wed, 18 Mar 2020 22:53:02 +0000 Received: from AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:207:3:cafe::20) by AM3PR05CA0152.outlook.office365.com (2603:10a6:207:3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.15 via Frontend Transport; Wed, 18 Mar 2020 22:53:02 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT006.mail.protection.outlook.com (10.152.16.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Wed, 18 Mar 2020 22:53:02 +0000 Received: ("Tessian outbound 370656d282d1:v48"); Wed, 18 Mar 2020 22:53:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 82f8bc6a3530deb5 X-CR-MTA-TID: 64aa7808 Received: from c47c5eec6504.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C7B4B9E7-E26D-4F1F-901D-429F6D873A8B.1; Wed, 18 Mar 2020 22:52:56 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c47c5eec6504.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 Mar 2020 22:52:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UX+yDMsle43QkyhzvFKjUlqOsDyu8IKDu3MC1d9uFou8GLS2OSjdhCMNXUCfIkRvfbxpoy+H+nSENM0K539IQsTgICnxDmSzQX5bmm/QeqH0VgvZiGxuQDVy/hdhj1Iw1gvXJ1Dl8n1xKr6TjHlmVoAgwEB3FN0YXQOygqMKWKpaYbTY5HnKYlilYolM+k45JsoamubWvDKkwG1okDCYYKlKGzadUYPKu+KdVxEQp56b1kU67xSfxYQWRgWxaufMT2ZrPXe9MwUEfEfkw30hdvGpamydqnqmG67FVmoQgfiwlr5Uz+C2oyRCowKaquEKpK5win5sVZinO+FN6jMayA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaTGE7V46ebRhsKb8FYfEZR6miXyVspjsauv9tWGb4o=; b=K0Ghc0dMVMpnBI0i55CdX53fCHn8gJ28UHpuWxYP+2c3ix4nb0GkjQijQ2Nl0duzmJ22CWIoL1TQ4uP+QxwLErdu+Wp4P/4d8NIFRZs/Gamg/H3v9PxpUqQspddmgmzP/2mbX6gF+YAcAHcw68H1Ljbzq0tWGXIaNmJUl9HX/mSvbs4oWamPqHmL0fiReUR8ywBUIzXUvUeGfq2eO3YJVAkq1obkhpdRAMyaMKF4QQQQ7eiXOncCEkMMeTp50rsAeILnxcCEc2pJW2j/SSLwq94Soxi49i/8fGoA1zWUi/wDGd0VfIuRnSSPNQ65PkGOSOId4RQ/VuDPQ9mNkJtm0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaTGE7V46ebRhsKb8FYfEZR6miXyVspjsauv9tWGb4o=; b=OPJXMAH2smncLPmlldCrvVrb9rX71LaEZfmQ+KRj1ePkwhgqv/XSSMnFWEgKL71UGdW5B4ZhZ3cq6zlC6yCmm8GH2tTqT00NgEeQaG/d8atk+JVKRCGhG8t8PAc6l4DCLElcRfTGxH4sRMOmF2LpEAnedyUFsqOMNYlWD7QIgj4= Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; Received: from VI1PR08MB2765.eurprd08.prod.outlook.com (10.170.236.32) by VI1PR08MB3136.eurprd08.prod.outlook.com (52.133.14.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.22; Wed, 18 Mar 2020 22:52:54 +0000 Received: from VI1PR08MB2765.eurprd08.prod.outlook.com ([fe80::8413:fc03:8c5a:5ed6]) by VI1PR08MB2765.eurprd08.prod.outlook.com ([fe80::8413:fc03:8c5a:5ed6%3]) with mapi id 15.20.2814.021; Wed, 18 Mar 2020 22:52:54 +0000 From: Andrea Corallo To: David Malcolm Cc: "jit@gcc.gnu.org" , nd , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v2][gcc] libgccjit: handle long literals in playback::context::new_string_literal References: <878skb263l.fsf@arm.com> <87tv2x9nmi.fsf_-_@arm.com> Date: Wed, 18 Mar 2020 23:52:52 +0100 In-Reply-To: <87tv2x9nmi.fsf_-_@arm.com> (Andrea Corallo's message of "Mon, 09 Mar 2020 22:20:21 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0334.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::34) To VI1PR08MB2765.eurprd08.prod.outlook.com (2603:10a6:802:18::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e112547 (217.140.99.251) by LO2P265CA0334.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18 via Frontend Transport; Wed, 18 Mar 2020 22:52:53 +0000 X-Originating-IP: [217.140.99.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 36142bd3-49b4-4b4f-06f8-08d7cb8f1cf1 X-MS-TrafficTypeDiagnostic: VI1PR08MB3136:|DB7PR08MB3420: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-Forefront-PRVS: 03468CBA43 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(199004)(86362001)(4744005)(5660300002)(2906002)(66476007)(478600001)(16526019)(186003)(316002)(26005)(54906003)(81166006)(66556008)(8676002)(36756003)(52116002)(44832011)(956004)(6916009)(6496006)(81156014)(8936002)(6486002)(2616005)(4326008)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3136; H:VI1PR08MB2765.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D+VgGDqpaTLQaPU6XO+c6/dKwRQqJvGDmC/WXfLXEIegzVRKaSdmFds02mjGEhdedS/REVS2Uf9l6iIK7uC4jXt0Cbhhhl17Olm9Roa01CjfURGD81joVnW3UnNfDCCG0sD9d5Tn5FPnKqz0rPimFvoBO2MkJPqucR6Dxdf1YxMBt5/Q+tapXiwCLvnJalVfTR5jspLDrTGmbuiyVMR0qh3nhfO3lDPxmg6fa6MonTQU0LthgMDkBLEzpigwj2j7t3338RDbEa2vU31gEiIUiClB57HIibg9ZNtQVbAspKgaPmPNZrldNYceFMTBjuI+RxdPCqgPcmIku9rRAvmjXqhru3Rw5ViaYWy/SxAKJ0T0KyUZ5ZQVgpsFCXzaEzGYncifbIp9DRbtB+VLBvYVqjM+sjLgt+1q8qtaXqfWaEs0AUnJ8pjYdcqpKBDUuLa5 X-MS-Exchange-AntiSpam-MessageData: Mp6wK02cK0OEpvddBFTmuR7pKv+fYL9s3lZ/M8OBLYfhwva2FDQU0VR5zeZKdHYF2T9a1dBQ/FAGCoCsaZk29M5qn5UJUJ3WoWnCsJrPMl0I7BBgMW4yschYxPc/zGZgGmUfmH3aGTjrwMnsaolvFA== X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3136 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(396003)(376002)(136003)(199004)(46966005)(4744005)(956004)(36756003)(316002)(26826003)(2616005)(36906005)(26005)(16526019)(86362001)(44832011)(478600001)(336012)(186003)(47076004)(356004)(54906003)(6862004)(2906002)(6486002)(70206006)(4326008)(450100002)(5660300002)(70586007)(6496006)(81156014)(81166006)(8676002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3420; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Pass; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: a50d47be-3f39-46ea-f82f-08d7cb8f1814 X-Forefront-PRVS: 03468CBA43 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QeVqm0ZmrLVaA9kiEJTMh+cU/X3xRAxwD3KOeX9vxFei+kYUr6g07MJ2WfK/bvzuDRqM19r8D4mMRpHw7xqYlN6/xVXGtQeN6pQJA8z2g523h1BXSD0Dses8WUFN+frXI2ngSjPB/tOwBuX/M8vrWYEkSWVJb8HqL1YhSFzzsu5Vq9GUFaoP2ELh9IqZuysaHbnyOkAoTG8Lc4zZWTg7CygCb74yd1Rg9ErGKoGx2OTuUuQiyejFvmVqwRlzKjJjs1RK56V7+R0psgT6AgMCA0CzRBX85a9FOGVGHeijpDCM/acQquGMKPnu9FDH+rC1SXaRcItYkQX7w56kUo6uAOR/N23EIRcTnLdxi2qIKdOltmaWQL/IiwaNAFOaceTjW3QXmMo8MDSDHH853KuopP+d2pfI+jHZfq/NTdZTe1Q1LGexGaCMmhSSBEDUM4/qYQDrbdc221ZcDuxEAyRd75cv8NW0IswjEQX1TCRApZW2uyVGehrMTMTVadFChxZx/4rwP2CDdIuYs80VF8R0MQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2020 22:53:02.1773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36142bd3-49b4-4b4f-06f8-08d7cb8f1cf1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3420 X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 22:53:07 -0000 Andrea Corallo writes: > Hi all, > > second version of the patch for the 200 characters limit for literal > strings addressing comments. > > make check-jit is passing clean. > > Best Regards > Andrea > > gcc/jit/ChangeLog > 2020-??-?? Andrea Corallo > > * jit-playback.h > (gcc::jit::playback::context m_recording_ctxt): Remove > m_char_array_type_node field. > * jit-playback.c > (playback::context::context) Remove m_char_array_type_node from member > initializer list. > (playback::context::new_string_literal) Fix logic to handle string > length > 200. > > gcc/testsuite/ChangeLog > 2020-??-?? Andrea Corallo > > * jit.dg/all-non-failing-tests.h: Add test-long-string-literal.c. > * jit.dg/test-long-string-literal.c: New testcase. Kind ping, okay for trunk?