From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63]) by sourceware.org (Postfix) with ESMTPS id A05C5384A87E; Wed, 19 Aug 2020 07:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A05C5384A87E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKx8886Ryv9AWFs+y3jn5oXWe/ABsBN72MuR2iQebbo=; b=9CFI0Vt3kf8//cGV4WHnkD7qJSa7DXAYtswv+ijuKJWGz2d1Ewkb1tX4zjzrTNT4EGxpyl8Ciin/CQcUu7SQbVONVHjq1O3IuEwdIH5B+J6s8EJaoWiBUOFC1/WNSU7SkSEuv6DNWzJ0e0cr8FOft0pERJQQ2vUBtxd6PEuvq14= Received: from DB8PR06CA0053.eurprd06.prod.outlook.com (2603:10a6:10:120::27) by AM0PR08MB5345.eurprd08.prod.outlook.com (2603:10a6:208:18c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Wed, 19 Aug 2020 07:24:15 +0000 Received: from DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::fd) by DB8PR06CA0053.outlook.office365.com (2603:10a6:10:120::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 07:24:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT036.mail.protection.outlook.com (10.152.20.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 07:24:14 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Wed, 19 Aug 2020 07:24:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d9ed2e36fa12df88 X-CR-MTA-TID: 64aa7808 Received: from 70ceca749643.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EBFBB635-F1DC-44DB-A97F-1569F3B7F6D6.1; Wed, 19 Aug 2020 07:24:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70ceca749643.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Aug 2020 07:24:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuMnXSgNHSgAmodTjxMgF56pD7dAypCpo3Ql37OEJiXHJJsapsj9FGSYfO19vaR9Vw+/phaRiS1P2XxZQo5chcT/BAi5K9TYZM5nzznon3IwvlN7XpJHtI9TCpUrVt5G8Vc2fZUTivmDXLrA+NTf86Ogh0rD5iybn6EXLt7biKypBaxzejehoi1rfxMdjs1lwX0BUSSrDrUv+NkmBa/jD2/4dR3GNXNge/qPcEXXu0UMFxpWpmpm0XANrvd/n0uwk8CUBC7Yxg4UZMbUycwVXOU4WlRC79wO8sD/WfJB+lM8iqVqjZwNRml0bI7g5Rx2ArB5IeRTJdFWonprFKNR5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKx8886Ryv9AWFs+y3jn5oXWe/ABsBN72MuR2iQebbo=; b=Gx5HZ2WJlnTvz9Cxqom/Q3n3JIUkesZm+DCpRkr7WR/4Jn6xi7VD0R37XU76kSWAHCv5ozTgumoCPOTMQ7lhUa+uJzFmHPRAjzCmVZjh1wba4y/GdU2eCAb99IsS05nNF6im5MWrHGzr7imZlUoyoEpnFTICOAs2hnxRQ2kci4PF58iOt9R8IOL3XyJtzpociJtc9xbQ64f181N+w2aveF5VDCzK/j8pZ2nQuTiDprlP1MGsSbjwtz8hpVBMnZnpNfOYcQTDJC/sD3Cyxc+BMzW0M4oLPRLdk1zn2XX6Pi+kSMkhEUmASA/RI/EiHhwCJ59v/W04o59Ogo+b0gqA/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VKx8886Ryv9AWFs+y3jn5oXWe/ABsBN72MuR2iQebbo=; b=9CFI0Vt3kf8//cGV4WHnkD7qJSa7DXAYtswv+ijuKJWGz2d1Ewkb1tX4zjzrTNT4EGxpyl8Ciin/CQcUu7SQbVONVHjq1O3IuEwdIH5B+J6s8EJaoWiBUOFC1/WNSU7SkSEuv6DNWzJ0e0cr8FOft0pERJQQ2vUBtxd6PEuvq14= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM6PR08MB3351.eurprd08.prod.outlook.com (2603:10a6:209:48::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Wed, 19 Aug 2020 07:24:06 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3%5]) with mapi id 15.20.3305.025; Wed, 19 Aug 2020 07:24:06 +0000 From: Andrea Corallo To: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm , nd@arm.com Subject: [PATCH] libgccjit: update some comments in libgccjit.c Date: Wed, 19 Aug 2020 09:24:03 +0200 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-ClientProxiedBy: LO2P265CA0439.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::19) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e112547 (217.140.99.251) by LO2P265CA0439.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24 via Frontend Transport; Wed, 19 Aug 2020 07:24:05 +0000 X-Originating-IP: [217.140.99.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 68133c8d-2496-45d5-f12e-08d84410e070 X-MS-TrafficTypeDiagnostic: AM6PR08MB3351:|AM0PR08MB5345: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2xCv4GQ3VWEgMacMu9xNw/RMF3MEtbJNe2sRzR299I9iH9R5qAGeEKEv26v9JDyLYvLp9Au3ZJFWJn2+AFewgr0fHN2wI+VUscPxqQTVHyIzK9I1KVcdGvRBJjWr93FvxZcypwD9QsP2hk1eBJAZ0gZ1zf4Yf7TKYy6LiYrWjC0qxsAq+anXzYcqKmMUJfU3CkzrUwU00CtrTnb5sCWpysp2/b89CdL/4lPso2kKqwTaTqMKX5kNhxbzOgiDCXevut+nJADQNRGxBsCGZ4oJdfe7M8PjAt/QCLUyfKQaGV3Uhds06f5NwyxyR6Mk+h9Y X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(235185007)(66946007)(26005)(5660300002)(44832011)(316002)(36756003)(8676002)(16526019)(186003)(4326008)(2906002)(83380400001)(6486002)(6496006)(564344004)(8936002)(33964004)(2616005)(66616009)(66556008)(66476007)(86362001)(478600001)(956004)(15650500001)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 2D/BoSkkDATdikTDlkIdF5V0gn11C+t2+B9YOlXAJ5Wlb6a8QP2GQEzp6LtgWpppDMkSJwgGzObgslI/AWzcAQ0vLvDzWFvWKx3iF4UogvqUmUNsji0oijW9NYWv6F3JXwe2vTDzYR9IlUGop8zuYeV0LS4rPwYUvgQ0fY/UtgtaVR1QDS2SvddIRxr0g65qe239fgSbJyP2mZNwoeP9WN4UIS3/WKgs1PHA6ROy5gVNjSp5n/tr6d18uhr9eDlI7eO8YMjqq06lqvVPErm+DKdohJFNR5AdZizVU7imnuhRAlY3oKhaLuOJ6VwWcL6QeBm5by4PHuK6rrVqnCT6cYWL7pzMU3vl2swPC/+8Q9Mly1Tn4LnrJLsI+kRb403LMWxW5z2s/g5EXFvDAR9jrbArGxyUtAxCFhTaNouO4NdOKumxY1CAtntMSEF5Gwyv7qkz8cWmmIfm28/tiym08IdwzidI6mLz6rP66Lw4HrdJuWIjg/QglVdD49ikObLpxmxIDNRPvYuxEgCIJNsoB2KIHMPCt3I3amClbtHbR3+XvUn9SJQF08spU8rzoZF4V5EBa2iTyf63dmYs0p7dn3xehgm+cs2OmE6uhD6tLxwq11Dm+hbF5JQuSOfRn8qkc8BPX3KnYI0M2bzQDJIexg== X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3351 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 77bec649-f859-4f36-f6d2-08d84410db5b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JaVziNJO+Fodx48Vh4PyVczX16JlG1/UfSvb+3+zRMWRFEWSZeJYcx+zaYk8umA/tGkP2npslaT2DM6a4gg2iigKynSEv9Aofzk3uR9LK9nPOOOslHOrihaSHjwILw4dfv0PKriFnYpWdE4/dP8JGMD4glNxw2QL1uUgCmOb3QXymvORy8WROe/JzYo4LtYzJIyFPqxBIQZQaXvbL5dZt9/R2qAmAZLj3h1zPqrlPFX0t9AuP9TlQgnIeswOrVuZwxU0al7jG4ghOu3cmPdToYcmwUdzdQIYcT7OWYBqDL1yjVbqLc/CXtHOcykWwwmwewikzc3kKfmTa//PiC/ZEAMxYX5fJhsgCULqxUaHbH+IVZV7LoOe16CG3zoL+u8RVtJN0CCFqu9JCK/TvuCBVg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(46966005)(2616005)(36756003)(44832011)(336012)(956004)(235185007)(70206006)(66616009)(86362001)(8676002)(70586007)(5660300002)(8936002)(564344004)(356005)(2906002)(316002)(4326008)(26005)(478600001)(450100002)(16526019)(186003)(33964004)(6496006)(15650500001)(81166007)(47076004)(83380400001)(82740400003)(6486002)(82310400002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2020 07:24:14.8368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68133c8d-2496-45d5-f12e-08d84410e070 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5345 X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 07:24:18 -0000 --=-=-= Content-Type: text/plain Hi all, just a small patch updating some comments that apparently went out of sync a while ago adding gcc_jit_context_new_rvalue_from_long. Okay for trunk? Thanks Andrea --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=0001-libgccjit-Update-comments-for-gcc_jit_context_new_rv.patch >From 84b94a039d164878bdbf8bfd1a2038960f813c76 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Thu, 6 Aug 2020 10:25:40 +0200 Subject: [PATCH] libgccjit: Update comments for gcc_jit_context_new_rvalue_from* functions 2020-08-06 Andrea Corallo * libgccjit.c: (gcc_jit_context_new_rvalue_from_int) (gcc_jit_context_new_rvalue_from_long) (gcc_jit_context_new_rvalue_from_double) (gcc_jit_context_new_rvalue_from_ptr): Update function heading comments. --- gcc/jit/libgccjit.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gcc/jit/libgccjit.c b/gcc/jit/libgccjit.c index 3d04f6db3af..50130fbbe00 100644 --- a/gcc/jit/libgccjit.c +++ b/gcc/jit/libgccjit.c @@ -1188,7 +1188,7 @@ gcc_jit_rvalue_get_type (gcc_jit_rvalue *rvalue) /* Public entrypoint. See description in libgccjit.h. After error-checking, the real work is done by the - gcc::jit::recording::context::new_rvalue_from_int method in + gcc::jit::recording::context::new_rvalue_from_const method in jit-recording.c. */ gcc_jit_rvalue * @@ -1204,7 +1204,11 @@ gcc_jit_context_new_rvalue_from_int (gcc_jit_context *ctxt, ->new_rvalue_from_const (numeric_type, value)); } -/* FIXME. */ +/* Public entrypoint. See description in libgccjit.h. + + After error-checking, the real work is done by the + gcc::jit::recording::context::new_rvalue_from_const method + in jit-recording.c. */ gcc_jit_rvalue * gcc_jit_context_new_rvalue_from_long (gcc_jit_context *ctxt, @@ -1256,7 +1260,7 @@ gcc_jit_context_one (gcc_jit_context *ctxt, /* Public entrypoint. See description in libgccjit.h. After error-checking, the real work is done by the - gcc::jit::recording::context::new_rvalue_from_double method in + gcc::jit::recording::context::new_rvalue_from_const method in jit-recording.c. */ gcc_jit_rvalue * @@ -1275,8 +1279,8 @@ gcc_jit_context_new_rvalue_from_double (gcc_jit_context *ctxt, /* Public entrypoint. See description in libgccjit.h. After error-checking, the real work is done by the - gcc::jit::recording::context::new_rvalue_from_ptr method in - jit-recording.c. */ + gcc::jit::recording::context::new_rvalue_from_const method + in jit-recording.c. */ gcc_jit_rvalue * gcc_jit_context_new_rvalue_from_ptr (gcc_jit_context *ctxt, -- 2.17.1 --=-=-=--