From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67374 invoked by alias); 3 Oct 2019 12:47:58 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 67337 invoked by uid 89); 3 Oct 2019 12:47:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:a63, HX-Languages-Length:2046 X-Spam-Status: No, score=-10.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50061.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 12:47:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZsCn5l5Z/dGhBts8t1NSBqeMbTVDrh+DbsOOtIXIG4=; b=w/KgXmKi6v6Ff29rPWu/7+8nGQ/6PCf1qj1aHQUTT68+yrI9Q2UJos+S67J4Bm7KvmUgyk3ldn1ny9QbI47HgG6ZF13nMypVf5pldTTWAMuoANZnKPwtio9P2/CPcuF5exAmHnJ0qaH6gKQSjQwW/Btl/x/P7y9YOT412YrwHOo= Received: from AM6PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:20b:c0::16) by AM6PR08MB3048.eurprd08.prod.outlook.com (2603:10a6:209:46::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 12:47:48 +0000 Received: from AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by AM6PR08CA0028.outlook.office365.com (2603:10a6:20b:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.17 via Frontend Transport; Thu, 3 Oct 2019 12:47:48 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT034.mail.protection.outlook.com (10.152.16.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Thu, 3 Oct 2019 12:47:46 +0000 Received: ("Tessian outbound 0cf06bf5c60e:v33"); Thu, 03 Oct 2019 12:47:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0632a349afd34e9b X-CR-MTA-TID: 64aa7808 Received: from c3fc8e757517.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CEEFF1F2-BC53-44B8-B611-33A4B5DB42BB.1; Thu, 03 Oct 2019 12:47:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c3fc8e757517.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Oct 2019 12:47:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lfsq2jMvXwR8PlUrwxhdoGmRA1Hmm7CyjSbt69mtdmojSqsRghPVM/Zpj152SqT/55aO9TTViMmpwZigdc0WiTHUbH772+NCpU3l8czs65PdPsGM5Ek2XFxgs+Eqb8IYXMENDI32EN56ue8lk8iaVU/HLsaV/QiiAcPygIE6sMjuP/iLaiMeoqVWQdCOjbv/9BVKAcW8O1me5cmQM1I52PykBvyYcmbjn3G10dYOmbKMKebANCwlR1s2LuqFmFC/ikwYMTy9rglvSw6scaI4U+zvrBflh52Tp4ERfhfuTE8k05ytGzkleyw6DK2NqXxLjOk6RfkZuXyWKdY4BiivFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZsCn5l5Z/dGhBts8t1NSBqeMbTVDrh+DbsOOtIXIG4=; b=kzUKdZbzx16XTvdiv7Ezjsy5dKELCSvPybXiKOdbOz0xnFTxb4Fl3oXhWdQZ5bj1gh6rSPePkXA2QlQlyiKc4uoBteTFtt5CZVsw0ZwL6CA4iWrl3r+3GBkNeLnrBzheKS/jZLuRhzXWB2GNyqknlD44VTKbdorVrqvVoJppSjK6hOJtAseix++d0ayVgHS3uK+0FE/t7/aYTv5lviFX6F6u8B1oA698OvJZv1vH0h+AHHeMmgToOo7DiHbmbPsDATHEAl7QTEJN0aBw+PhLr490komjzKwLED3cU1i23csj+hg2XMeCLMt/dU1kfJRnlTlO4da1WiRjz334YwSxMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FZsCn5l5Z/dGhBts8t1NSBqeMbTVDrh+DbsOOtIXIG4=; b=w/KgXmKi6v6Ff29rPWu/7+8nGQ/6PCf1qj1aHQUTT68+yrI9Q2UJos+S67J4Bm7KvmUgyk3ldn1ny9QbI47HgG6ZF13nMypVf5pldTTWAMuoANZnKPwtio9P2/CPcuF5exAmHnJ0qaH6gKQSjQwW/Btl/x/P7y9YOT412YrwHOo= Received: from VE1PR08MB5070.eurprd08.prod.outlook.com (20.179.31.87) by VE1PR08MB4829.eurprd08.prod.outlook.com (10.255.113.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 12:47:37 +0000 Received: from VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63]) by VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63%6]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 12:47:36 +0000 From: Andrea Corallo To: Jeff Law CC: Andrea Corallo , Martin Jambor , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd , Jan Hubicka , Jan Hubicka Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928) Thread-Topic: [PATCH] IPA-CP release transformation summary (PR jit/91928) Thread-Index: AQHVd2523QqtznTQpUqREQRk5ZmYH6dD8WgAgAGg24CAAK5kgIACofAA Date: Tue, 01 Jan 2019 00:00:00 -0000 Message-ID: References: <29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com> In-Reply-To: <29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P123CA0031.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::19) To VE1PR08MB5070.eurprd08.prod.outlook.com (2603:10a6:803:10c::23) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.37] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: dcfaaa11-020a-4a3e-3d0f-08d747ffe469 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VE1PR08MB4829:|VE1PR08MB4829:|AM6PR08MB3048: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 01792087B6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(53754006)(199004)(189003)(54534003)(6246003)(6436002)(446003)(71190400001)(71200400001)(81156014)(81166006)(305945005)(229853002)(14444005)(2906002)(8936002)(53546011)(102836004)(386003)(6506007)(256004)(6916009)(25786009)(66946007)(36756003)(316002)(14454004)(54906003)(6512007)(3846002)(6116002)(186003)(8676002)(76176011)(6486002)(478600001)(26005)(86362001)(52116002)(4326008)(66066001)(99286004)(486006)(66556008)(7736002)(64756008)(66446008)(476003)(66476007)(44832011)(5660300002)(11346002)(2616005);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4829;H:VE1PR08MB5070.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GZEX9mSIXCsHi/gpC17J4orKJNkhSfpXs8kpwGZIefkC6P41RByaerpuuRkSEfzvevVUh5gyODKlqX0RPQ6CRoVpuTuf6jqHR/VCyHN3kuzwTs/RZTkZWy40NlhAdUzhoAoj9AEzQmD8QmM5hNgql54MMfj5HXhWk3tYCJ2wDAdD3Ts+hiKa8Y/t47jC2nIGEBxMy1DsOyEr3Bmm1D54gzuqW8aDsv8Whmx2M9IgNzec9/duFxRNsrTa9YleyrlfA1JcOlPdw9fTtSP+0oxFkY90i06DEW6c1mm/QVg9K51tWR/t6s27R3sQUHUjkDSDVhlsUWwNZ/vWq46tSzt/OqEzAf3t6KOQtPu4p4Icgt4V2a8nn6Pd2Dqx987Kh53a3eHNcgdE7BNS4phRfSAmEqSxcctbUBkoKqob6NAvd1k= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4829 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(39860400002)(199004)(54534003)(53754006)(189003)(102836004)(26005)(36906005)(14444005)(26826003)(22756006)(50466002)(14454004)(47776003)(186003)(478600001)(25786009)(305945005)(54906003)(7736002)(99286004)(53546011)(316002)(476003)(336012)(446003)(11346002)(386003)(6506007)(2616005)(126002)(486006)(2906002)(450100002)(63350400001)(229853002)(107886003)(86362001)(6862004)(76176011)(70206006)(70586007)(5660300002)(76130400001)(356004)(36756003)(66066001)(81166006)(81156014)(3846002)(6116002)(8676002)(6486002)(6246003)(4326008)(8936002)(8746002)(6512007)(23756003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB3048;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: eab6e5c0-be78-40f0-dd84-08d747ffde23 NoDisclaimer: True X-Forefront-PRVS: 01792087B6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OMnl/w0AyHVgq1CKSopSBDB/vUoAlH+ARfoQHnlmLU9Nor7m3GMOnkYwTopbAc8NXSzDU1D1CkI/hiczxphUxVVLSlA/nFWv5U5EUY/eVxzM9W+Ul+SsrEhFKVjucstmsZaOtY+AAwKYAWMfXSGthYKS+DfQhMAcrJVbiLhDeUdaErCQbzW0dje2O/kckS/ukWRwe4NlUKx7I6UIEHV/BRsSNHGccsWzqnLOnc2OFTns0R0p3JLW4Q0xydYmJ96YlCIZNLeTiM/uWf0w0XwrQNa/Cuqrdn88NBp896gvyz6Q2ye188O3M0fb4OxFRPUubOJ7DSAcgc8Yinb/gXioxsgPar/0aLhUffRR9tS1V2/PTDu8Vv68njBZL4o1GFsvuLGSL4p6xincFqJGrtEGEG63s0R/DQrgBPLsPJkIQHU= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2019 12:47:46.9708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dcfaaa11-020a-4a3e-3d0f-08d747ffe469 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3048 X-SW-Source: 2019-q4/txt/msg00002.txt.bz2 Jeff Law writes: > On 10/1/19 4:11 AM, Andrea Corallo wrote: >> Martin Jambor writes: >> >>> Hi, >>> >>> On Mon, Sep 30 2019, Andrea Corallo wrote: >>>> Hi all, >>>> I'd like to submit this patch. >>>> It release the ipa cp transformation summary after functions being exp= anded. >>>> This is to fix the compiler when used with libgccjit on subsequent >>>> compilations (every new compilation should have a clean transformation >>>> summary). >>> if this is a general problem then I think we should instead add another >>> hook to class ipa_opt_pass_d to free transformation summary, call it for >>> all IPA passes at the appropriate time and implement it for IPA-CP. That >>> way it will work for all IPA passes which might have a transformation >>> summary. >>> >>> Martin >>> >>> >>>> Bootstrap on arm64 and X86-64. >>>> >>>> Bests >>>> Andrea >>>> >>>> gcc/ChangeLog >>>> 2019-??-?? Andrea Corallo >>>> >>>> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum >>>> when finished. >>>> * ipa-prop.c (ipcp_free_transformation_sum): New function. >>>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. >> Hi, >> actually looking around in order to implement the suggestions I realized >> that already some code was put in place in toplev::finalize calling >> then ipa_cp_c_finalize exactly for this purpose. >> >> I've updated the patch accordingly. >> >> Bootstraped on aarch64. >> >> Is it okay for trunk? >> >> Bests >> Andrea >> >> gcc/ChangeLog >> 2019-??-?? Andrea Corallo >> >> * ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum. >> * ipa-prop.c (ipcp_free_transformation_sum): New function. >> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. > OK for the trunk. > > jeff Applied as r276507. The same patch applies cleanly onto gcc-9-branch, I think would be good to back port it cause libgccjit is not very usable without. Should we back port it? Bests Andrea