From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124622 invoked by alias); 1 Oct 2019 10:11:38 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 124598 invoked by uid 89); 1 Oct 2019 10:11:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.2 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2969 X-Spam-Status: No, score=-22.2 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20043.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 10:11:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcvXVtCJfUb7h59kNt9oujhWbWW/DfQJjBf4c3FGghM=; b=qEBfQI+Sox++M52YAq25HmkKSKyBfUPxtllCwGUsWN1J1RN6UxaZEF4zUqq3rNYBMSOCRpsGvq253ApgwldnxRQO2hB42hwuHyxo2mneVqRRhS3yR97merPDc/0Imxj7nilDUNIxoysp1ftZ5pWp810d+aoLSjLU593WMpHA01M= Received: from DB6PR0802CA0031.eurprd08.prod.outlook.com (2603:10a6:4:a3::17) by AM0PR08MB4099.eurprd08.prod.outlook.com (2603:10a6:208:12a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Tue, 1 Oct 2019 10:11:32 +0000 Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::203) by DB6PR0802CA0031.outlook.office365.com (2603:10a6:4:a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.20 via Frontend Transport; Tue, 1 Oct 2019 10:11:32 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Tue, 1 Oct 2019 10:11:31 +0000 Received: ("Tessian outbound 081de437afc7:v33"); Tue, 01 Oct 2019 10:11:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 73b46b788dc3fc29 X-CR-MTA-TID: 64aa7808 Received: from a1c078b0f35e.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id F455C9C4-BD02-437A-95C8-BB4B324D83DA.1; Tue, 01 Oct 2019 10:11:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a1c078b0f35e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 01 Oct 2019 10:11:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRh1kBYc2olzoALmEuyECnHkZt+w/E7AF9eA5gT1WW5i89Amsk7mxR1elN1TUVrUbkZvElx0BxJK7VWzESk/UZfYoZVrg8hykxP8qvZpM5WYNQlzP+ddKWJzRUxJ4IeHEyqewF1qYgqXK9mLpeCaWx33IeihGBIU+esKp1cJRrdL5oj5X74cZfDKf20epArNqfKxm8RgGbGYf0wiOA4kvRXcLv3vKPza79AGlqpU+MkbhZqrWWuXpr8q4dKNV/TYJxtLlYHqDIggooFlscYZfOZZeM4gK5oQVQTFJ9rrUqvPJN3eNpixyGOE+4rUQ3xs/oXPP6zAwi2DtRZnVfVGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcvXVtCJfUb7h59kNt9oujhWbWW/DfQJjBf4c3FGghM=; b=eV02VFFfoCkXWWEB/geYyC4K6Q7EyqRoyXkZalSEysxyKRqA4W7QVY4nEKTHMx5Dt74YU5uCTWkHXc0Fl9tq7WpxZA/KfuNHAtOMLa0kQg03YlenpHSavNjPaZ7pulu52lif/6BItmZfKHuH0Tge0NAyBY3lzTfw1l5Bwm0xEw9TUkZpt69PGyVybJptTz+KVrQv+yL3daPWOAx1HI8PAmSQhn0k2P8F0wA8psdylth+msXr59x0p3umMz6sZAqbOpObg2IOZAWIfrW9h1i3FgDovGsw0VsmR39vWVnWmnpIzz89ojsAZF7RiS16uFuOuMgrHNVsWlG8rdpxK+1UAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcvXVtCJfUb7h59kNt9oujhWbWW/DfQJjBf4c3FGghM=; b=qEBfQI+Sox++M52YAq25HmkKSKyBfUPxtllCwGUsWN1J1RN6UxaZEF4zUqq3rNYBMSOCRpsGvq253ApgwldnxRQO2hB42hwuHyxo2mneVqRRhS3yR97merPDc/0Imxj7nilDUNIxoysp1ftZ5pWp810d+aoLSjLU593WMpHA01M= Received: from VE1PR08MB5070.eurprd08.prod.outlook.com (20.179.31.87) by VE1PR08MB4734.eurprd08.prod.outlook.com (10.255.112.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.17; Tue, 1 Oct 2019 10:11:19 +0000 Received: from VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63]) by VE1PR08MB5070.eurprd08.prod.outlook.com ([fe80::a4a2:8364:f02c:a63%6]) with mapi id 15.20.2305.017; Tue, 1 Oct 2019 10:11:19 +0000 From: Andrea Corallo To: Martin Jambor CC: Andrea Corallo , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd , Jan Hubicka , Jan Hubicka Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928) Thread-Topic: [PATCH] IPA-CP release transformation summary (PR jit/91928) Thread-Index: AQHVd2523QqtznTQpUqREQRk5ZmYH6dD8WgAgAGg24A= Date: Tue, 01 Jan 2019 00:00:00 -0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0038.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::26) To VE1PR08MB5070.eurprd08.prod.outlook.com (2603:10a6:803:10c::23) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.37] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4b1efd15-f787-4abc-dcab-08d74657bba6 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VE1PR08MB4734:|VE1PR08MB4734:|AM0PR08MB4099: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0177904E6B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(54534003)(199004)(189003)(53754006)(81166006)(6506007)(66066001)(81156014)(8676002)(102836004)(6116002)(3846002)(25786009)(44832011)(76176011)(386003)(26005)(8936002)(99286004)(6916009)(52116002)(316002)(2906002)(86362001)(305945005)(7736002)(186003)(66446008)(36756003)(64756008)(66946007)(66616009)(66476007)(66556008)(486006)(476003)(2616005)(11346002)(14454004)(446003)(14444005)(71190400001)(71200400001)(229853002)(6436002)(5660300002)(99936001)(478600001)(6512007)(6486002)(6246003)(256004)(54906003)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4734;H:VE1PR08MB5070.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0LP2vrCUbGFArLaoJVmxCB2DzZzoC0OtKCK+6EtPKM5gTRsLuY/je6n4wG0PuhYHDuXnXQDKzgfxRJ6Dw437GBHpjW6s+jChNj4fgjoaAVB1st/4xkaBAdzpzN8iXaM0ka7NzF7qPGYFi1ICnEQ2bVGmpvR23SdGw5twd8Vw3Z15zE3zqXHNGdppzOKuqq0IPcaqGBYcpKejmTdI5bTRgIKOt+UaVzWFBE9Vi5F1ITkBtdEBc3LfCGLaDkpkjHzXajqnsklclIyp+LkQ5NHLWOYrmi85Rnioz8SkTgoBZfo7T8aAQ2tSR8wzPHhHzhz6RPKHuQheVK/1EIEM/ZfdG6dmIAKe5tJtccMehTQeSRmZRDe2yr8klfy0M7hzsoyonF3K9XCfb4RRZ9Lm4O9sDAMEKS867AMT23ItMkaarWg= Content-Type: multipart/mixed; boundary="_002_gkrr23wsrlmfsfarmcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4734 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Andrea.Corallo@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(376002)(136003)(39860400002)(346002)(1110001)(339900001)(189003)(199004)(54534003)(53754006)(446003)(6512007)(22756006)(186003)(356004)(54906003)(16586007)(316002)(6246003)(99936001)(14454004)(6862004)(4326008)(6486002)(26826003)(66616009)(70206006)(70586007)(107886003)(76130400001)(229853002)(86362001)(36756003)(66066001)(71190400001)(235185007)(568964002)(5660300002)(386003)(26005)(3846002)(76176011)(478600001)(2906002)(102836004)(45080400002)(25786009)(2476003)(6116002)(336012)(81166006)(8936002)(5024004)(14444005)(486006)(11346002)(2616005)(476003)(126002)(450100002)(99286004)(305945005)(8676002)(81156014)(6506007)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB4099;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 7deb3405-0ce5-48fc-edcf-08d74657b403 NoDisclaimer: True X-Forefront-PRVS: 0177904E6B X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sxhcnh4DlbXk1/XGYUrxLcnvwvbKsw47mGrK2+v7hlv5jXdrAMCSP2+swZLbBhMrzHTYsEK+IP0su9Lw5L2nfDLoqWjG+Gkr/4JvqxsQpk2gWB1mrY1m/+iqOATvITY6xF3sC+Il26ruThjzsry3+E8gCXR+fX5An7zPA4+mAv3VTnDkojqLZYJ7jd2itSMTMINJkdpO4DZ11fpzoDRw3VxS3iy+TDjnCHckVoRZm56vc0YaS9ItBYhVgTP9mvTeaTfe7DNUeVzztZ17kX7zXIEQe95RMam66ylqdZg5b8XateniWmOHqAB0DQzZZ2K9f9X3MANFlg0194P6ZZEJhGK1OPaXUo+CHHecIJm/Tpx8iL9fnkYkZpsMzpPMZQGhjLI0b4zaXpJe+THIM9rbHZ8kml6tCctMbk/s4Ch1Csc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2019 10:11:31.9797 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b1efd15-f787-4abc-dcab-08d74657bba6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4099 X-SW-Source: 2019-q4/txt/msg00000.txt.bz2 --_002_gkrr23wsrlmfsfarmcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1602 Martin Jambor writes: > Hi, > > On Mon, Sep 30 2019, Andrea Corallo wrote: >> Hi all, >> I'd like to submit this patch. >> It release the ipa cp transformation summary after functions being expan= ded. >> This is to fix the compiler when used with libgccjit on subsequent >> compilations (every new compilation should have a clean transformation >> summary). > > if this is a general problem then I think we should instead add another > hook to class ipa_opt_pass_d to free transformation summary, call it for > all IPA passes at the appropriate time and implement it for IPA-CP. That > way it will work for all IPA passes which might have a transformation > summary. > > Martin > > >> >> Bootstrap on arm64 and X86-64. >> >> Bests >> Andrea >> >> gcc/ChangeLog >> 2019-??-?? Andrea Corallo >> >> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum >> when finished. >> * ipa-prop.c (ipcp_free_transformation_sum): New function. >> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. Hi, actually looking around in order to implement the suggestions I realized that already some code was put in place in toplev::finalize calling then ipa_cp_c_finalize exactly for this purpose. I've updated the patch accordingly. Bootstraped on aarch64. Is it okay for trunk? Bests Andrea gcc/ChangeLog 2019-??-?? Andrea Corallo * ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum. * ipa-prop.c (ipcp_free_transformation_sum): New function. * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. --_002_gkrr23wsrlmfsfarmcom_ Content-Type: text/x-diff; name="91928.patch" Content-Description: 91928.patch Content-Disposition: attachment; filename="91928.patch"; size=1407; creation-date="Tue, 01 Oct 2019 10:11:19 GMT"; modification-date="Tue, 01 Oct 2019 10:11:19 GMT" Content-ID: <4C544822B276774EA7F977AFA0563798@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 Content-length: 1908 ZGlmZiAtLWdpdCBhL2djYy9pcGEtY3AuYyBiL2djYy9pcGEtY3AuYw0KaW5k ZXggYjRmYjc0ZS4uMmI0MDIyMCAxMDA2NDQNCi0tLSBhL2djYy9pcGEtY3Au Yw0KKysrIGIvZ2NjL2lwYS1jcC5jDQpAQCAtNTMwNSw0ICs1MzA1LDUgQEAg aXBhX2NwX2NfZmluYWxpemUgKHZvaWQpDQogICBtYXhfY291bnQgPSBwcm9m aWxlX2NvdW50Ojp1bmluaXRpYWxpemVkICgpOw0KICAgb3ZlcmFsbF9zaXpl ID0gMDsNCiAgIG1heF9uZXdfc2l6ZSA9IDA7DQorICBpcGNwX2ZyZWVfdHJh bnNmb3JtYXRpb25fc3VtICgpOw0KIH0NCmRpZmYgLS1naXQgYS9nY2MvaXBh LXByb3AuaCBiL2djYy9pcGEtcHJvcC5oDQppbmRleCAzMDk0OGZiLi4wZmY4 MDg1IDEwMDY0NA0KLS0tIGEvZ2NjL2lwYS1wcm9wLmgNCisrKyBiL2djYy9p cGEtcHJvcC5oDQpAQCAtNTYxLDYgKzU2MSw3IEBAIHN0cnVjdCBHVFkoKCkp IGlwY3BfdHJhbnNmb3JtYXRpb24NCiB2b2lkIGlwYV9zZXRfbm9kZV9hZ2df dmFsdWVfY2hhaW4gKHN0cnVjdCBjZ3JhcGhfbm9kZSAqbm9kZSwNCiAJCQkJ ICAgc3RydWN0IGlwYV9hZ2dfcmVwbGFjZW1lbnRfdmFsdWUgKmFnZ3ZhbHMp Ow0KIHZvaWQgaXBjcF90cmFuc2Zvcm1hdGlvbl9pbml0aWFsaXplICh2b2lk KTsNCit2b2lkIGlwY3BfZnJlZV90cmFuc2Zvcm1hdGlvbl9zdW0gKHZvaWQp Ow0KIA0KIC8qIGlwYV9lZGdlX2FyZ3Mgc3RvcmVzIGluZm9ybWF0aW9uIHJl bGF0ZWQgdG8gYSBjYWxsc2l0ZSBhbmQgcGFydGljdWxhcmx5IGl0cw0KICAg IGFyZ3VtZW50cy4gIEl0IGNhbiBiZSBhY2Nlc3NlZCBieSB0aGUgSVBBX0VE R0VfUkVGIG1hY3JvLiAgKi8NCmRpZmYgLS1naXQgYS9nY2MvaXBhLXByb3Au YyBiL2djYy9pcGEtcHJvcC5jDQppbmRleCAyZjJiMDcwLi4xNThkYmU3IDEw MDY0NA0KLS0tIGEvZ2NjL2lwYS1wcm9wLmMNCisrKyBiL2djYy9pcGEtcHJv cC5jDQpAQCAtMzc1OCw2ICszNzU4LDE4IEBAIGlwY3BfdHJhbnNmb3JtYXRp b25faW5pdGlhbGl6ZSAodm9pZCkNCiAgICAgaXBjcF90cmFuc2Zvcm1hdGlv bl9zdW0gPSBpcGNwX3RyYW5zZm9ybWF0aW9uX3Q6OmNyZWF0ZV9nZ2MgKHN5 bXRhYik7DQogfQ0KIA0KKy8qIFJlbGVhc2UgdGhlIElQQSBDUCB0cmFuc2Zv cm1hdGlvbiBzdW1tYXJ5LiAgKi8NCisNCit2b2lkDQoraXBjcF9mcmVlX3Ry YW5zZm9ybWF0aW9uX3N1bSAodm9pZCkNCit7DQorICBpZiAoIWlwY3BfdHJh bnNmb3JtYXRpb25fc3VtKQ0KKyAgICByZXR1cm47DQorDQorICBpcGNwX3Ry YW5zZm9ybWF0aW9uX3N1bS0+cmVsZWFzZSAoKTsNCisgIGlwY3BfdHJhbnNm b3JtYXRpb25fc3VtID0gTlVMTDsNCit9DQorDQogLyogU2V0IHRoZSBhZ2dy ZWdhdGUgcmVwbGFjZW1lbnRzIG9mIE5PREUgdG8gYmUgQUdHVkFMUy4gICov DQogDQogdm9pZA0K --_002_gkrr23wsrlmfsfarmcom_--