From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by sourceware.org (Postfix) with ESMTPS id 714E33857C6D; Wed, 9 Sep 2020 07:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 714E33857C6D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrea.Corallo@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=48d8jkQ3aUFjnIHNtnIhQ7pHiI2LZoLEIsP+CzrLsig=; b=GcpBLYTRuzMFDix/e2BwUBqKkdhDlHdSWhYDPiQ4adOHBmZnF2NPhn2lF4ueoPrfyKNYigO6iPA5gaIJ+Wh9OgK6yhqgMCP/l76Av9JntjbKPMIQFs7j03IIAaXzf6lWPn6Brjvv44aRM39vUGbUWjr2tJG5RvlCJ6KpTm34knQ= Received: from DB8PR09CA0025.eurprd09.prod.outlook.com (2603:10a6:10:a0::38) by DBAPR08MB5557.eurprd08.prod.outlook.com (2603:10a6:10:1a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Wed, 9 Sep 2020 07:56:49 +0000 Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::b8) by DB8PR09CA0025.outlook.office365.com (2603:10a6:10:a0::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Wed, 9 Sep 2020 07:56:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Wed, 9 Sep 2020 07:56:49 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Wed, 09 Sep 2020 07:56:49 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0ee49acf8be97ab5 X-CR-MTA-TID: 64aa7808 Received: from d58f935bc026.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36A9570F-7380-43DC-86B7-B5FDD2E8FBB4.1; Wed, 09 Sep 2020 07:56:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d58f935bc026.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Sep 2020 07:56:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4ahGozrumV3XKduUYxV+cUNj7js6PKDf5+Pq1VdqcJMoil/uHToyOs0OIYtSDjg57mG16+SeQw5mJyeKWtU4GutIC2knux1yFD8E0pH0u1SoxzO4BvmYNN+hn9WU6fPiYGKlEos9SzeYXuNCen1ykxrIzowgD39iOCMvO/Rt3F9Y5Ez18irKYfFmyP6ymxy7d+DA3la4PbfAEby1S25NtA1rIgHzs1itpre/8SEOrn4yRn0u4YU9YEZyFLgHp++sl5ys23NGbl2zMFWND+/gnhu8Za0FHyEis0I99Ft/icFtmxNLAJzgc1J8XCRfm+XQIzwNYVWH4Ol1q4N/PiNig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=48d8jkQ3aUFjnIHNtnIhQ7pHiI2LZoLEIsP+CzrLsig=; b=jGpuGpTUeuCt0ng1yB0ZJx9xC2zLqfIFFzZ7qfmMMipcnA4h1bJLugFObe/o6DuMqGhToqatFhbPxJFNJJbH+sI2etYxiaf8FJyW3kv3yZxjhMlUeoU4+QF5/uWyoLalBFFJ8DD7CQhbSE3VuORr2oy26oo7k6cAOVMa37R0bcBa7krvuoZ4dZ3+ijCcZwJB8Wa0r4Ao4XDUYxu9B4Uo+ebOloPlcf462L9KnpkmPS/1MkVMIuM1ixeqhkYYdgnOZICltjALETYwOhReIsE5j6E/AUymvDZKmbX/tjURP5dvCrNqiRxkH04IRC45NNgK0M7KOlPbedBuAuMMdj+PHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=48d8jkQ3aUFjnIHNtnIhQ7pHiI2LZoLEIsP+CzrLsig=; b=GcpBLYTRuzMFDix/e2BwUBqKkdhDlHdSWhYDPiQ4adOHBmZnF2NPhn2lF4ueoPrfyKNYigO6iPA5gaIJ+Wh9OgK6yhqgMCP/l76Av9JntjbKPMIQFs7j03IIAaXzf6lWPn6Brjvv44aRM39vUGbUWjr2tJG5RvlCJ6KpTm34knQ= Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) by AM7PR08MB5352.eurprd08.prod.outlook.com (2603:10a6:20b:10e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Wed, 9 Sep 2020 07:56:40 +0000 Received: from AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3]) by AM6PR08MB4900.eurprd08.prod.outlook.com ([fe80::d070:f136:4090:9ed3%5]) with mapi id 15.20.3348.019; Wed, 9 Sep 2020 07:56:40 +0000 From: Andrea Corallo To: David Malcolm via Jit Cc: nd , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libgccjit: Improve doc and comments regarding type casts References: Date: Wed, 09 Sep 2020 09:56:39 +0200 In-Reply-To: (Andrea Corallo's message of "Thu, 06 Aug 2020 09:40:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0272.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::20) To AM6PR08MB4900.eurprd08.prod.outlook.com (2603:10a6:20b:cc::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from e124257 (217.140.106.37) by LO2P265CA0272.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Wed, 9 Sep 2020 07:56:40 +0000 X-Originating-IP: [217.140.106.37] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2c36b158-784b-4c22-e583-08d85495e7f9 X-MS-TrafficTypeDiagnostic: AM7PR08MB5352:|DBAPR08MB5557: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 762uTeBRArmW088NxsubCiQ0tzs5QINTPxe9mzKiY9nYM4O4LpUb4fYGGKOIrQ6Svb6FqqOzlX4P9HoMZsxbyj89F+1H0cCADCRr2WIlfiXxerhCQ9Stj+/vwQQ5PhCVsvtcA/deAfe45d1Gnzprg7t+IYMYCfW7xOZOtJyVu4sPmvGMo1hPysvHIRmZYxZoV+7NX8VNrxsenPIa7nE0gr0hAfzxoH6Qhv9JIuM5nBK7+94A87QQlhdh5uRwWWso9ckNFjdKxgeaQbEQ/W4Jf8iyjiVziltFt/pZBoSE0u1fuWMTEQzOAeK75PEKBOJ1v9KuqaYdp6h+IfDCL64CnQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR08MB4900.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(39850400004)(366004)(396003)(5660300002)(66476007)(66556008)(6496006)(2906002)(52116002)(53546011)(86362001)(450100002)(4326008)(36756003)(26005)(16526019)(6916009)(186003)(66946007)(8936002)(2616005)(956004)(478600001)(6486002)(44832011)(8676002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 0YimsPWJ+JU9vvXPN7ka16InB+lFoyFdbs3ZpTgqXfj8Pb+Umg/PIpb9K8CHAKKNerHeYMi9CrJH030mVoJ7CdJRMTg4hOQmgBjrlLUt+Z/PFBgmOQBsWM+QGo9nvTC67llXAW1IQ2dZmdPUV4KlAguxVw1FSxdjlWZ7GfQD04a7LPHiqHW5jnivVHMxI6DUSlsg9XPUG/D8mj9hgFMB6mM1ejH/ciiTfoadk1POCIYZ5jFKtl9DmLwUIKZKBc/U9ywHTgQw5/o+G8VuwHoAbsHx7MvO3hLJwptmCXnzI7V4QhzotM5oOu9le4ByXHmUTxd7Yu0kE9fxvj+3cvPPb1Kd6i8PE1gCOXtcFkF0YghLSLvrzDoiZJ79ydQuh6+JKPisCpLAVvbEAsJ+PKaewwZEHIyAoJ6Mei/4BROwDR+ZGdy9IKD/ORt76SSkIKz4NFbg5cK58W3/pq19tBdrpXIWqV9qBUpqgBQhBlAz4Zgc4NapmBVUCgshtRZ6j1pAqdsdF+8G03jWt8WLl5AvJNGuwMcQVmRA6tC6kCca7Ho5KmljaYx0XdKVzbD/XVuRT8UOG8fFqHODlWYZ2m3P0jCc4ZmAFFyXFfboi043Al0GTiuBJZaQdF3TtyiQiArih84ze9/cOKak5lO8cJcQBQ== X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5352 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 783b5a07-4d48-41f7-4bd0-08d85495e2ad X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IfLTwNFRrrGl/r7PwvTpyago/4XaR8GhOVPb66HTD5osODzZKgQ4fhja0a+I7fpHe9EFKcN0eHjEoPXdZu+KQXKimJW5Ax3P5JgjUZOrd3GCCLIohc5OsfoMfn+WgWvR0Ri6BFgzRHI8874G70rJhiFqmMErOSv8qw2SMAj0Ua5YdZqlhuDxmGr3Y/ebcFKJQfw0NtED585+eUt0aT+qmmRCGH7n5HW5E7e1hcZ65jVR2cDMQaSgDq6Ct7XZgj0xwKMmaPj/G7EnEcHc1lqlConbBW89izC39NoiI64ogk3pm3eSPC78koYvH4NF2pnKor7uF+Ftyjuxlo8mcDvFSn8FUXYifiuteSc34hSbKqzgTNOl0dTNGNzuzM14AE8VpBP/Dog8THNN+yYalpaaeQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(39850400004)(346002)(136003)(376002)(46966005)(44832011)(8936002)(26005)(5660300002)(6916009)(36756003)(2616005)(86362001)(956004)(316002)(6486002)(70206006)(70586007)(53546011)(6496006)(8676002)(478600001)(82740400003)(2906002)(450100002)(186003)(47076004)(16526019)(356005)(81166007)(336012)(82310400003)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2020 07:56:49.1599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c36b158-784b-4c22-e583-08d85495e7f9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5557 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 07:56:53 -0000 Andrea Corallo writes: > Andrea Corallo writes: > >> Hi Alex, >> >> Looking at the code I believe all these casts are meant to be supported >> (read your intuition was correct). >> >> Also IMO source of confusion is that the doc is mentioning 'int' and >> 'float' but I believe would be better to have like 'integral' and >> 'floating-point' to clearly disambiguates with respect to the C >> types. >> >> AFAIU the set of supported casts should be like: >> >> integral <-> integral >> floating-point <-> floating-point >> integral <-> floating-point >> integral <-> bool >> P* <-> Q* for pointer types P and Q. >> >> I'd propose to install the following patch to make doc and comments >> homogeneous at documenting what do we accept, and I guess we should just >> consider bugs if some of these conversions is not handled correctly or >> leads to ICE. >> >> Bests >> >> Andrea >> >> gcc/jit/ChangeLog >> >> 2020-07-21 Andrea Corallo >> >> * docs/_build/texinfo/libgccjit.texi (Type-coercion): Improve doc >> on allowed type casting. >> * docs/topics/expressions.rst (gccjit::context::new_cast) >> (gcc_jit_context_new_cast): Likewise. >> * libgccjit.c: Improve comment on allowed type casting. >> * libgccjit.h: Likewise >> >> From 914b9e86808c947d4bb2b06c6960fd8031125f67 Mon Sep 17 00:00:00 2001 >> From: Andrea Corallo >> Date: Tue, 21 Jul 2020 20:12:23 +0200 >> Subject: [PATCH] libgccjit: improve documentation on type conversions [...] > Ping > > Thanks > Andrea Ping