From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54783 invoked by alias); 10 Jan 2019 21:18:45 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 54772 invoked by uid 89); 10 Jan 2019 21:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=sorting X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx.sdf.org Received: from ol.sdf.org (HELO mx.sdf.org) (205.166.94.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Jan 2019 21:18:43 +0000 Received: from sdf.org (IDENT:akrl@sverige.freeshell.org [205.166.94.5]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id x0ALIaU6027721 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO); Thu, 10 Jan 2019 21:18:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sdf.org; s=default; t=1547155121; bh=ERZekVPO+6sKPhq8jmMvmvDOGx6UHh5Wv1GnzgKYxeU=; h=From:To:Cc:Subject:In-Reply-To:Date; b=mCANLNtOVGnnvnPB3RL00F/WfK4fiias1dAcY75UuzpYQMmkPL9d4VoOKMSil1Baq PLZvDCkB4vl0estNUrSvDEqawdBP2k7CcHMGH7I2GQL+kuloU8V/+Vju7D+OoPUhsq EHIBqV82YEKojERAEVZUYWvASUQrTshfUwfnEbvI= Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id x0ALIZcH006525; Thu, 10 Jan 2019 21:18:35 GMT From: akrl To: David Malcolm Cc: marc@nieper-wisskirchen.de, basile@starynkevitch.net, jit@gcc.gnu.org Subject: Re: about header file parsing In-Reply-To: <1547148632.7788.167.camel@redhat.com> (message from David Malcolm on Thu, 10 Jan 2019 14:30:32 -0500) Date: Tue, 01 Jan 2019 00:00:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00037.txt.bz2 David Malcolm writes: > On Thu, 2019-01-10 at 19:06 +0000, akrl wrote: > > [...] > >> Hi, >> today I've wrote a patch that adds GCC_JIT_STR_NEEDED_LIBRARIES to >> gcc_jit_str_option. >> This was to specify a space separated list of the libraries to link >> against. >> I was going to submit the patch for review but this solution seams to >> be >> more general. > > FWIW, although it sounds like it's no longer relevant here, I prefer to > avoid extending the > enum gcc_jit_str_option > and > enum gcc_jit_int_option > enumerations, in favor of adding new API entrypoints, for the ABI- > detection reason given here: > https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#options > > i.e. "Adding entrypoints for each new option means that client code > that use the new options can be identified directly from binary > metadata, which would not be possible if we instead extended the > various enum gcc_jit_*_option." Okay then lets go for gcc_jit_context_add_driver_option then. > >> If we agree on an interface I propose my self to do the patch in >> order >> to have the occasion to setup the whole process. >> >> Bests >> >> Andrea > > It's great to have new contributors to the project. > > Andrea: FWIW, the FSF requires some legal paperwork before I can accept > non-trivial patches; see: > https://gcc.gnu.org/contribute.html#legal > If you're hoping to send non-trivial patches, it might be an idea to > look into that (unless you already have the FSF paperwork in place?) Yes thanks I'm aware of the process. I'm sorting that out together with my employer these days. Bests! Andrea -- akrl@sdf.org