public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: "Sudarshan S Chawathe" <chaw@eip10.org>
To: kawa <kawa@sourceware.org>
Subject: Missing else-clause in strings-test.scm (trivial patch)
Date: Wed, 14 Jun 2017 14:42:00 -0000	[thread overview]
Message-ID: <24455.1497451353@vereq.eip10.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]


The cond-expand near the end of testsuite/strings-test.scm is missing an
else clause.  It's probably fine as is but the else clause may be worth
adding just for consistency.

Regards,

-chaw


[-- Attachment #2: strings-test-cond-expand-else.patch --]
[-- Type: text/x-diff, Size: 535 bytes --]

diff --git a/testsuite/strings-test.scm b/testsuite/strings-test.scm
index ef655e1..c12e528 100644
--- a/testsuite/strings-test.scm
+++ b/testsuite/strings-test.scm
@@ -2871,8 +2871,8 @@
   (test-equal "c😼b😂a" (reverse-list->string '(#\a #\😂 #\b #\😼 #\c)))
 
   (test-equal "y😂a😼xy" (xsubstring "a😼xy😂" 3 9))
-  (test-equal "y😂a😼" (xsubstring "a😼xy😂" -2 2))
-))
+  (test-equal "y😂a😼" (xsubstring "a😼xy😂" -2 2)))
 ;; end section with UTF-8 literals
+ (else))
 
 (test-end)

                 reply	other threads:[~2017-06-14 14:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24455.1497451353@vereq.eip10.org \
    --to=chaw@eip10.org \
    --cc=kawa@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).