From: Per Bothner <per@bothner.com>
To: Panicz Maciej Godek <godek.maciek@gmail.com>
Cc: kawa@sourceware.org
Subject: Re: Building for Android
Date: Fri, 21 Oct 2022 23:26:12 -0700 [thread overview]
Message-ID: <3077976f-5161-3069-f540-5fb79ef95665@bothner.com> (raw)
In-Reply-To: <CAMFYt2Y3gU9ZZrLYbNYF_3Ad9TyMzuRE7ZaqMZrwC8TXpsO6nQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On 10/21/22 12:45, Panicz Maciej Godek wrote:
> During its compilation, Kawa issues the following warning:
>
> subclass-refering-to-mangled-superclass-property.scm:6:4: warning - no declaration seen for mangled-name
The attached patch seems to fix it.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
[-- Attachment #2: tr-diff.txt --]
[-- Type: text/plain, Size: 823 bytes --]
diff --git a/kawa/lang/Translator.java b/kawa/lang/Translator.java
index d01e83618..745b23d78 100644
--- a/kawa/lang/Translator.java
+++ b/kawa/lang/Translator.java
@@ -877,9 +877,8 @@ public class Translator extends Compilation
} else {
gnu.expr.SourceName snameAnn =
part.getAnnotation(gnu.expr.SourceName.class);
- String pname = snameAnn == null ? part.getName()
- : snameAnn.name();
- if (! dname.equals(pname))
+ // If SourceName annotation, require exact match.
+ if (snameAnn != null && ! dname.equals(snameAnn.name()))
continue;
}
Expression part1;
next prev parent reply other threads:[~2022-10-22 6:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:57 Panicz Maciej Godek
2022-10-18 15:25 ` Per Bothner
2022-10-18 18:25 ` Panicz Maciej Godek
2022-10-19 9:15 ` Panicz Maciej Godek
2022-10-19 16:05 ` Per Bothner
2022-10-19 17:09 ` Panicz Maciej Godek
2022-10-20 5:35 ` Panicz Maciej Godek
2022-10-20 20:48 ` Panicz Maciej Godek
2022-10-21 5:14 ` Panicz Maciej Godek
2022-10-21 13:59 ` Panicz Maciej Godek
2022-10-21 18:11 ` Per Bothner
2022-10-21 19:19 ` Panicz Maciej Godek
2022-10-21 19:31 ` Per Bothner
2022-10-21 19:45 ` Panicz Maciej Godek
2022-10-21 20:13 ` Panicz Maciej Godek
2022-10-22 6:26 ` Per Bothner [this message]
2022-10-22 9:31 ` Panicz Maciej Godek
2022-10-22 12:08 ` Panicz Maciej Godek
2022-10-24 7:22 ` Panicz Maciej Godek
2022-10-24 10:48 ` Per Bothner
2022-10-24 12:01 ` Panicz Maciej Godek
2022-10-21 18:00 ` Per Bothner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3077976f-5161-3069-f540-5fb79ef95665@bothner.com \
--to=per@bothner.com \
--cc=godek.maciek@gmail.com \
--cc=kawa@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).