public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: Per Bothner <per@bothner.com>
To: craven@gmx.net
Cc: kawa mailing list <kawa@sourceware.org>
Subject: Re: Problem with macro that expands to define-simple-class
Date: Wed, 05 Sep 2012 16:08:00 -0000	[thread overview]
Message-ID: <50477867.6020205@bothner.com> (raw)
In-Reply-To: <87k3w8q2ve.fsf@nexoid.at>

On 09/05/2012 01:40 AM, craven@gmx.net wrote:
> I've run into a problem with a syntax-rules macro that expands to a
> DEFINE-SIMPLE-CLASS statement:

First, note that the expand utility has to do a complicated job of
"decompiling" a macro expansion, and the implementation is incomplete.
Spcifically, I don't believe it handles ClassExp, which is what
define-simple-class expands to.

Secondly, I notice you bind the macro parameter name to the string "games".
This is used for the class name.  Kawa allows this, but it probably
shouldn't, and it has not been tested much if at all.  Instead use
an identifier (symbol):

(define-simple-database-helper games "database" 1 ...)
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

      reply	other threads:[~2012-09-05 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  8:40 craven
2012-09-05 16:08 ` Per Bothner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50477867.6020205@bothner.com \
    --to=per@bothner.com \
    --cc=craven@gmx.net \
    --cc=kawa@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).