Problem with macro that expands to define-simple-class

Problem with macro that expands to define-simple-class

[craven]

I've run into a problem with a syntax-rules macro that expands to a
DEFINE-SIMPLE-CLASS statement:

(define-syntax define-simple-database-helper 
  (syntax-rules ()
    ((_ name log-name version (table-name create-statement) ...)
     (define-simple-class name
  (<android.database.sqlite.SQLiteOpenHelper>)
       ((*init* (context :: <Context>))
       (invoke-special <android.database.sqlite.SQLiteOpenHelper> (this) '*init* context log-name #!null version))
       ((onCreate (db :: <android.database.sqlite.SQLiteDatabase>)) ::
  void
  (for-each (lambda (sql)
                (db:execSQL sql))
                              (list create-statement ...)))
       ((onUpgrade (db :: <android.database.sqlite.SQLiteDatabase>) (old-version :: int) (new-version :: int))
  (for-each (lambda (name)
                (db:execSQL (format "drop table if exists ~a" name)))
                              (list table-name ...))
                              (onCreate db))))))

Usage would be like this:

(define-simple-database-helper "games" "database" 1
  ("categories" "create table categories (_id text primary key, name text not null);")
  ("games" "create table games (_id text primary key, name text not null);"))

But loading the definition into svn kawa as of right now and using
(require 'syntax-utils) and EXPAND shows:

(let ((games #!undefined))
 (set games (lambda (*init* onCreate onUpgrade) #!null)))

Is there a way to write this macro (using syntax-rules)?

Thanks for any help!

Peter

Re: Problem with macro that expands to define-simple-class

[Per Bothner]

On 09/05/2012 01:40 AM, craven@gmx.net wrote:
> I've run into a problem with a syntax-rules macro that expands to a
> DEFINE-SIMPLE-CLASS statement:

First, note that the expand utility has to do a complicated job of
"decompiling" a macro expansion, and the implementation is incomplete.
Spcifically, I don't believe it handles ClassExp, which is what
define-simple-class expands to.

Secondly, I notice you bind the macro parameter name to the string "games".
This is used for the class name.  Kawa allows this, but it probably
shouldn't, and it has not been tested much if at all.  Instead use
an identifier (symbol):

(define-simple-database-helper games "database" 1 ...)
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/