public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: Per Bothner <per@bothner.com>
To: kawa@sourceware.org
Subject: Re: Testsuite failing
Date: Thu, 10 Jul 2014 01:34:00 -0000	[thread overview]
Message-ID: <53BDED98.6080600@bothner.com> (raw)
In-Reply-To: <53BDBBD9.2040304@bothner.com>



On 07/09/2014 03:02 PM, Per Bothner wrote:
>
>
> On 07/08/2014 09:24 PM, Matthieu Vachon wrote:
>> Here a patch that make `testsuite/errors3.scm` pass. The message was
>> expecting `... with required type int` while it's now `... with
>> required type character`.
>>
>> Maybe the code should be fixed and not the test ... not sure about it.
>
> The test us fine.  The problem is the code in kawa.standard.Scheme#formatTest.
> Specifically how it enters both T and T.getImplementationType() into the
> typeToStringMap.  Thia looses if T is the character type, since the
> implementation type for T is int.

I checked in a fix.

(If it wasn't clear: The reason for the Java 7 vs Java 8 inconsistency
isn't anything "real".  Rather it is due to unspecified traversal order
of hash tables.  Somehow Java 8 tweaked the implementation enough so
the bug was hidden on Java 8.)

-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

  reply	other threads:[~2014-07-10  1:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09  4:24 Matthieu Vachon
2014-07-09  4:47 ` Matthieu Vachon
2014-07-09  4:49   ` Matthieu Vachon
2014-07-09 22:03 ` Per Bothner
2014-07-10  1:34   ` Per Bothner [this message]
2014-07-10  2:09     ` Matthieu Vachon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BDED98.6080600@bothner.com \
    --to=per@bothner.com \
    --cc=kawa@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).