public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: Per Bothner <per@bothner.com>
To: Kay Zheng <l04m33@gmail.com>, Kawa mailing list <kawa@sourceware.org>
Subject: Re: The "--no-inline" option caused Kawa to generate invalid bytecode
Date: Thu, 05 Oct 2017 06:29:00 -0000	[thread overview]
Message-ID: <5e4c6efe-e2ad-8984-7ef9-790c79fdfa4b@bothner.com> (raw)
In-Reply-To: <CAJCc8OwD+ea+e29=dPhGoZ9W8fZms_i-aOOLcxHrKgPZYANyrg@mail.gmail.com>

On 09/04/2017 03:25 AM, Kay Zheng wrote:
> Hi Per,
> 
> I think I hit a bug regarding "(define-early-constant ...)" and the
> "--no-inline" option. This is the problematic program:

... [caused a VerifyError].

The problem was that one point Kawa thought the current bytecode
location was "unreachable" - as it would be after a goto instruction.
That is why it didn't generate the necessary instructions.
Fixing that problem was relatively easy, but then I ran into another
problem in generating the stack-map tables (which are used by the verifier)
Fixing that problem looked messy and difficult.

I tried the test-case using the bytecode2 branch (announced in the
previous message) - and that worked.

So I decided to "punt" on this problem for now, and wait for it to be
fixed when bytecode2 is merged into master.  Sorry about that.
Until the code is merged, I welcome testing of the bytecode2 branch.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

      parent reply	other threads:[~2017-10-05  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 10:25 Kay Zheng
2017-09-05  3:28 ` Per Bothner
2017-09-05 16:51   ` Kay Zheng
2017-10-05  6:29 ` Per Bothner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e4c6efe-e2ad-8984-7ef9-790c79fdfa4b@bothner.com \
    --to=per@bothner.com \
    --cc=kawa@sourceware.org \
    --cc=l04m33@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).