From: Per Bothner <per@bothner.com>
To: Sudarshan S Chawathe <chaw@eip10.org>
Cc: Kawa mailing list <kawa@sourceware.org>
Subject: Re: please try out the Kawa binary pre-release
Date: Thu, 03 Nov 2016 17:46:00 -0000 [thread overview]
Message-ID: <6778948f-da43-ed6e-6f34-b3eabca0ac9d@bothner.com> (raw)
In-Reply-To: <7753.1478163506@vereq.eip10.org>
On 11/03/2016 01:58 AM, Sudarshan S Chawathe wrote:
>
> I noticed a minor problem: The automatic CLASSPATH-setting code in the
> 'kawa' shell script does not do the intended (I think) thing when that
> shell script is invoked as "./kawa" (leading to an error "Could not find
> or load main class kawa.repl). I believe a small change to the sed
> command in the kawa script does the trick:
>
> kawadir=`echo "$thisdir" | sed -e 's|/bin\(/.\)*$||'`
>
> Perhaps it is safe to replace the '*' with a '?', but the above will
> cover the case of multiple trailing './' substrings if they somehow
> appear.
Thanks! I checked your fix into Subversion.
With one minor change: I escaped the period:
kawadir=`echo "$thisdir" | sed -e 's|/bin\(/\.\)*$||'`
> I am including a context diff below for completeness sake.
For future reference: Most people and projects these days prefer
unified (-u) diffs. Also note your patch was reversed.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
next prev parent reply other threads:[~2016-11-03 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 22:59 Per Bothner
2016-11-03 8:58 ` Sudarshan S Chawathe
2016-11-03 17:46 ` Per Bothner [this message]
2016-11-07 19:59 ` new (last?) " Per Bothner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6778948f-da43-ed6e-6f34-b3eabca0ac9d@bothner.com \
--to=per@bothner.com \
--cc=chaw@eip10.org \
--cc=kawa@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).