Add SRFI-197 Implementation for Kawa

Add SRFI-197 Implementation for Kawa

[Alcides Flores Pineda]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hello everybody:

I hope you are all fine and in good health.

After  being searching  for something  like the  "threading-macros" that
exist  in a  couple of  Lisp dialects  out there,  I finally  managed to
add/integrate a syntax-case implementation of SRFI-197 for Kawa as it is
shown in the reference implementation.

* https://github.com/ar-nelson/srfi-197
* https://srfi.schemers.org/srfi-197/srfi-197.html

I have already opened a merge request with the changes in GitLab, and
also by this means I'm sending the patch with the changes, if some of you
want to test/review/use the SRFI implementation integrated in the Kawa
source tree.

Altough I've been a Kawa user/enthusiast for some years, nevertheless
this is my very first attempt to contribute to the source code, so I
guess peer review is required.


[-- Attachment #2: Add SRFI-197 --]
[-- Type: application/gzip, Size: 9154 bytes --]

[-- Attachment #3: Type: text/plain, Size: 63 bytes --]


Thank you in advance.

Greetings.
-- 
Alcides Flores Pineda.

Re: Add SRFI-197 Implementation for Kawa

[Per Bothner]

Mostly looks good, but one litle problem:

As a general rule, it's a good idea to separate out
formatting changes (whitespace errors and re-indentation)
from substantive changes, as separate commits. One reason is if we
need to go back and figure out what changes caused a problem.
Another is it makes review easier.

-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

Re: Add SRFI-197 Implementation for Kawa

[Alcides Flores Pineda]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

Hi Per.

Thank you very much for your response and feedback.
You are right. I do apologize for sendig such a dirty patch.

I have now removed the unwanted changes and cleaned it.

Here it is in a much better state I hope.


[-- Attachment #2: Add SRFI-197 clean patch --]
[-- Type: application/gzip, Size: 4104 bytes --]

[-- Attachment #3: Type: text/plain, Size: 444 bytes --]


Thanks again for your feedback.

Greetings.
-- 
Alcides Flores Pineda.


In, mar 06 2021, Per Bothner scripsit:

> Mostly looks good, but one litle problem:
>
> As a general rule, it's a good idea to separate out
> formatting changes (whitespace errors and re-indentation)
> from substantive changes, as separate commits. One reason is if we
> need to go back and figure out what changes caused a problem.
> Another is it makes review easier.

Re: Add SRFI-197 Implementation for Kawa

[Per Bothner]

On 3/6/21 1:50 PM, Alcides Flores Pineda wrote:
> Hi Per.
> 
> Thank you very much for your response and feedback.
> You are right. I do apologize for sendig such a dirty patch.
> 
> I have now removed the unwanted changes and cleaned it.
> 
> Here it is in a much better state I hope.

Looks good.

I can apply the diff and check it in, or you can prepare a pull-request,

It should be added to this list:
http://www.gnu.org/software/kawa/Implemented-SRFIs.html
for which the source file is doc/kawa.texi
I can handle that.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

Re: Add SRFI-197 Implementation for Kawa

[Alcides Flores Pineda]

Hello Per:

I have closed the old pull-request !30 (AKA merge-request in GitLab) and
created a new one with the clean changes (!31).

* https://gitlab.com/kashell/Kawa/-/merge_requests/31

This doesn't include the documentation file `doc/kawa.texi`.

Greetings.
-- 
Alcides Flores Pineda.


On mar 06 2021, Per Bothner wrote:

> On 3/6/21 1:50 PM, Alcides Flores Pineda wrote:
>> Hi Per.
>> Thank you very much for your response and feedback.
>> You are right. I do apologize for sendig such a dirty patch.
>> I have now removed the unwanted changes and cleaned it.
>> Here it is in a much better state I hope.
>
> Looks good.
>
> I can apply the diff and check it in, or you can prepare a pull-request,
>
> It should be added to this list:
> http://www.gnu.org/software/kawa/Implemented-SRFIs.html
> for which the source file is doc/kawa.texi
> I can handle that.

Re: Add SRFI-197 Implementation for Kawa

[Alcides Flores Pineda]

Hello Per:

I finally managed to update the documentation file and added srfi-197 to
the list of implemented SRFIs.

Here is the pull-request !32 with the added lines.

* https://gitlab.com/kashell/Kawa/-/merge_requests/32

Greetings
-- 
Alcides Flores Pineda.
Sistemas Movivendor.

On, mar 07 2021, Alcides Flores Pineda wrote:

> Hello Per:
>
> I have closed the old pull-request !30 (AKA merge-request in GitLab) and
> created a new one with the clean changes (!31).
>
> * https://gitlab.com/kashell/Kawa/-/merge_requests/31
>
> This doesn't include the documentation file `doc/kawa.texi`.
>
> Greetings.

Re: Add SRFI-197 Implementation for Kawa

[Per Bothner]

On 4/30/21 9:36 AM, Alcides Flores Pineda wrote:
> I finally managed to update the documentation file and added srfi-197 to
> the list of implemented SRFIs.
> 
> Here is the pull-request !32 with the added lines.
> 
> * https://gitlab.com/kashell/Kawa/-/merge_requests/32

Thanks. Merged.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

Add SRFI-197 Implementation for Kawa

[Alcides Flores Pineda]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

*Hello everybody:*

I hope you are all fine and in good health.

After  being searching  for something  like the  "threading-macros" that
exist  in a  couple of  Lisp dialects  out there,  I finally  managed to
add/integrate a syntax-case implementation of SRFI-197 for Kawa as it is
shown in the reference implementation.

* https://github.com/ar-nelson/srfi-197
* https://srfi.schemers.org/srfi-197/srfi-197.html

I have already opened a merge request with the changes in GitLab, and
also by this means I'm sending the patch with the changes, if some of you
want to test/review/use the SRFI implementation integrated in the Kawa
source tree.

Although I've been a Kawa user/enthusiast for some years, nevertheless
this is my very first attempt to contribute to the source code, so I
guess peer review is required.

Thank you in advance.



*Greetings.-- Alcides Flores Pineda.*

[-- Attachment #2: add-srfi-197.patch.gz --]
[-- Type: application/gzip, Size: 9154 bytes --]