public inbox for
 help / color / mirror / Atom feed
From: Alcides Flores Pineda <>
To: Per Bothner <>
Cc: Kawa Community <>
Subject: Re: Add SRFI-197 Implementation for Kawa
Date: Sat, 06 Mar 2021 15:50:55 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Per Bothner's message of "Sat, 6 Mar 2021 11:11:17 -0800")

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

Hi Per.

Thank you very much for your response and feedback.
You are right. I do apologize for sendig such a dirty patch.

I have now removed the unwanted changes and cleaned it.

Here it is in a much better state I hope.

[-- Attachment #2: Add SRFI-197 clean patch --]
[-- Type: application/gzip, Size: 4104 bytes --]

[-- Attachment #3: Type: text/plain, Size: 444 bytes --]

Thanks again for your feedback.

Alcides Flores Pineda.

In, mar 06 2021, Per Bothner scripsit:

> Mostly looks good, but one litle problem:
> As a general rule, it's a good idea to separate out
> formatting changes (whitespace errors and re-indentation)
> from substantive changes, as separate commits. One reason is if we
> need to go back and figure out what changes caused a problem.
> Another is it makes review easier.

  reply	other threads:[~2021-03-06 21:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06  9:04 Alcides Flores Pineda
2021-03-06 19:11 ` Per Bothner
2021-03-06 21:50   ` Alcides Flores Pineda [this message]
2021-03-07  2:37     ` Per Bothner
2021-03-07 22:12       ` Alcides Flores Pineda
2021-04-30 16:36         ` Alcides Flores Pineda
2021-04-30 20:23           ` Per Bothner
2021-03-06  9:15 Alcides Flores Pineda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).