From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 7A686386103A for ; Sat, 6 Mar 2021 21:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A686386103A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=movivendor.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alcides.flores@movivendor.com Received: by mail-ot1-x335.google.com with SMTP id v12so5472724ott.10 for ; Sat, 06 Mar 2021 13:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=movivendor-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TzjK1Yk2SqSHwWFWe7EgI47eFbzURn7eF8CH8sgUBEw=; b=z+lFzGk+oRx6k/QYiTZBPb+Wq7G6ft58lZNkwtHqWuiOODkeOZdkrd77TVva5JgsLT GUcs8tgK0/V0Mfm+5Bc1IIm5jSGPsMjZEPsnmSWlappPdxMMwFsHfdaF18st0v/oionj nmOvPz+LtDeL5fhhnZue+JMgkD/nT1KhkKpMgRiNHNIxL8k5CLWQgv6Av1oTytn2jX3Q 3YVmeo607cicM1HeoTYPPKr956mPVFMTRRzXg5TyxZTqb2z33itwTQ9/740j5gn70Yt0 ExIr/hlSkl6V+DdHvXxSWXqO1uS+VupDtR7zEiTWtCdcDR7LE9TFoWcI8kdMgVXb9QxX FfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TzjK1Yk2SqSHwWFWe7EgI47eFbzURn7eF8CH8sgUBEw=; b=i73F9oyxZFPSV4hacBNOsr03bvXRGOzuPGrJi1DGxor4ql8EPmal5oN4857S8Y7U4i of3lBIjAP87AL/dURnarCChRU8wa2mVH6XqTuxBX7BMByH4CEnrrz44G1gHSsV/mjquJ 8SAjj4VpYPwD47K98Cpoc/S2NvqoBXvZIGpwJBn3vk3xgAGgMHnxvIHVH6lZlEvRwGgf Z7xvsD0J3gnr1dGOTNhq8VubiKUtofrIm/F+qCwnofAo/7J4AsEe8oME06TXwvabSbwl /DCvSMI9DmwDpoU07Scz6ouDRugP8EZMI4Whd0TK6sNuTyGZHGKkQJLvd4gR2eLD41Qx A2Rw== X-Gm-Message-State: AOAM531XsWM5iiWVdM0tivg0wFyepf7Ha9DeCYHmdBbjdV1qNAD+kdBc 3t7sd9Rd31f54PdcVqJfHSDND7WNqYHx X-Google-Smtp-Source: ABdhPJxb+2CNywz3lJYECD3kokaMtet+Th/TtQcop0u8eFmwuizMoVi/YshQ9K7s5UWi9CbW6t2kpw== X-Received: by 2002:a9d:618f:: with SMTP id g15mr13176786otk.298.1615067457633; Sat, 06 Mar 2021 13:50:57 -0800 (PST) Received: from L440 ([189.217.57.149]) by smtp.googlemail.com with ESMTPSA id t145sm1456687oie.10.2021.03.06.13.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 13:50:56 -0800 (PST) Received: by L440 (Postfix, from userid 1000) id 2B9A31293D53; Sat, 6 Mar 2021 15:50:55 -0600 (CST) From: Alcides Flores Pineda To: Per Bothner Cc: Kawa Community Subject: Re: Add SRFI-197 Implementation for Kawa References: <874kho4prj.fsf@movivendor.com> Date: Sat, 06 Mar 2021 15:50:55 -0600 In-Reply-To: (Per Bothner's message of "Sat, 6 Mar 2021 11:11:17 -0800") Message-ID: <87r1ks2bpc.fsf@movivendor.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: kawa@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Kawa mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 21:51:00 -0000 --=-=-= Content-Type: text/plain Hi Per. Thank you very much for your response and feedback. You are right. I do apologize for sendig such a dirty patch. I have now removed the unwanted changes and cleaned it. Here it is in a much better state I hope. --=-=-= Content-Type: application/gzip Content-Disposition: attachment; filename=add-srfi-197-clean.patch.gz Content-Transfer-Encoding: base64 Content-Description: Add SRFI-197 clean patch H4sICJv2Q2AAA2FkZC1zcmZpLTE5Ny1jbGVhbi5wYXRjaADtWntz2liW/3v8Kc7gqYpoI/GysZ1O OiE27lBjgwvIZLpqqxghXYymhUT0SHBPbdV+mq3ar7EfZT/JnnOvBHpLxO7peYRKDFyd5+887pU4 urFcgiw/GB6ozYVvmLqyXZuw2H8+MiydbWHRVc/avbOzc0XptM61ix5ra9ButXqnp0eyLEe5j05O TmIS3r4F+fy02+jBCb2dw9u3RxC+Xi0Nk4Glrtnr2s/qF7Xp2J7qGbblKq62rjV/KCC1fNOUz8rp HLY0meaFhCdZhK6zNJrty/OEtFdNojEN1wuWXjVJpMa/vWp6qvPA8JIexZHrNI1F82qlWg/s1n5A ONKLAbId1lM73dYZUxTGFt2z3rLViSObwSogzrhAWLcbXThpNy4I55NOq9OWW1251QPom5qhMxdu TNvBN3iligVluXn7sFYNU9HsNeJzdPK77yAKyEvo6zq4j5anbmVNdRkY643J1swSsQJ7CdPJzRCI nnPfqT8zQk5RkfnKXm8I6ahIJDsCNK5FxrUvAO6ZA+9sb2XhO7zaMOftQnwTRsERhEadXgibhqEN Qjcu58QhYkwUtchyEIvLnqZrHY1piqKfX3ZbmORaTiyizIloRC9RPE4vMOdP+F/8+lf1szqfXt3N +7cf+z9NO/AamOWveboL/y72Hzu9/edLnunwH5R5XNcCA0FLR3AMsxWDpW2a9hfDegDS7sJafaQ4 2Y4HEjEAMdSVo6QJXTSBC/zkqx5zrLD4xOJm4xiWt/8eq0+0Rg6s2RcjJIsuGjaqvkPoY0lDWYBv 84/D2fv59ONw9COajh7r9peIxS5hIMh3xP2Ps9DLjaF5PuY/Z8jJmKjSaGhjxljsC0ca1rbOwjQR idQKX4rSXWisx3qayjOoqbPP3PVk0sQkU9a0Gi2q4k67xev4++9B/k4GzdbRuZe+t5QvvueKX7ra CquArhLVc724xn71mkfq2cpwwV3ZvqnDAtPRtzQiVE3zEdgn3/ismlSsns1jKgfONjjvwvcAQ0Ap i6xMdQ1sA0jpMFUH1dLBR1wd18OP1DmI5TtYed7GfdlsYvBW/oL6RFN1ZIuZrm01Qx0JWlpWBGSO q9jOw45w90FZebSLccYre/PoGA8rD/73f3i7wk6IXWTEdYSWYOtaG65LoCACK+awxSM8OKrlMb0B S4cxILS0Fe0WDXJLtR4BW5xLMC481bAwqFyUChjizSOn9whPcO2l90V1UATBAKrr2pqBdaqDbmv+ PhxB0YPkrRgXVZsGnLU61wk6U00wkBIpILyI5eNhyDxAqF3PMXjIGkimmb4eWhXSmMbaCNWREI6M y4X7LnpGpjcoK40lvgNCTP5u/AVuoCsRaN0gLRhuvODSBY1ZxEreNW0HXGaaHAMDnUEQYsYKMtTH RW0Idi/AkVvxZWWv495RQJY+9jR3xYgRQUNEueq/YrcJRXmx9qnZlm7wHvcyiDC1V3Vhf2bcRZEQ YNkeWi8solBt9mkQXpN2OEIYFottkXejOipmyGZVxwivVPJ5QdZycrSUwqRGkACEhoymCvAM1RQA YGsnK0Wy7L0O83L2fgAwHd/MPvYnAxhOcZOdjP80vB5cA9T6+HU4rTWA+uP4wwwAqSb90ewngPEN 9Ef4/sfh6FqEbfDn+8lgOoXxBLnu7m+Hg+sGDEdXtx+uqQvDOxQwGs/gdng3nJH82VioD4QOB8h7 w0XdDSZX73Gp/254O5z91KBT1c1wNiLx9JFU4FkF/9/3J7Ph1YfbPl+5/zC5H08H/OLomosajUfD 0c0ELRjcDUYzBS3CNRj8Cb/A9H3/9pYb0f+AHk648Vfj+58mwx/fz+D9+PZ6gIvvBlzU7bD/7nbA tZPrV7f94V0Drvt3/R8HnHOMkiacLDD74/sBX0Kdffx3NRuOR1wUonc1Hs0muNRAHCazHfvH4XTQ gP5kOOWg3UzGqIOwR5Yxl4SMo8FeFMWGu7CLIpLR9w/Twd6o60H/FgVOSUCUOMiD590SdErPJabj H/mR4jF5qpT2J048a5xI2A18k8l0ygaJWixtGPX6/grb8iMKdkdMev5XppISn76sWLhoquuFrmL9 uB7/IzvsM5Y+q5OXko5HLos0iA3rs2GbolFhT4C1+wCG49RBYo6DptN3SaPKoat0hQx6TqR29jxg g2brDarWVId/ZQ52b5kWbUd1qLhfSNs6tyDCZ+iv38AWHpGR0MDvKMhY4raIy7hIu4q8XwyIY0Jk gYWAj85dUgAhqhM3QVJ0e9+CVA/vjSRpji3IoE4j47btE7Ae24CiKHX+Z38TdfxCEqGL089BQjrB kOAt0LIxVY2tbBP3+oM1xnifqBs3IWPjGm4W+scvIpQRsw54JeTttMWcjFl3oN1Rt2lfTyAomQw3 c9veoLjPqkMZWEdXaYsXnxBcRHknox5zM5Y1SCklQJAkH/7vv/57j91rctJPALe7gKQ5GESMlUTI ZXIG/Xb2hZVmQPD+EmQI8QqYEBLpuCEZS5Do+P0GyO/Dohe34CBWNOi48VYKOpbQDQocN+Iys3zJ ecWzo5hPUjcbPINHLcBQ1w9TH4ldAVUYxgKSXT4m1QV5g7jMny13UtvBC5EYtTmZALaFuKh07sNN TfXwTlyvFWS+sFEBusxRq+eaWJjFpQksieLkW9SeRaRNclWE8sXeprTNe1SzcasOGx5wuZc6oVMG 1TYGVRoR8pG3H+HS8YtthjNJoWk5dHcS7nUSZrjrmwh1NNOLekR2pmKroLuA/DSWqrYRhGjBHlK7 lTCzqOJCDZKmB6Ev1vOXIMXI9F2yJNpEFbV4a8vKFcW6aryv5enMUVraWIp7SqSdiFfeCYhOlb/6 KYgfXVMnoa85g9SrnTq+7pxw0PEAjpfPezj4ugaKW3fmtpvXrHgoarzD2xaFIezzeJ/ODUi0r6wu fEjPDjtahLy8U39tz/xNW2ZYSemXOGEVno4ifYr8OOQcIw4Fgq+8kWFw08VYzFbaiqo3G7pxfXK3 efBVR38TqdbctsPvk1N9J4f/H6EBZZj2r9uJeHS+taJfoxWFdZZ+/dq9CIUHSRwYzYWUdKRkGJ+o cifo609X1Vua6GSHN7XyQ1Mgruozo4OeEoXCD388lP1gZWk4eLf8HI9XEpL+CR+yBNAe/lzlsEcp 4ukJR7L6M5PwCVDVZx/Z4Y5Wx2/2tCJM4ZKHFoX59O/+6GKHYfoJRiluf5/nGLF6it9RB7kcWefy SzM2r5/TzyeH93FTdblT/D2/we/oJP5TTfbl/H7Otp6jynGWiISY8nirVZ2H0Lp/jEOixOylbPMf mt8AWpdVLel05ag98bDIAdlrDyuPEKpQc1XynUQ97eBXDSCsCg5IaY4kiuMQrLmgtY8f0SGaxoB5 8tFmtP8nUzZWF/kFF/5eeXjh8QZFGsSH1KXkKSasvVBjQFX8IErQ5BytshAvrMLA5H/yMtwB+K0c g1dQjjtgirakkqSpjP1XlGcqmffVQ5TpoT8+WYZ3Vk2HJtUcptCMZDifl3kxmPQ7b5+e905PT9uK smwtz7Wzs7NFxshotojIDGA2AR/nbfdodJreaKRXjFNpoGG7od2eUwNCjcdAF6Ycy/0s9FrdSDUS tdzK2JLcWgNqD5avkE5FrCt8vf59gimIiu8ZJnFNb4fv5veTwc3wz3ACwVVxMcUamSMlfVyXaSyE 0uhF5DyJKw1G8JCN9NF8YUQpXUixbIwNM6nV2huarLAdt5CZM/4nDZLSK8DSpaE2DaaeQ5NaKPaG qTQjKgUrS/F1pK5ZHf4WTx8Pc9X1DY/Fxr0zVsN5b5V1Ltmys1SULtMXvS7r6PGEyeIVmZJ1JTLx ffn0iW8CXyY1+7FvwpGWwbfQYW7Cbv4n4IxNe/NR8aQoGr3bWR+MfqOVbbndqTj6HdNxY2xBZxtM eWZpj9wc1bLCyWTZtmQasFszzDQxbJ4TsvhkeOZ6EDb9srNU22fnZ4rCeuySnXWW3bywpWfDs69R 6C46NByOf3ltayum/SxbPk23WyYfC50RgrzYj+BuOL2azwbT2TQYgcbQ9E7htRgKXziG/sD2Q+Ii CL19DPhC9yKx0DtNLlzuF/h8txCEwYrTtVtJUe1WhBUTzjY/M9l3jHDw+1kEoU07UZEMozTh+Exp PnEgYAqh+YOUDV0dL+ekRjqFF0VXK06Dt9v6+fk5Y+eZ0+BF8qMz4aed324mnPIRXM0xNh6vu3AG /CXcB50YxmEnTo9qVx+/PmTC+9uo9rdR7W+j2t9Gtb+Nakc79cGj2uHNxIvgXFBPrdHo9q80KM22 eMhZi4615T/M0NFbVjd0yoMt1H5fS4xIL237ZKE6nDqcRkpxIVEtSxoy1sJnNbTHymJIq5bexGoR IgQDG3ONP46tkZBfUA6q+H2NP9UJhuRqkZvchGZuD8zrBRRkWRnFL0mKKHrzmF9Rk/nuAGtji3kx x57k8tbJHSEvSG5FP+YBsk/xYy48KbGWpgggvLeL2NyNWHoSVTKHNnSKhdIGORduowWf/O1zuy0c K5RDWvOtXPumZ2zwNElmIilqbeIbCY+aGpoeaglLogT2Zq0oSebil5GagAZFPpPiIG93j/9ylIfq hW5hxDP5XcUAnnSa73p4PpkX1Di8+qGszF/9UJooZSS/pEiilY6XKvlRLZ4g422QnAWrXGokZ801 hgbG8qAUY3rRaObiOU8+PSxvOflpmKKq1kK5uYe00Ur+ZfSVr/avrK3uPCjqgs8elVRHzLa8sCty o9wVHqVlzXA0vFGuwfHymYzmit4I9JwKkXhqDsX8EA+sM7wRC1EVeLtSKT3LWlgAVryN5eIVb0K5 Ua5ClmppKeQK2hqf9xIukV0Rd8SMXTL4IEmvQTqBDh4J4DR1EAyTIf1zSITtLM0WFGKa7djLS5Vi l0paSqI483xNaw8bS0VL87xa5jaZajYEZV2KQKQl/f1c/i0dTpRpdk6na7RSWlMZfU1eZ/LlJTav 1Tw3xa/cGR0oPppXrUNzMyptiNmUWQ2bUyaaNiep1Uqc4j8Gi59/a3zPdw7wrL5PvCIVFY8ZhSpz ThZPAjNeC+VQxW5mBFjRA0eZ/YfYJepO2BUW097aMrCz2k9xQLPOCkWWlVkR3vwciFKQWDm/sJfg FOZuNZzmmTZ+8g+L5iGW5oZUfApdKa2kghNR3Oh0u82olpxjUW5hVSXNPB5x0uQRqWL1pW8Ey5Ir eR9YCIG48yunlg9MOpoBqcELqY2bldQF6ZQ2LM4sBsKkT77tsVhf4LSxhS5m0Fl0IXr1NEdrMlvy bYgmSmBPLHacMb7Sxe9xk2LX82zCLSAKCNkCZ9CLASLGLTs7ZHCLD4jp4xypo0AgOy6Xaw7ncApw 2I3qnKbTQMpq3Km45EYwgW7mjU/MhKqx29ucWe5SZg2mo5cf6YTlyXsaqp/MZ83/DyghK/uTUQAA --=-=-= Content-Type: text/plain Thanks again for your feedback. Greetings. -- Alcides Flores Pineda. In, mar 06 2021, Per Bothner scripsit: > Mostly looks good, but one litle problem: > > As a general rule, it's a good idea to separate out > formatting changes (whitespace errors and re-indentation) > from substantive changes, as separate commits. One reason is if we > need to go back and figure out what changes caused a problem. > Another is it makes review easier. --=-=-=--