Two small patches

Two small patches

[Matthieu Vachon]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi Per,

Here attached two patches:

# Patch fix-non-java-invoke.patch
Fix a small code syntax problem when not using feature
java.lang.invoke in ApplyExp.java.

# Patch fix-ant-build.patch
Fix ant compilation of lib-scm-classes. Some classes were missing from
the list resulting in compilation errors.

Regards,
Matt

[-- Attachment #2: fix-non-java-invoke.patch --]
[-- Type: application/octet-stream, Size: 587 bytes --]

Index: gnu/expr/ApplyExp.java
===================================================================
--- gnu/expr/ApplyExp.java	(revision 7945)
+++ gnu/expr/ApplyExp.java	 (working copy)
@@ -783,7 +783,7 @@ public class ApplyExp extends Expression
     // private static final Class[] compilerMethodType =
     //     new Class[] { gnu.expr.ApplyExp.class,
     //                   gnu.expr.Compilation.class,
-    //                   gnu.expr.Target.class, };
+    //                   gnu.expr.Target.class,
     //                   gnu.mapping.Procedure.class };
     /* #endif */
 }

[-- Attachment #3: fix-ant-build.patch --]
[-- Type: application/octet-stream, Size: 1067 bytes --]

Index: build.xml
===================================================================
--- build.xml	(revision 7945)
+++ build.xml	 (working copy)
@@ -522,6 +522,8 @@
         <file name="reflection.scm"/>
         <file name="syntax.scm"/>
         <file name="lists.scm"/>
+        <file name="ExceptionClasses.scm"/>
+        <file name="exceptions.scm"/>
         <file name="thread.scm"/>
         <file name="characters.scm"/>
         <file name="keywords.scm"/>
@@ -537,6 +539,7 @@
         <file name="bytevectors.scm"/>
         <file name="arrays.scm"/>
         <file name="system.scm"/>
+        <file name="kawa/expressions.scm"/>
         <file name="kawa/hashtable.scm"/>
         <file name="kawa/regex.scm"/>
         <file name="rnrs/hashtables.scm"/>
@@ -546,6 +549,7 @@
         <file name="rnrs/sorting.scm"/>
         <file name="rnrs/programs.scm"/>
         <file name="trace.scm"/>
+        <file name="compile_misc.scm"/>
       </filelist>
       <fileset dir="${src.dir}/kawa/lib">
         <include name="windows.scm" if="${with-swing}"/>

Re: Two small patches

[Per Bothner]

Oops.  Checked in.  Thanks.

It would be nice to set up an automated build system that tests various
build configurations, but I don't have the resources for it.

On 07/06/2014 08:38 PM, Matthieu Vachon wrote:
> Hi Per,
>
> Here attached two patches:
>
> # Patch fix-non-java-invoke.patch
> Fix a small code syntax problem when not using feature
> java.lang.invoke in ApplyExp.java.
>
> # Patch fix-ant-build.patch
> Fix ant compilation of lib-scm-classes. Some classes were missing from
> the list resulting in compilation errors.

-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

Re: Two small patches

[Matthieu Vachon]

Leveraging a CI service like travis-ci.com would probably be something
great. There is potentially other possibilities out there, but it's
the one I am most familiar with.

I know it nicely integrates with github, to launch tests under various
different environments after each push to the repository. It would
probably be possible to make it work using SVN also.

I will try to find some time to make a small proof of concept.

Matt

On Mon, Jul 7, 2014 at 12:08 PM, Per Bothner <per@bothner.com> wrote:
> Oops.  Checked in.  Thanks.
>
> It would be nice to set up an automated build system that tests various
> build configurations, but I don't have the resources for it.
>
>
> On 07/06/2014 08:38 PM, Matthieu Vachon wrote:
>>
>> Hi Per,
>>
>> Here attached two patches:
>>
>> # Patch fix-non-java-invoke.patch
>> Fix a small code syntax problem when not using feature
>> java.lang.invoke in ApplyExp.java.
>>
>> # Patch fix-ant-build.patch
>> Fix ant compilation of lib-scm-classes. Some classes were missing from
>> the list resulting in compilation errors.
>
>
> --
>         --Per Bothner
> per@bothner.com   http://per.bothner.com/

Re: Two small patches

[Matthieu Vachon]

On Mon, Jul 7, 2014 at 1:27 PM, Matthieu Vachon
<matthieu.o.vachon@gmail.com> wrote:
> I know it nicely integrates with github, to launch tests under various
> different environments after each push to the repository. It would
> probably be possible to make it work using SVN also.
>

Sadly, travis-ci is only supporting GitHub projects. So until Kawa
moves to github (and git before this), if ever, it would only be a
partial solution only.

Since I maintain a fork of Kawa on github, here the results of a build
https://travis-ci.org/maoueh/kawa-fork/builds/29473732.

The ant builds all passed on all available jdks.

The make builds shows certain interesting problem.

 1. For all of them, there is a problem making the doc. I used (make &
make) in the build script command to overcome this. It worked
sometimes (https://travis-ci.org/maoueh/kawa-fork/jobs/29473736) but
not always (https://travis-ci.org/maoueh/kawa-fork/jobs/29473738).

 2. Tests failed on openjdk8
(https://travis-ci.org/maoueh/kawa-fork/jobs/29473740). In this test,
I applied my `fix-testsuite-errors3.patch` I just sent minutes ago.
However, on openjdk8, it seems the previous code (without the patch
applied) is the right one. This seems to indicate a difference
somewhere between Java 7 and Java 8.

Regards,
Matt