From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95339 invoked by alias); 17 Dec 2019 01:20:39 -0000 Mailing-List: contact kawa-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: kawa-owner@sourceware.org Received: (qmail 95331 invoked by uid 89); 17 Dec 2019 01:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: aibo.runbox.com Received: from aibo.runbox.com (HELO aibo.runbox.com) (91.220.196.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 01:20:37 +0000 Received: from [10.9.9.203] (helo=mailfront21.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1ih1XM-0003Ek-VO; Tue, 17 Dec 2019 02:20:33 +0100 Received: by mailfront21.runbox with esmtpsa [Authenticated alias (524175)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1ih1X9-0002rX-4M; Tue, 17 Dec 2019 02:20:19 +0100 Subject: Re: building for jdk / openfx 13 (patch) To: Michael Zucchi , kawa@sourceware.org References: <55c6385c-84ae-439d-0336-abc41085ac82@gmail.com> From: Per Bothner Message-ID: Date: Tue, 17 Dec 2019 01:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <55c6385c-84ae-439d-0336-abc41085ac82@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00013.txt.bz2 On 12/16/19 3:43 PM, Michael Zucchi wrote: > Apologies if this should go to the bug tracker, I didn't see any specific details for patch submission. email is fine. > I wanted to have a look at kawa including the javafx parts but I didn't want to install the oracle jdk as i've moved everything i do to openjdk.  So I've created a small patch that allows compilation with openjdk13 and openjfx13 (although it should work with 11+). It is enabled by adding --with-javafx-sdk=path to configure: We already have a --with-javafx, with optional argument: --with-javafx=ARG. The ARG is used to set WITH_JAVAFX_ARG, which was intended to be used to specify the path the JavaFX, but doesn't seem to be used. So probably we should use WITH_JAVAFX_ARG instead of WITH_JAVAFX_SDK_ARG. The configure script might need to check that the ARG specified for --with-javafx is for java 9 or later - i.e. modularized. -- --Per Bothner per@bothner.com http://per.bothner.com/