From: Per Bothner <per@bothner.com>
To: Sudarshan S Chawathe <chaw@eip10.org>, kawa@sourceware.org
Subject: Re: Threads and the getResult method
Date: Sun, 19 Mar 2017 06:20:00 -0000 [thread overview]
Message-ID: <b3d02d55-c2e7-a3e4-539e-408155448562@bothner.com> (raw)
In-Reply-To: <1443.1489881697@vereq.eip10.org>
On 03/18/2017 05:01 PM, Sudarshan S Chawathe wrote:
> I was trying to use threads as outlined in Section 8.6 ("Threads") of
> the manual and was unable to call the getResult method as suggested
> there until I added a 'public' modifier to that method's definition in
> gnu/mapping/RunnableClosure.java.
Oops. There seems to have been a lack of testing ...
> I submitted a GitLab pull request, even though this change is trivial,
> mainly to exercise that functionality. It may be preferable to ignore
> it and just make the change directly (assuming it is valid).
Generally, I'm as comfortable (or more so) with patches, since I'm more
familiar with that workflow, especially when I'm the one submitting changes :-)
In this case, since you create a pull request, I'm happy to do it that way
- though a ChangeLog entry would be appreciated.
(I failed to set up Notification properly from GitLab, so I haven't been
getting timely notification of issue and pull question. Sorry about that.
Hope it's working now. It's a learning experience ...)
--
--Per Bothner
per@bothner.com http://per.bothner.com/
next prev parent reply other threads:[~2017-03-19 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 0:01 Sudarshan S Chawathe
2017-03-19 6:20 ` Per Bothner [this message]
2017-03-19 14:25 ` Sudarshan S Chawathe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d02d55-c2e7-a3e4-539e-408155448562@bothner.com \
--to=per@bothner.com \
--cc=chaw@eip10.org \
--cc=kawa@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).