public inbox for kawa@sourceware.org
 help / color / mirror / Atom feed
From: Per Bothner <per@bothner.com>
To: Sudarshan S Chawathe <chaw@eip10.org>, kawa <kawa@sourceware.org>
Subject: Re: Exception on pprint-logical-block without 'out:' (patch incl.)
Date: Wed, 14 Jun 2017 00:56:00 -0000	[thread overview]
Message-ID: <c126fc79-a87c-6268-5f55-e2ec7e3dbd6e@bothner.com> (raw)
In-Reply-To: <11182.1497220626@vereq.eip10.org>

On 06/11/2017 03:37 PM, Sudarshan S Chawathe wrote:
> 
> Evaluating a pprint-logical-block form without the optional 'out'
> keyword argument throws an exception.  (See details below.)  It works
> fine when that is provided.
> 
> Based on a quick look at kawa/lib/kawa/pprint.scm, I suspect the
> problem is just a missing (define out-expr #!null) in the
> define-syntax-case.  The attached trivial patch seems to do the trick,
> but I have not tested carefully.  (I can also submit using gitlab if
> you prefer.)

I checked this in. Thanks!
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/

      reply	other threads:[~2017-06-14  0:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-11 22:37 Sudarshan S Chawathe
2017-06-14  0:56 ` Per Bothner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c126fc79-a87c-6268-5f55-e2ec7e3dbd6e@bothner.com \
    --to=per@bothner.com \
    --cc=chaw@eip10.org \
    --cc=kawa@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).