From: Per Bothner <per@bothner.com>
To: "Timo Myyrä" <timo.myyra@wickedbsd.net>, kawa@sourceware.org
Subject: Re: [PATCH 2/2] strip-trailing-cr is not needed in testsuite
Date: Mon, 08 May 2017 19:59:00 -0000 [thread overview]
Message-ID: <e3dd6f62-84de-27f0-1470-71cc344e04fe@bothner.com> (raw)
In-Reply-To: <87zienjo45.fsf@phobos.TeleWell.gateway>
I checked in the fix below. Thanks!
On 05/07/2017 09:12 PM, Timo Myyrä wrote:
>
> tests don't seem to require strip-trailing-cr flag and OpenBSD's diff doesn't have
> that option so remove it.
>
> diff --git a/testsuite/Makefile.am b/testsuite/Makefile.am
> index 071766c5d..199e2f151 100644
> --- a/testsuite/Makefile.am
> +++ b/testsuite/Makefile.am
> @@ -8,7 +8,7 @@ KAWA = ../bin/kawa.sh
> CPJAVA = CLASSPATH="..$(CLASSPATH_SEPARATOR)@conf_classpath@.$(CLASSPATH_SEPARATOR)$$CLASSPATH" $(JAVA)
> CPKAWA = CLASSPATH="@conf_classpath@.$(CLASSPATH_SEPARATOR)$$CLASSPATH" $(KAWA)
> KAWATEST = CLASSPATH=".$(CLASSPATH_SEPARATOR)$$CLASSPATH" $(KAWA) $(OPTIONS) -e '(load "testing.zip")'
> -DIFF = diff --strip-trailing-cr
> +DIFF = diff
>
> if ENABLE_SERVLET
> if ENABLE_XQUERY
>
--
--Per Bothner
per@bothner.com http://per.bothner.com/
prev parent reply other threads:[~2017-05-08 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 16:43 Timo Myyrä
2017-05-08 19:59 ` Per Bothner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3dd6f62-84de-27f0-1470-71cc344e04fe@bothner.com \
--to=per@bothner.com \
--cc=kawa@sourceware.org \
--cc=timo.myyra@wickedbsd.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).