From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55621 invoked by alias); 8 May 2017 18:39:02 -0000 Mailing-List: contact kawa-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: kawa-owner@sourceware.org Received: (qmail 55593 invoked by uid 89); 8 May 2017 18:39:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Per, comfortable, HContent-Transfer-Encoding:8bit, becomes X-HELO: aibo.runbox.com Received: from aibo.runbox.com (HELO aibo.runbox.com) (91.220.196.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 May 2017 18:39:00 +0000 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1d7nYh-0005iz-OK; Mon, 08 May 2017 20:38:59 +0200 Received: from 70-36-239-209.dsl.dynamic.fusionbroadband.com ([70.36.239.209] helo=localhost.localdomain) by mailfront11.runbox.com with esmtpsa (uid:757155 ) (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) id 1d7nYh-0003kQ-4j; Mon, 08 May 2017 20:38:59 +0200 Subject: Re: [PATCH 1/2] Tweak xquery tests so that they pass on OpenBSD To: =?UTF-8?Q?Timo_Myyr=c3=a4?= , kawa@sourceware.org References: <8737cfl2qj.fsf@phobos.TeleWell.gateway> From: Per Bothner Message-ID: Date: Mon, 08 May 2017 18:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <8737cfl2qj.fsf@phobos.TeleWell.gateway> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-q2/txt/msg00053.txt.bz2 On 05/07/2017 09:11 PM, Timo Myyrä wrote: > > OpenBSD's diff doesn't have -B flag so work around it by formatting the > expected test outputs to not have newline in the end. I'm not comfortable changing checked-in text files so they don't end in a newline, like text files should. Ideally the output should always (or at least by default) end in a newline. Perhaps close should automatically call freshLine. However, you have to be careful with binary files - and it becomes non-obvious with hybrid text/binary files, which Kawa supports. So not sure what to do. It needs some thought. As a work-round until then, I suggest we add a newline to the end of the output. For example: echo >>tmp-format-users.html Or perhaps we can have sed add the newline. -- --Per Bothner per@bothner.com http://per.bothner.com/