public inbox for
 help / color / mirror / Atom feed
From: Per Bothner <>
To: Alcides Flores Pineda <>,
	Kawa Community <>
Subject: Re: Add SRFI-197 Implementation for Kawa
Date: Sat, 6 Mar 2021 11:11:17 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Mostly looks good, but one litle problem:

As a general rule, it's a good idea to separate out
formatting changes (whitespace errors and re-indentation)
from substantive changes, as separate commits. One reason is if we
need to go back and figure out what changes caused a problem.
Another is it makes review easier.

	--Per Bothner

  reply	other threads:[~2021-03-06 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06  9:04 Alcides Flores Pineda
2021-03-06 19:11 ` Per Bothner [this message]
2021-03-06 21:50   ` Alcides Flores Pineda
2021-03-07  2:37     ` Per Bothner
2021-03-07 22:12       ` Alcides Flores Pineda
2021-04-30 16:36         ` Alcides Flores Pineda
2021-04-30 20:23           ` Per Bothner
2021-03-06  9:15 Alcides Flores Pineda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).