From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 339D13858422 for ; Thu, 18 Nov 2021 23:09:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 339D13858422 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AIMQx9R019268; Thu, 18 Nov 2021 23:09:43 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3cd2w92j2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Nov 2021 23:09:42 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1AIN0NUG063588; Thu, 18 Nov 2021 23:09:41 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) by userp3030.oracle.com with ESMTP id 3ca2g1agnk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Nov 2021 23:09:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJN8sYdUersWzYGy3txXkNB9XeJwz/mrM5C8C37o/gOD/7wGuaK2c8hp+CoDuJ36q2YKl/esJtwiA2RoqcMl5WmvGpKHHn00VQL3I1Si8Ma3E2rIF4y64cPQnXBjCv3/fW0uS5hgI6HzaF/Vp9dYeLd4/73+3XfgKkx2ErCFcSUon3rJB6UIF6Wd82jY2EYt7nawIy4L6w1tJZ4K302E4qwGOPlKeGHr6Bcu1JGI2BxINpU5tl23XScdp2qH0lNWzkJpbP+s09QhDDxTD5lA5886OM9O550Lq4yf1whP4A1UgCbZqZp2yTuaPvDzJGXyaTR28Z9dT8pZJRE5uWuFew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t83cBqqYQ6VV5CRSyxDIQc/eI71cRLYjOkFTL6tDCFg=; b=d5UvJjBY/4eBsDOzp/OijL5rnLjXDOZryxIlIjk+vLqel+AZsbIWe/NywjjCfi0vi9wOFCDpwX3eZvFj3Z4cTGcuwTX8eHsy0pAWTMUUKUmAiDVdobL5Bpy0c5K9FfX60J3NTmqf3PcKkoTNyhoJD7ExKxbORsBk2vaD5/h2Omtwg37OiE3ALnFBshdLkIGuSJF2tur53YzxMc8/IoR8j4w5pd+JXZHZiroX+VDksfeewl2Z5QZXFXthTNO2U7XbzfM2l6N4+gUEo3xkMscAcj/FJc+n8cX4WKPsLw8fjFUG9N+WYo+HeWVyVkXmXYzPjfYqxTsQotctuCr4NAFHDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BL0PR10MB2852.namprd10.prod.outlook.com (2603:10b6:208:76::22) by BLAPR10MB5043.namprd10.prod.outlook.com (2603:10b6:208:332::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Thu, 18 Nov 2021 23:09:38 +0000 Received: from BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765]) by BL0PR10MB2852.namprd10.prod.outlook.com ([fe80::7126:e98e:9cff:8765%7]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 23:09:38 +0000 From: Guillermo Martinez To: "Guillermo E. Martinez via Libabigail" , Dodji Seketeli Subject: Re: [PATCH 1/3] ctf-reader: Use argument by reference reading the context Thread-Topic: [PATCH 1/3] ctf-reader: Use argument by reference reading the context Thread-Index: AQHX3Cf+kfvy/1osMECTxrnoDyMoTawJiqKRgABfxIA= Date: Thu, 18 Nov 2021 23:09:38 +0000 Message-ID: <10713298.58LSW8MH2a@sali> References: <20211118025606.554809-1-guillermo.e.martinez@oracle.com> <20211118025606.554809-2-guillermo.e.martinez@oracle.com> <87v90p4bou.fsf@seketeli.org> In-Reply-To: <87v90p4bou.fsf@seketeli.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 444328d2-73c8-4d4d-6aa8-08d9aae87ec9 x-ms-traffictypediagnostic: BLAPR10MB5043: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jaLMHwdsGDOCxVWXO6CT0Kasl9/M9OydrE5nTaLLUYNJkOjoQlIoV4Tpx9dr1MKrNDksKoXrfW1XwEE8f/AEGiFCXhuWVeVk1jSGu11Oiz3z1+xhma6WO2eRj5nPLRF35CXy61p38zdIy7MG/ejLS6R7Zab3lllTWhpM7UieLMnzAPYKN0R77cV6jgTwJL/IUqQpeAQ10sBbyCVUE7pcHzJ9u2Ppg85I9IRJiKA8SwJvkbO3EbueSkHgg+mWCidZOWTZjMpOfVzNrm95jhm7MsEH+ETPcq+jDYQNFZPOuCnB2IP8QvGqrcedm+pNhWiscfUBcTz97oVx8HOo+yIZXxL0uHBOzFhyS0sLqjXfistakgqRzxeG78sTrtayM8JLCOfzGPoZLTUX7CrB35sYWPyQKq9spQwaU/fR1tsczNVJ4et9QLJpAo/wKV9mq3hxL5IjPhsKl4GBIFdB3p+I7tUthmSofYgGaGnMVnI8CxgGX5Up6NFiyYArc0Cb7XGIMojNysN6aevmUuisfz71pgzGsLDiit5NoLGac9z4Ad1mNQdHYG+ILRXq2KYkv44TNOvqdD641u9qPLbz03TG89sfgixsgtoO/bnZlfs7+OsxeECrwp16GFwyDcFsla5Ipan+NbD+jLfXB0TmaWu5SHeFULnzSNiYOoGDREjP/v1dfXiubfv6X1hjWkEDydil4pOdD07t0eMkt26ZYmf6tvsdOcX3tGxlFYi0mjjptqlUljr/vKGYGz/aeJlPe4duPZYGtXju8JhFny1kDFETy/rR6kTsjvR+7OLNcB8pNAUdPn260V4B2Yg8UX/Vvw1pS5mVclgHsM6kTc/zfz1IIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR10MB2852.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(366004)(966005)(86362001)(26005)(186003)(8936002)(5660300002)(508600001)(6512007)(9686003)(38070700005)(53546011)(2906002)(6506007)(6486002)(8676002)(316002)(64756008)(66476007)(66556008)(66446008)(76116006)(83380400001)(91956017)(71200400001)(110136005)(33716001)(38100700002)(66946007)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DfAekp702tNN7bGQ7ECxVZqOLu2Wc4ZUgd9RMPjzFO+CDCqd9jIh8u43eP?= =?iso-8859-1?Q?orAW/KwWU8d9VE56lxOctHj9kQ0CkJNjyP8X/clY6eP2hnqX8xLT0Ml1zI?= =?iso-8859-1?Q?xy3oGF52rez/B4a263NwuafLOvRb/Z2xQ2bHNe6HltmA0xXu3snDUtfaVI?= =?iso-8859-1?Q?UcboSH7AR2jn6cnvPuxPs589FSORzEyBViZng4humr4vUn67ZmDYpBvtDT?= =?iso-8859-1?Q?dUo+6LzWGJJVcMzR4Gm4e/QiSIUadyVULcCQRWXSdLwDCQAsiB++Eu44O9?= =?iso-8859-1?Q?Y+UZHsjWmXnZp1Vu0EkmvEm3mqbL96Q460eSb7cGc/X5wJKM02D7dKsTo8?= =?iso-8859-1?Q?2KiN/+g2TSw1nbBH6URN9N68UaMo6oDvklKk7nzI+aeCkAMevz/t00Xr6U?= =?iso-8859-1?Q?4fMv0BfH4UgEs52S0yqM8tGcaY9HgwWtuDTbuLF0I81xs5Z6pXtx7m8haU?= =?iso-8859-1?Q?csKZciTV6dwZVxsPCBTGvOFrFqEtluMxyAmXKmxoDgU+WbQOBcR7hWpCpH?= =?iso-8859-1?Q?oGTtfGkiu0VtVSP5KeklNMXSTQfgs6+fv4OrwYmo7avoE50a672eWs78og?= =?iso-8859-1?Q?HPrthbVjOyVwv8CjIZYN4KEAjCvG9xNkBgSmKYDQhPz3U7SM5CNuP1wXay?= =?iso-8859-1?Q?OdPv4Wcu2j3cw6MEE/7t2SInc5CIXEm3sfow1RmfTdN+aNSf4Rq3K4HrCw?= =?iso-8859-1?Q?2Xb6AyFOkTM1yUPakL5gwYv0m1z42dj24wXENJSILHxC9SqSZ5BkqppMbk?= =?iso-8859-1?Q?LD9XT2WmSNaVDBIrbmlGzKfowOX2pu+Xc/mFq/YFGrNiFzqrrivpRs7vHR?= =?iso-8859-1?Q?TJ2wiMRPNCrkIuAQNCGnUUogrxazsZbXWIWybpFo0aPzzFzyo4FAyfapfR?= =?iso-8859-1?Q?MDZ+fywd3EQZx+rUH4g9tQG0TrG+L/ANQBXww63Z3aq0ajgMto7MoeLlid?= =?iso-8859-1?Q?gH7G8FBzJVKk0Muf8VyUbt5cVkEHW7YrgkFU7F/RkdkUHO2/Cjbsw76WRi?= =?iso-8859-1?Q?8L9r8C+v1B2ny5iUw1fU07s0jd9gMVUCBd27EcbZDjmKjXVPk+MfmIK0DJ?= =?iso-8859-1?Q?1H1G6iEEfoYlIkdUUGqORnwkJQjf+mUAxfkBYvGkJ0rWbeMJSxNmHipF3Y?= =?iso-8859-1?Q?4K8H3ppg9TXiSIXUApVykNv+Zgpb0vVqF430xQP9lkVyHGQRjG2wBl54Gw?= =?iso-8859-1?Q?6Vckn6tzUBh7Ol1ygwmJAMlmg2EzA3y8FYi6BdhiSoBVi9VqZaarOHibvk?= =?iso-8859-1?Q?1IB7wbzBydc/QuGwXZTme+UEkHu+Mya4ws7VRnF0j83VJoCrA/tjBwr4yB?= =?iso-8859-1?Q?NnCKW+0X7gVEFzpMLXHaO96AyiHNnsnkICvG2t37jVpY7htd4+NdLOvKDG?= =?iso-8859-1?Q?+OzRqAeuiaFHZ47nJjGkU5XefFtH+YfPpc2VWbUTJBQ2vC5KmMvEmpuo2N?= =?iso-8859-1?Q?f5cFD/0XhXtYpAlbmWuo3oiLegKCknY1Xjx7aOMhn/Zs7xaYWl+NmWONZO?= =?iso-8859-1?Q?JwyQYxn4HW3sEr+0POqFtF+R5FDQb7qqfBfSMADQTMkVZBuhDJlmhFQZ2l?= =?iso-8859-1?Q?wBnxuqDkqe5APFV+lvLCmbMfmcthuo2jbECP27pA+ZMK2TpVdsbnr077AU?= =?iso-8859-1?Q?Cpetn2kiv08cuA2sKJe+XDp/ef2I0ly+Axgi05XkOFYW5rNh2Q+jZyiykH?= =?iso-8859-1?Q?zBxlNWq4DkMVCOj4Si8+OmhRrV8YwcrHTl/LIVfswN/B4Izh2UqRwi0TLS?= =?iso-8859-1?Q?v0ETHYBBEi2FGVd/K+fFt0D70=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <6E760A73736A7A458EF08DC2A0A7A6D4@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB2852.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 444328d2-73c8-4d4d-6aa8-08d9aae87ec9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2021 23:09:38.4250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 305W5eGaitzXm5W+7s/p726WCIW7d+7kxChCbtxMmrEy2uvDNqYVEmv27S1e/eu5qjYNUTnJkRZkSq+k728xyMJ2GDUNCFoJuOu8Bzu9rfg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5043 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10172 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111180118 X-Proofpoint-GUID: UPYVbGhw1eTzrBOWvzdgqEGWYHwfyNeA X-Proofpoint-ORIG-GUID: UPYVbGhw1eTzrBOWvzdgqEGWYHwfyNeA X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 23:09:49 -0000 On Thursday, November 18, 2021 11:26:41 AM CST Dodji Seketeli wrote:=0A= > Hello Guillermo,=0A= Hello Dodji=0A= > Thanks for your patch!=0A= > =0A= > I just have some small nits to pick.=0A= > =0A= > Please find my comments below:=0A= Thanks!=0A= =0A= > "Guillermo E. Martinez via Libabigail" a=0A= > =E9crit:=0A= > =0A= > > * src/abg-ctf-reader.cc (read_context): Use const argument=0A= > > pass by reference.=0A= > > (create_read_context): Likewise.=0A= > =0A= > Here each line should be prefixed by a "tab", as explained in the=0A= > COMMIT-LOG-GUIDELINES file in the source tree at=0A= > https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob_plain;f=3DCOMMIT-= LOG-GUIDELINES;hb=3DHEAD.=0A= > =0A= > Also, there are some changes in the the file include/abg-ctf-reader.h.=0A= > I added them to this ChangeLog part of the commit log.=0A= Thanks!=0A= =0A= > You'll find my updated version of your patch below. Would you please=0A= > sign it off by adding a line starting by "Signed-off-by:" with your name= =0A= > and email, as explained in the file CONTRIBUTING at=0A= > https://sourceware.org/git/?p=3Dlibabigail.git;a=3Dblob_plain;f=3DCONTRIB= UTING;hb=3DHEAD=0A= > ? I need that sign-off before committing the patch.=0A= Ok, I will do.=0A= =0A= > Thanks a lot!=0A= Thanks to you for the comments! =0A= > From ee0308d607b36fc4c5e3e4d815deb7ecf8884ad6 Mon Sep 17 00:00:00 2001=0A= > From: "Guillermo E. Martinez via Libabigail" = =0A= > Date: Wed, 17 Nov 2021 20:56:04 -0600=0A= > Subject: [PATCH] ctf-reader: Use argument by reference reading the contex= t=0A= > =0A= > * include/abg-ctf-reader.h (create_read_context): Pass the string=0A= > by reference.=0A= > * src/abg-ctf-reader.cc (ctf_reader::read_context): Likewise.=0A= > (create_read_context): Likewise.=0A= > =0A= > Signed-off-by: Dodji Seketeli =0A= > ---=0A= > include/abg-ctf-reader.h | 8 ++++----=0A= > src/abg-ctf-reader.cc | 5 +++--=0A= > 2 files changed, 7 insertions(+), 6 deletions(-)=0A= > =0A= > diff --git a/include/abg-ctf-reader.h b/include/abg-ctf-reader.h=0A= > index c0d8bb2b..56b2bf91 100644=0A= > --- a/include/abg-ctf-reader.h=0A= > +++ b/include/abg-ctf-reader.h=0A= > @@ -25,10 +25,10 @@ namespace ctf_reader=0A= > {=0A= > =0A= > class read_context;=0A= > -read_context *create_read_context (std::string elf_path,=0A= > - ir::environment *env);=0A= > -corpus_sptr read_corpus (read_context *ctxt,=0A= > - elf_reader::status& status);=0A= > +read_context *create_read_context(const std::string& elf_path,=0A= > + ir::environment *env);=0A= > +corpus_sptr read_corpus(read_context *ctxt,=0A= > + elf_reader::status& status);=0A= > =0A= > } // end namespace ctf_reader=0A= > } // end namespace abigail=0A= > diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc=0A= > index 0370c8aa..2c2c204d 100644=0A= > --- a/src/abg-ctf-reader.cc=0A= > +++ b/src/abg-ctf-reader.cc=0A= > @@ -102,7 +102,7 @@ public:=0A= > /// Constructor.=0A= > ///=0A= > /// @param elf_path the path to the ELF file.=0A= > - read_context(string elf_path, ir::environment *env)=0A= > + read_context(const string& elf_path, ir::environment *env)=0A= > {=0A= > types_map.clear();=0A= > filename =3D elf_path;=0A= > @@ -1060,7 +1060,8 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp= )=0A= > /// @param env a libabigail IR environment.=0A= > =0A= > read_context *=0A= > -create_read_context(std::string elf_path, ir::environment *env)=0A= > +create_read_context(const std::string& elf_path,=0A= > + ir::environment *env)=0A= > {=0A= > return new read_context(elf_path, env);=0A= > }=0A= Cheers,=0A= Guillermo=0A= =0A=