From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33721 invoked by alias); 12 Apr 2017 16:58:37 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 33325 invoked by uid 89); 12 Apr 2017 16:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=nets, H*M:8fce X-Spam-Status: No, score=-26.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-wm0-f41.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version; bh=2iI3brlBMDMilOwWXlOXW8JCgU6QcqaLTK5Oqa4FTuU=; b=IQQjO+diAeSH2hG3QiRRsw+gKmD8iZtR9IHDxEXYtROKdQKmveRgbPdirBgN80xXeE ib2JAPlAuCFX0v/f7Urf6Awz8PVvnZPXyUaUvsC+V23qp7qx3nSCg0enOIKOc85HDIqe S1DpmVRxDV2tVF4RaU7aIzWakh8SkVb6Yt2mYZXULJ2paMZCymuMriXrfwEir7pwLZkH eoYhAHRPJQ7Nwn3kEiQsMyDQroCqCMaIZ5qTybpPYHJQC0auqnd2TthqZsr+RkVGZnL8 45AbeZ/tYWjeG//FZBNRn7k1O2lq5gRDhG10VZ5IGuFC3yNJo3RPkVNhaEqXO1+JqdjZ jXiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version; bh=2iI3brlBMDMilOwWXlOXW8JCgU6QcqaLTK5Oqa4FTuU=; b=OI4S5NU5nO1A0giFaSd3sp8cNYN28JBvckcLKPnSQPjsr3Hsyli2p1z+FB64E0ay2i eGwbBIyRNsy2iBmWE/QBqS8k3v6q3l43iU8oZ6wO3HLCnsYpXKvlF5ss5m2ycmHEHxSL SEEOXc3FYXL+eG2EyrgDW0AoLI3exEU0zyEs24akjLtx6CL8yD+BkefKHPmdWp6Y1+Fa xKgZHtHp3ugPMk14HY3jQNaIFvpGEST4RbiEusJB7at/Q86YSBQ64rXJ3ZSD2v6LB+AX pu1LyZSzpkpTaCurlj6zYz4mJSOV5fVWIym5CtXMAGt5sP1FVooY0sBOXo0uu24qHW8f 8NgA== X-Gm-Message-State: AN3rC/7S/VXRV2W1kDuSmCjeJs8Ubti+50WvZ4HJI2XYwKBBvvE14qMq DFdI5JQxX1/LulXtANc= X-Received: by 10.28.60.65 with SMTP id j62mr20516717wma.73.1492016314003; Wed, 12 Apr 2017 09:58:34 -0700 (PDT) To: libabigail@sourceware.org From: Ondrej Oprala Subject: [PATCH] Clean-up scripts Message-ID: <1785d2f2-8fce-f2d2-1453-16c7257e79bf@gmail.com> Date: Sun, 01 Jan 2017 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6C6AD519ACAC0C7668067B06" X-SW-Source: 2017-q2/txt/msg00005.txt.bz2 This is a multi-part message in MIME format. --------------6C6AD519ACAC0C7668067B06 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 113 Hi, attached are a few robustness safety nets that have appeared in shellcheck's warnings. Cheers, Ondrej --------------6C6AD519ACAC0C7668067B06 Content-Type: text/x-patch; name="0001-Clean-up-scripts.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Clean-up-scripts.patch" Content-length: 2431 >From 077df47f791837a114f49178f37f0453683b92b5 Mon Sep 17 00:00:00 2001 From: Ondrej Oprala Date: Tue, 11 Apr 2017 16:57:07 +0200 Subject: [PATCH 1/3] Clean up scripts/* * scripts/dot_to_png.sh: Clean up the script according to shellcheck warnings and remarks. * scripts/dot_to_svg.sh: Likewise. * scripts/svg_to_plain_svg.sh: Likewise. * scripts/svg_to_png_and_pdf.sh: Likewise. Signed-off-by: Ondrej Oprala --- scripts/dot_to_png.sh | 10 +++++----- scripts/dot_to_svg.sh | 10 +++++----- scripts/svg_to_plain_svg.sh | 6 +++--- scripts/svg_to_png_and_pdf.sh | 6 +++--- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/scripts/dot_to_png.sh b/scripts/dot_to_png.sh index 24a7dc7..0929bdd 100755 --- a/scripts/dot_to_png.sh +++ b/scripts/dot_to_png.sh @@ -1,9 +1,9 @@ -#!/bin/bash +#!/bin/bash for i in *.gv do - echo $i - outputpng=`echo $i | sed -e 's/gv/png/'`; - echo $outputpng - dot -v -Tpng:cairo -o $outputpng $i; + echo "$i" + outputpng=${i//gv/png} + echo "$outputpng" + dot -v -Tpng:cairo -o "$outputpng" "$i" done diff --git a/scripts/dot_to_svg.sh b/scripts/dot_to_svg.sh index 6b211f7..72d298e 100755 --- a/scripts/dot_to_svg.sh +++ b/scripts/dot_to_svg.sh @@ -1,9 +1,9 @@ -#!/bin/bash +#!/bin/bash for i in *.gv do - echo $i - outputsvg=`echo $i | sed -e 's/gv/svg/'`; - echo $outputsvg - dot -v -Tsvg:cairo -o $outputsvg $i; + echo "$i" + outputsvg=${i//gv/svg} + echo "$outputsvg" + dot -v -Tsvg:cairo -o "$outputsvg" "$i" done diff --git a/scripts/svg_to_plain_svg.sh b/scripts/svg_to_plain_svg.sh index 7d877f9..5ebb7a4 100755 --- a/scripts/svg_to_plain_svg.sh +++ b/scripts/svg_to_plain_svg.sh @@ -1,5 +1,5 @@ -#!/bin/bash +#!/bin/bash -for i in *.svg; - do inkscape $i --export-plain-svg=`echo $i | sed -e 's/svg$/plain.svg/'`; +for i in *.svg; + do inkscape "$i" --export-plain-svg="${i//svg/plain.svg}" done diff --git a/scripts/svg_to_png_and_pdf.sh b/scripts/svg_to_png_and_pdf.sh index 451747a..b55515b 100755 --- a/scripts/svg_to_png_and_pdf.sh +++ b/scripts/svg_to_png_and_pdf.sh @@ -1,5 +1,5 @@ -#!/bin/bash +#!/bin/bash -for i in *.svg; - do inkscape $i --export-png=`echo $i | sed -e 's/svg$/png/'` --export-pdf=`echo $i | sed -e 's/svg$/pdf/'`; +for i in *.svg; + do inkscape "$i" --export-png="${i//svg/png}" --export-pdf="${i//svg/pdf}" done -- 2.7.4 --------------6C6AD519ACAC0C7668067B06--