public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Guillermo Martinez <guillermo.e.martinez@oracle.com>
To: Guillermo Martinez via Libabigail <libabigail@sourceware.org>,
	Jose Marchesi <jose.marchesi@oracle.com>
Subject: Re: Regression tests for ctf reader: Avoid duplicating files
Date: Tue, 9 Nov 2021 02:52:50 +0000	[thread overview]
Message-ID: <1990370.rjD3G2zAS3@sali> (raw)
In-Reply-To: <87y264mik2.fsf@oracle.com>

On Thursday, November 4, 2021 2:27:57 AM CST Jose E. Marchesi wrote:

Hello libabigail team,
> 
> > I'm working in the implementation of regression tests for ctf reader
> > (tests/test-read-ctf.cc), it's very similar to test-read-dwarf.cc, so
> > they have some C and header source files that are common among
> > them, e.g:
> >
> >       tests/data/test-read-ctf/PR27700/include-dir/priv.h
> >       tests/data/test-read-ctf/PR27700/include-dir/pub.h
> >       tests/data/test-read-ctf/PR27700/pub-incdir/inc.h
> >       tests/data/test-read-ctf/PR27700/test-PR27700.c
> >       tests/data/test-read-ctf/test-PR26568-1.c
> >       tests/data/test-read-ctf/test-PR26568-2.c
> >
> > So, we're planning move those common source file to:
> >
> > tests/data/test-read-common/
> >
> > But we still need *two different* binary files with the debugging
> > information: DWARF (-gdwarf) and CTF (-gctf), that they would 
> > need to be recompiled. The current implementation to test ctf reader
> > use binary files previously compiled, so there is one file for 
> > each binary format:
> >    
> >      tests/data/test-read-*ctf*/test-PR26568-1.o
> >      ...
> >      tests/data/test-read-*dwarf*/test-PR26568-1.o
> >
> > So, Are you agree with this approach?
> >
> > We are looking for the way to avoid duplicating files :-)
> >
> > Thanks in advanced for your comments!
> 
> An alternative to have two copies of compiled objects is to have just
> one copy (in test-read-common) compiled with both -gdwarf -gctf.

Thanks Jose for your advice! .. any other alternative? .. I would like to start
working on this :-)

Kind Regards,
Guillermo

  reply	other threads:[~2021-11-09  2:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 22:41 Guillermo Martinez
2021-11-04  8:27 ` Jose E. Marchesi
2021-11-09  2:52   ` Guillermo Martinez [this message]
2021-11-09 14:47     ` Dodji Seketeli
2021-11-10 12:06       ` Jose E. Marchesi
2021-11-11 15:16       ` Guillermo Martinez
2021-11-15 13:49 ` [PATCH] Add regression tests for ctf reading Guillermo E. Martinez
2021-11-17  8:33   ` Dodji Seketeli
2021-11-18  4:02     ` Guillermo Martinez
2021-11-18  4:16     ` Guillermo E. Martinez
2021-11-18 13:52       ` Jose E. Marchesi
2021-11-18 15:14         ` Guillermo Martinez
2021-11-22 21:33       ` [PATCH v2] " Guillermo E. Martinez
2021-11-23 15:48         ` Jose E. Marchesi
2021-11-23 18:54           ` Guillermo Martinez
2021-11-25 10:40             ` Dodji Seketeli
2021-11-25 21:03               ` Guillermo Martinez
2021-11-26 10:02                 ` Dodji Seketeli
2021-11-24 16:36         ` Dodji Seketeli
2021-11-24 18:52           ` Guillermo Martinez
2021-11-26 11:23             ` Dodji Seketeli
2021-11-26 13:01               ` Jose E. Marchesi
2021-11-26 13:37               ` Guillermo Martinez
2021-11-24 19:09           ` Ben Woodard
2021-11-25  0:13             ` Ben Woodard
2021-11-25  6:50             ` Jose E. Marchesi
2021-11-25  9:47               ` Giuliano Procida
2021-12-01  3:18               ` Ben Woodard
2021-11-25  9:34             ` Giuliano Procida
2021-11-25 21:56               ` Ben Woodard
2021-11-26 10:27             ` Dodji Seketeli
2021-12-01  2:13               ` Ben Woodard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1990370.rjD3G2zAS3@sali \
    --to=guillermo.e.martinez@oracle.com \
    --cc=jose.marchesi@oracle.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).