From: "Matthias Maennich via libabigail" <libabigail@sourceware.org>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 2/2] KMI Whitelists: Drop old whitelist extraction methods
Date: Wed, 01 Jan 2020 00:00:00 -0000 [thread overview]
Message-ID: <20200121184008.GA7340@google.com> (raw)
In-Reply-To: <87sgk8u6ac.fsf@seketeli.org>
On Tue, Jan 21, 2020 at 05:24:11PM +0100, Dodji Seketeli wrote:
>Matthias Maennich <maennich@google.com> a écrit:
>
>> The previous commit introduces a new (tested) way of creating function
>> and variable suppressions from multiple whitelist definitions. Migrate
>> to this new way of processing KMI whitelists.
>>
>> * include/abg-tools-utils.h
>> (gen_suppr_spec_from_kernel_abi_whitelist): Delete declaration.
>> * src/abg-tools-utils.cc
>> (gen_suppr_spec_from_kernel_abi_whitelist): Delete definition
>> and migrate users to gen_suppr_spec_from_kernel_abi_whitelists.
>> * tools/abidiff.cc (set_suppressions): Migrate from using
>> gen_suppr_spec_from_kernel_abi_whitelist to
>> gen_suppr_spec_from_kernel_abi_whitelists.
>> * tools/abidw.cc (set_suppressions): Likewise.
>> * tools/abipkgdiff.cc: Drop unused using definition.
>> * tools/kmidiff.cc: Likewise.
>
>This is OK to commit to master once the first patch of the series is in.
Hi Dodji!
Thanks for the review!
I applied the patches after correcting them both(!) according to your
comments.
Cheers,
Matthias
>
>Thank you for working on this!
>
>Cheers,
>
>--
> Dodji
prev parent reply other threads:[~2020-01-21 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 0:00 [PATCH 1/2] KMI Whitelists: Add functionality to make whitelists additive Matthias Maennich via libabigail
2020-01-01 0:00 ` Dodji Seketeli
2020-01-01 0:00 ` Matthias Maennich via libabigail
2020-01-01 0:00 ` [PATCH 2/2] KMI Whitelists: Drop old whitelist extraction methods Matthias Maennich via libabigail
2020-01-01 0:00 ` Dodji Seketeli
2020-01-01 0:00 ` Matthias Maennich via libabigail [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121184008.GA7340@google.com \
--to=libabigail@sourceware.org \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).