From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3dmxnXggKCuUNWYVJPKHNVVNSL.JVTSPIHIPNHPSZVbYJLdHYL.VYN@flex--gprocida.bounces.google.com> Received: from mail-wm1-x34a.google.com (mail-wm1-x34a.google.com [IPv6:2a00:1450:4864:20::34a]) by sourceware.org (Postfix) with ESMTPS id 098D43871026 for ; Tue, 10 Mar 2020 10:31:20 +0000 (GMT) Received: by mail-wm1-x34a.google.com with SMTP id r19so191714wmh.1 for ; Tue, 10 Mar 2020 03:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=PJBLHZAX5xIttoFF2OzYyr3tO7mVRiJ08WEHDHjTJBc=; b=chyP9VG+eIzvS3L4+O8QzY/FUNwvwAKv20I20NT6qmvtIQb4w+m9ttF5dzzs0lRXmy ZH3ABs0BvpKduyqFnTcw8U/QKmE9SBK7SbGb2Sv7HUeOKY9NcqiKIyEyaYaf+JO5vqMo Vac/CPjx6dWC+6LSR7TilCQ6FTlx6rBXT6GGSa3C3tp4mnLR/Lva8tZyBu2WllVQSQvF r5lxglC0+PfIxhfTt8v/cr1jz465aDB5xo5LxZVCBcFGDpTAU6up3o6/yMsRBoX68vT+ BYW/C/qppNj0qHe7F3eSuRvDGlhZCFobUPW14QLNenQY3wuiSBovXa2YFgWFdXvdwaOy r8ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=PJBLHZAX5xIttoFF2OzYyr3tO7mVRiJ08WEHDHjTJBc=; b=C/qWqEAS84pYOAD2wrqzmzdBcUKykQ+E878fZpc8ZaUrntiCG5t4P+UdmAwM/RMUSZ EKW59RbZfR6JgbYqb8CZMZaOaJD5jnCozu4fRiY2RLq48jeM5A0x0yruSgv0tOsJS6KI e7RkmaCqDrrQ2X7kqi87POpNK0DB5P4dXQ0togDuebehWjrBxwgb4XaIwSIHfVeieGxD 0qhFKkTDJ0hj1AkqbZiR4NNdk55hQw5A6QMofuLI8RmNZSGzdTvu8onpNjJGovQvqf7/ YzMMR10KIlwhHocidfkfc/qCXra9eAu/6DlbP3GN9H8jiDYCH49PrgYDYSOqaiKpGcTN bz1A== X-Gm-Message-State: ANhLgQ1C7vZ8BNzFTWWZ9D0w7wDjwXtDepaRS7hIsFTAwH28LduDlZlD 3qANGWgasSt8EvowPlEzSqfVjCL96Zsn6bm8rLPyfKX09jP3vcVogMHOYRbu+ivMn9fT8U/naPT ySxHY0r3S0DF/3FCotJUzOA47wBpMwQjgO+0XZuZ65/ic7u+zoOyEbEiRxWIs+8k/TbDw2Og= X-Google-Smtp-Source: ADFU+vsY1eCgGbskEuB68dRzH1I6OE+K7Vnm+GqcCMT++G1IMYVqOBajDVA0s0YCn3bg6f8zlbZ82g9q5oC3qw== X-Received: by 2002:adf:f70f:: with SMTP id r15mr27121309wrp.269.1583836278623; Tue, 10 Mar 2020 03:31:18 -0700 (PDT) Date: Tue, 10 Mar 2020 10:31:13 +0000 Message-Id: <20200310103113.54010-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.1.481.gfbce0eb801-goog Subject: [PATCH] [abisym] Remove leading space in output. From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-34.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 10:31:23 -0000 When abisym reports a symbol as found, it currently emits a leading space. It does not do this when reporting a symbol as not found. This patch removes the leading space. * tools/abisym.cc (main): Remove leading space from output. * tests/data/test-lookup-syms/test0-report.txt: Remove leading space from expected output. * tests/data/test-lookup-syms/test01-report.txt: Ditto. * tests/data/test-lookup-syms/test02-report.txt: Ditto. * tests/data/test-lookup-syms/test1-1-report.txt: Ditto. Signed-off-by: Giuliano Procida --- tests/data/test-lookup-syms/test0-report.txt | 2 +- tests/data/test-lookup-syms/test01-report.txt | 2 +- tests/data/test-lookup-syms/test02-report.txt | 2 +- tests/data/test-lookup-syms/test1-1-report.txt | 2 +- tools/abisym.cc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/data/test-lookup-syms/test0-report.txt b/tests/data/test-lookup-syms/test0-report.txt index 51042d4a..2806123f 100644 --- a/tests/data/test-lookup-syms/test0-report.txt +++ b/tests/data/test-lookup-syms/test0-report.txt @@ -1 +1 @@ - found symbol 'main', an instance of function symbol type of global binding +found symbol 'main', an instance of function symbol type of global binding diff --git a/tests/data/test-lookup-syms/test01-report.txt b/tests/data/test-lookup-syms/test01-report.txt index ba8f909e..ce80129e 100644 --- a/tests/data/test-lookup-syms/test01-report.txt +++ b/tests/data/test-lookup-syms/test01-report.txt @@ -1 +1 @@ - found symbol 'foo', an instance of function symbol type of global binding +found symbol 'foo', an instance of function symbol type of global binding diff --git a/tests/data/test-lookup-syms/test02-report.txt b/tests/data/test-lookup-syms/test02-report.txt index b374d17e..d5e29945 100644 --- a/tests/data/test-lookup-syms/test02-report.txt +++ b/tests/data/test-lookup-syms/test02-report.txt @@ -1 +1 @@ - found symbol 'bar(char)' (_Z3barc), an instance of function symbol type of global binding +found symbol 'bar(char)' (_Z3barc), an instance of function symbol type of global binding diff --git a/tests/data/test-lookup-syms/test1-1-report.txt b/tests/data/test-lookup-syms/test1-1-report.txt index 15a3d416..2904c6d2 100644 --- a/tests/data/test-lookup-syms/test1-1-report.txt +++ b/tests/data/test-lookup-syms/test1-1-report.txt @@ -1 +1 @@ - found symbol 'foo', an instance of function symbol type of global binding, of versions 'VERSION_2.0', 'VERSION_1.0' +found symbol 'foo', an instance of function symbol type of global binding, of versions 'VERSION_2.0', 'VERSION_1.0' diff --git a/tools/abisym.cc b/tools/abisym.cc index da24f72a..2da45b41 100644 --- a/tools/abisym.cc +++ b/tools/abisym.cc @@ -159,7 +159,7 @@ main(int argc, char* argv[]) } elf_symbol_sptr sym = syms[0]; - cout << " found symbol '" << n << "'"; + cout << "found symbol '" << n << "'"; if (n != sym->get_name()) cout << " (" << sym->get_name() << ")"; cout << ", an instance of " -- 2.25.1.481.gfbce0eb801-goog