From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by sourceware.org (Postfix) with ESMTPS id 68757385E014 for ; Thu, 26 Mar 2020 10:37:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68757385E014 Received: by mail-wr1-x444.google.com with SMTP id u10so7076979wro.7 for ; Thu, 26 Mar 2020 03:37:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hg5AUbqhTn3KFsCuL/MTG7e1GP5ce/PEP/VeacU/65Q=; b=ZiiO+Zm/CVQ0y836w87wcLU+YMa+1KCPl/vj2xDajrWS1p5kuPHx31qgH3fn7j+t6J vdFQWtwwf+938XIJZhOnNs7pHj11EJNLUjKAdao2xhb16BqwjY9vzCTpet1IHQJ6BNx/ 9S0swAbQJxtsh3acxubg2TrQodY0zNx8SnGNRkNTR/fMoVP0BqFrSNFkHqBNriQbco3X iMblBa6nX4AYMRaBewQc6KKm1aht9+Akd5yCSg/BvTxr3hHibVUWJZFOwC8TAwmOX4Oq 0VTbSB77Irv4ZLsnM//qyJAqLz0v4zsKqDMMMpSSANQG58rDDWR4cAfOXT//Rir9/Hwv mVYA== X-Gm-Message-State: ANhLgQ2iC8TkBLTBz97PZS/KGvPZxTyg3yqH5MEHfbnhTE0PUEyJ/5AC g87ERtKBG2IjslkQqhjrQXTiew== X-Google-Smtp-Source: ADFU+vs/euNp1ZlH7xIxePmCnU0WwiPvI/jO+MjPPgeSEPJpeCRxWJCWDyz2XGQAvZUjpTRtJXv4zg== X-Received: by 2002:adf:c506:: with SMTP id q6mr8724600wrf.142.1585219039090; Thu, 26 Mar 2020 03:37:19 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id b82sm2898595wmb.46.2020.03.26.03.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 03:37:18 -0700 (PDT) Date: Thu, 26 Mar 2020 11:37:17 +0100 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [RFC] Fix has_net_changes for leaf-changes-only mode. Message-ID: <20200326103717.GC153882@google.com> References: <20200324171344.258865-1-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200324171344.258865-1-gprocida@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-38.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 10:37:21 -0000 On Tue, Mar 24, 2020 at 05:13:44PM +0000, Giuliano Procida wrote: >* Which other functions need the same treatment? >* Should something else change instead? >* What about tracking of changed types (inclusion of these in summary > stats and exit code for leaf mode)? > >This patch breaks tests and is not suitable for applying in its >current form. > >The issue we saw is that anonymous struct name changes triggered >hundreds of diffs (mostly but not all filtered out in non-leaf mode >which may be its own bug). > > * src/abg-comparison.cc (corpus_diff::has_net_changes): In > leaf-changes-only mode, check leaf changes to functions and > variables to avoid returning non-zero exit code with empty > output. > That patch looks generally good to me. Do you have an idea how to address the test breakages? >Signed-off-by: Giuliano Procida >--- > src/abg-comparison.cc | 33 +++++++++++++++++++-------------- > 1 file changed, 19 insertions(+), 14 deletions(-) > >diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc >index 46bf9e30..7756c12b 100644 >--- a/src/abg-comparison.cc >+++ b/src/abg-comparison.cc >@@ -10602,21 +10602,26 @@ corpus_diff::has_net_changes() const > const diff_stats& stats = const_cast(this)-> > apply_filters_and_suppressions_before_reporting(); > >+ bool leaf = context()->show_leaf_changes_only(); const Cheers, Matthias > return (architecture_changed() >- || soname_changed() >- || stats.net_num_func_changed() >- || stats.net_num_vars_changed() >- || stats.net_num_func_added() >- || stats.net_num_added_func_syms() >- || stats.net_num_func_removed() >- || stats.net_num_removed_func_syms() >- || stats.net_num_vars_added() >- || stats.net_num_added_var_syms() >- || stats.net_num_vars_removed() >- || stats.net_num_removed_var_syms() >- || stats.net_num_added_unreachable_types() >- || stats.net_num_removed_unreachable_types() >- || stats.net_num_changed_unreachable_types()); >+ || soname_changed() >+ || (leaf >+ ? stats.net_num_leaf_func_changes() >+ : stats.net_num_func_changed()) >+ || (leaf >+ ? stats.net_num_leaf_var_changes() >+ : stats.net_num_vars_changed()) >+ || stats.net_num_func_added() >+ || stats.net_num_added_func_syms() >+ || stats.net_num_func_removed() >+ || stats.net_num_removed_func_syms() >+ || stats.net_num_vars_added() >+ || stats.net_num_added_var_syms() >+ || stats.net_num_vars_removed() >+ || stats.net_num_removed_var_syms() >+ || stats.net_num_added_unreachable_types() >+ || stats.net_num_removed_unreachable_types() >+ || stats.net_num_changed_unreachable_types()); > } > > /// Apply the different filters that are registered to be applied to >-- >2.25.1.696.g5e7596f4ac-goog >