From: Matthias Maennich <maennich@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com
Subject: Re: [PATCH 3/3] abidiffpkg: Remove stray test report file.
Date: Sun, 29 Mar 2020 19:31:05 +0200 [thread overview]
Message-ID: <20200329173105.GG101337@google.com> (raw)
In-Reply-To: <20200329170121.188147-3-gprocida@google.com>
On Sun, Mar 29, 2020 at 06:01:21PM +0100, Giuliano Procida wrote:
>The file tests/data/test-diff-pkg/dirpkg-2-report-1.txt looks like it
>was committed in error. It's not used, its contents don't match the
>implied directories being compared and there are other tests that
>cover the same functionality, with or without --no-abignore, anyway.
>
> * tests/data/Makefile.am: Removed
> tests/data/test-diff-pkg/dirpkg-2-report-1.txt.
> * tests/data/test-diff-pkg/dirpkg-2-report-1.txt: Removed.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> tests/data/Makefile.am | 1 -
> tests/data/test-diff-pkg/dirpkg-2-report-1.txt | 16 ----------------
> 2 files changed, 17 deletions(-)
> delete mode 100644 tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>
>diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am
>index 277f5721..bb0fd83b 100644
>--- a/tests/data/Makefile.am
>+++ b/tests/data/Makefile.am
>@@ -1479,7 +1479,6 @@ test-diff-pkg/dirpkg-2-dir2/dir.abignore \
> test-diff-pkg/dirpkg-2-dir2/libobj-v0.so \
> test-diff-pkg/dirpkg-2-dir2/obj-v0.cc \
> test-diff-pkg/dirpkg-2-report-0.txt \
>-test-diff-pkg/dirpkg-2-report-1.txt \
> test-diff-pkg/dirpkg-3-dir1/libobj-v0.so \
> test-diff-pkg/dirpkg-3-dir1/obj-v0.cc \
> test-diff-pkg/dirpkg-3-dir2/.abignore \
>diff --git a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt b/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>deleted file mode 100644
>index c7c34702..00000000
>--- a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt
>+++ /dev/null
>@@ -1,16 +0,0 @@
>-================ changes of 'libobj-v0.so'===============
>- Functions changes summary: 0 Removed, 1 Changed, 0 Added function
>- Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>-
>- 1 function with some indirect sub-type change:
>-
>- [C] 'function void bar(S&)' has some indirect sub-type changes:
>- parameter 1 of type 'S&' has sub-type changes:
>- in referenced type 'struct S':
>- type size changed from 32 to 64 bits
>- 1 data member insertion:
>- 'char S::mem1', at offset 32 (in bits)
>-
>-
>-================ end of changes of 'libobj-v0.so'===============
>-
>--
>2.26.0.rc2.310.g2932bb562d-goog
>
next prev parent reply other threads:[~2020-03-29 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 17:01 [PATCH 1/3] abidiff: Remove blank line after typedef changes Giuliano Procida
2020-03-29 17:01 ` [PATCH 2/3] test-diff-suppr.cc: Add missing tests Giuliano Procida
2020-03-29 17:30 ` Matthias Maennich
2020-04-01 16:46 ` Dodji Seketeli
2020-03-29 17:01 ` [PATCH 3/3] abidiffpkg: Remove stray test report file Giuliano Procida
2020-03-29 17:31 ` Matthias Maennich [this message]
2020-04-01 17:31 ` Dodji Seketeli
2020-03-29 17:30 ` [PATCH 1/3] abidiff: Remove blank line after typedef changes Matthias Maennich
2020-04-01 16:21 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329173105.GG101337@google.com \
--to=maennich@google.com \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).