From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 08FAF385B836 for ; Sun, 29 Mar 2020 17:31:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 08FAF385B836 Received: by mail-wm1-x341.google.com with SMTP id z14so1405267wmf.0 for ; Sun, 29 Mar 2020 10:31:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/L3cy0gNzzvm0CqbaugA8uqXp9ppOsqoE41sgkKrICI=; b=qQA9k9ww02mh+7HKG+8QiZygYELweVR4GbvkwUuXeqSfWhqedC0IJoxtLr+8DpiArg EXYhcg+f2bJw5OXxBMMEeIft8p9PnZ9ozLv9Sf0iSXjRKjeOHN05Ustcnta/RNbeGJvG PcGUzNrZx4gQ/q+AMUEAB8r/tFOWJ2JcD1EtIykYq+MFeWryIPXlDe8Cx6ZvpAiZL6VG O1/bCKD/zn5yvaLpdcfZgYse0E/6X2SVcy91q72fYQBqyIk95ZY5K0+lWK71Nepl89i3 DMz+gMtGHsKEm40JIHRag7HUt4Rbvlo2xXSJiKCGb3/cUqpSE72yhW01k+hG0Bmjukol lcYw== X-Gm-Message-State: ANhLgQ3YU/ZMN1yyL2u6QIxlejwS+MXz/Upmah4epmMuHtnm+Yn/vJcO FCY8uLzPQKiI5atUtTSHtvsccA== X-Google-Smtp-Source: ADFU+vvws6qbQvLV1jNHdUJ9vA/FjZ5MquXRSfHhm3upM4kG3mlO0O8dpXf1TQmNiUOkNes/sWNnZw== X-Received: by 2002:a7b:cd89:: with SMTP id y9mr1873461wmj.102.1585503065760; Sun, 29 Mar 2020 10:31:05 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id a8sm17077272wmb.39.2020.03.29.10.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 10:31:05 -0700 (PDT) Date: Sun, 29 Mar 2020 19:31:05 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH 3/3] abidiffpkg: Remove stray test report file. Message-ID: <20200329173105.GG101337@google.com> References: <20200329170121.188147-1-gprocida@google.com> <20200329170121.188147-3-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200329170121.188147-3-gprocida@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-40.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 17:31:08 -0000 On Sun, Mar 29, 2020 at 06:01:21PM +0100, Giuliano Procida wrote: >The file tests/data/test-diff-pkg/dirpkg-2-report-1.txt looks like it >was committed in error. It's not used, its contents don't match the >implied directories being compared and there are other tests that >cover the same functionality, with or without --no-abignore, anyway. > > * tests/data/Makefile.am: Removed > tests/data/test-diff-pkg/dirpkg-2-report-1.txt. > * tests/data/test-diff-pkg/dirpkg-2-report-1.txt: Removed. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > tests/data/Makefile.am | 1 - > tests/data/test-diff-pkg/dirpkg-2-report-1.txt | 16 ---------------- > 2 files changed, 17 deletions(-) > delete mode 100644 tests/data/test-diff-pkg/dirpkg-2-report-1.txt > >diff --git a/tests/data/Makefile.am b/tests/data/Makefile.am >index 277f5721..bb0fd83b 100644 >--- a/tests/data/Makefile.am >+++ b/tests/data/Makefile.am >@@ -1479,7 +1479,6 @@ test-diff-pkg/dirpkg-2-dir2/dir.abignore \ > test-diff-pkg/dirpkg-2-dir2/libobj-v0.so \ > test-diff-pkg/dirpkg-2-dir2/obj-v0.cc \ > test-diff-pkg/dirpkg-2-report-0.txt \ >-test-diff-pkg/dirpkg-2-report-1.txt \ > test-diff-pkg/dirpkg-3-dir1/libobj-v0.so \ > test-diff-pkg/dirpkg-3-dir1/obj-v0.cc \ > test-diff-pkg/dirpkg-3-dir2/.abignore \ >diff --git a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt b/tests/data/test-diff-pkg/dirpkg-2-report-1.txt >deleted file mode 100644 >index c7c34702..00000000 >--- a/tests/data/test-diff-pkg/dirpkg-2-report-1.txt >+++ /dev/null >@@ -1,16 +0,0 @@ >-================ changes of 'libobj-v0.so'=============== >- Functions changes summary: 0 Removed, 1 Changed, 0 Added function >- Variables changes summary: 0 Removed, 0 Changed, 0 Added variable >- >- 1 function with some indirect sub-type change: >- >- [C] 'function void bar(S&)' has some indirect sub-type changes: >- parameter 1 of type 'S&' has sub-type changes: >- in referenced type 'struct S': >- type size changed from 32 to 64 bits >- 1 data member insertion: >- 'char S::mem1', at offset 32 (in bits) >- >- >-================ end of changes of 'libobj-v0.so'=============== >- >-- >2.26.0.rc2.310.g2932bb562d-goog >