From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id E4F55385DC13 for ; Mon, 6 Apr 2020 11:25:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E4F55385DC13 Received: by mail-wr1-x443.google.com with SMTP id c15so1065326wro.11 for ; Mon, 06 Apr 2020 04:25:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qY3MZc547ZD6DSxCzm0v2ijFU7fCSIX8ljGeg+FiLSc=; b=PmmWlspCYtyzQ4aV8V1op4GWj3vHa1efDlH0rMAb3T7ID3g1Zvktv+uPcZlSubQd29 UObVzU7Yr2oPtUDC+7odrB3n1N6q0+BvAcCMj0NcA5qjB2odxqIVooBgQp47Gh22qdhi 18mKie72MxtGcpUnl6bgkTSh9OwMHvRWzfTrqbqNf2rHO9hkrtW45iDxRpzx/f+2CnLU oRDOT1XDCcnvihtW6M/4+ET28nA6Lvhtpv0QBCYupI7rRxU3ZfLxAUAAKy5SeDXLDv2x pp1t1JCChx7nLwe93ZnLHkqxYNrZ+EJfTNRNOhtYPPQO4qvobCwRHvDBLUhUoO8BnZXU 8lpA== X-Gm-Message-State: AGi0PuYioo3OSU7e176TO5ebOGIRTxdEY9GyKvtOGC52+CztQBKtDYos IuyhnDVbGuTAPNMyFM/Ywd5+Wg== X-Google-Smtp-Source: APiQypJK1rS4pDs4T1dmC6IGxU/8LO63/rLp0TE5mp7YfVUipd/qyECYMqN8k80/ZwPU+hyVlrQbrA== X-Received: by 2002:a5d:4e47:: with SMTP id r7mr22822131wrt.424.1586172317693; Mon, 06 Apr 2020 04:25:17 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id d10sm5332499wrp.9.2020.04.06.04.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 04:25:17 -0700 (PDT) Date: Mon, 6 Apr 2020 13:25:16 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH 2/2] test-abidiff-exit.cc: Drop redundant --redundant. Message-ID: <20200406112516.GB72186@google.com> References: <20200406084450.140975-1-gprocida@google.com> <20200406084450.140975-2-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200406084450.140975-2-gprocida@google.com> X-Spam-Status: No, score=-40.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, FSL_HELO_FAKE, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Apr 2020 11:25:20 -0000 On Mon, Apr 06, 2020 at 09:44:50AM +0100, Android Kernel Team wrote: > * tests/test-abidiff-exit.cc: Drop obsolete --redundant flag > and comment as --redundant is now implied by > --leaf-changes-only. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > tests/test-abidiff-exit.cc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/tests/test-abidiff-exit.cc b/tests/test-abidiff-exit.cc >index af3711b2..25f58b34 100644 >--- a/tests/test-abidiff-exit.cc >+++ b/tests/test-abidiff-exit.cc >@@ -133,8 +133,7 @@ InOutSpec in_out_specs[] = > "data/test-abidiff-exit/test-leaf-more-v0.o", > "data/test-abidiff-exit/test-leaf-more-v1.o", > "", >- // --redundant - pending a bug fix >- "--no-show-locs --leaf-changes-only --redundant", >+ "--no-show-locs --leaf-changes-only", > abigail::tools_utils::ABIDIFF_ABI_CHANGE > | abigail::tools_utils::ABIDIFF_ABI_INCOMPATIBLE_CHANGE, > "data/test-abidiff-exit/test-leaf-more-report.txt", >-- >2.26.0.292.g33ef6b2f38-goog > >