From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3GwOWXggKCnQYhjgUaVSYggYdW.UgedaTSTaYSadkgmjUWoSjW.gjY@flex--gprocida.bounces.google.com> Received: from mail-wr1-x44a.google.com (mail-wr1-x44a.google.com [IPv6:2a00:1450:4864:20::44a]) by sourceware.org (Postfix) with ESMTPS id F3BA8385BF83 for ; Tue, 14 Apr 2020 18:38:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3BA8385BF83 Received: by mail-wr1-x44a.google.com with SMTP id o10so9144893wrj.7 for ; Tue, 14 Apr 2020 11:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=joYJinVg1EpyudIeyMnCh1PDJrApcPJKN9DpJI0vQwY=; b=V0MN9m6qrB5AVgDPD4y1MF8LZwLs5Il+dtLKc8Q05VOLe2kDIEWX68Oqezo5jozBbl nR71E81RiPONXzrThkdDWIAJimNEHHPgQTzGRaOv6QNvJ9EqMSAjIdInAcQHFT2vTRYv AAz53Bdy8Iq5ledV+9Do2LOpWdI2HXsKWP6yYLVrM5NoxRoDgCBeTwroN5sU6Mte/rQN jlIFTS7qfn+URZK8KI8uwm7DLWZunM3ybN/60qZjLTUt5yga9UF8PSFe1E3A/PgeBrx9 wi2O/mkmw2Dvrs4b7B1jHCR3jhXo2bAOSsZX6W5AqSv17jOj6n//CjLXt8gn83Br+A3w UzuQ== X-Gm-Message-State: AGi0PuYszgJlBSeWfe8o3bCZpsCYhVrCVLld/MYGUhchI9RgOaS6tozc gZWbjA1LX7Ei6Ni3MkrqINR9q1j+4qIi7z58Z8/aQTpXcPH0tX0Ysk+KQOoxkhD3b4E145j5mFO SeIDB+1PiB9KN9DU7EZE2tv0jKJugoegFEz0r6qttsWFWtW6vVkIkNMfEN9G0SVTrhgCi0h8= X-Google-Smtp-Source: APiQypL9T4u3xqRlbYNnI6e1iHsZZtQLxKMccKZmH+yWZ+od8M9t1DGoqdfOp0COJwGXlbWZwqf07gUThneWXA== X-Received: by 2002:adf:8b48:: with SMTP id v8mr26918456wra.342.1586889499579; Tue, 14 Apr 2020 11:38:19 -0700 (PDT) Date: Tue, 14 Apr 2020 19:38:13 +0100 Message-Id: <20200414183813.76227-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.26.0.110.g2183baf09c-goog Subject: [PATCH] Fix variable suppression name_not_regex. From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-34.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 18:38:24 -0000 Kernel symbol whitelisting symbol is implemented using a regex to suppress all function and variable names that don't match the given list. This was completely broken for variables, resulting in all variables being filtered out if a kernel whitelist was specified. * src/abg-suppression-priv.h: In get_symbol_name_not_regex method of variable_suppression::priv, fix typo causing miscompilation of regex. Signed-off-by: Giuliano Procida --- src/abg-suppression-priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h index 71057ce1..1a9a7207 100644 --- a/src/abg-suppression-priv.h +++ b/src/abg-suppression-priv.h @@ -680,7 +680,7 @@ struct variable_suppression::priv { sptr_utils::regex_t_sptr r = sptr_utils::build_sptr(); if (regcomp(r.get(), symbol_name_not_regex_str_.c_str(), - REG_EXTENDED == 0) == 0) + REG_EXTENDED) == 0) symbol_name_not_regex_ = r; } return symbol_name_not_regex_; -- 2.26.0.110.g2183baf09c-goog