From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 18277385DC0B for ; Tue, 14 Apr 2020 19:49:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 18277385DC0B Received: by mail-wm1-x344.google.com with SMTP id g12so7836852wmh.3 for ; Tue, 14 Apr 2020 12:49:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4bOkMncu/6TJKQOmE6XmNpwG9SFrgFP4agPo6u8nW2U=; b=lHVM3Zl9rLU+9Rcoif0x4RGbWLZp42pSqp38QaKzDptIVUV3s+MCgi5CQzTssSQSrm /F7cS702N1VG0AlF38itoCRTf5OBgJ8lQn1XwKL6N1ta10CETENVDPbtncuJ9ld2Lqba tGKhp9k5nVgs0Zh+uwhKfVKGeToRZHavcgOMZtEhsSo3MC5dLSVZ8ibswqQNheyviq2g Piz+Qan7pWom7QJ/dJVftSoPtnEF+RR4XbfwZWZarSa3ztw6L0t1gWN8KqKa147ETGll 4U/xZrmsgY+60nZG6QLP9ju1m7P1vq9Or6/psT5Mym1JqXrJTP57iQUq04YxzTPUTtN5 FqzA== X-Gm-Message-State: AGi0PuZ28KuSbhED6YVDKPWAMQT80BUNpIqwoV5/DLQqF1/u6AIcCILC QkMDVbVw5V5yYYD79C8wwQGC1A== X-Google-Smtp-Source: APiQypIrqmk25ivhi0eBhvYJds6/jUxhDJsosUBS+ayL61HWYx3Zehi+1Usi3YZ9Eaxk3C8p4ho9aw== X-Received: by 2002:a1c:5446:: with SMTP id p6mr1413320wmi.172.1586893781515; Tue, 14 Apr 2020 12:49:41 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id m15sm19393551wmc.35.2020.04.14.12.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 12:49:41 -0700 (PDT) Date: Tue, 14 Apr 2020 21:49:40 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH] Fix variable suppression name_not_regex. Message-ID: <20200414194940.GA26670@google.com> References: <20200414183813.76227-1-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200414183813.76227-1-gprocida@google.com> X-Spam-Status: No, score=-41.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, FSL_HELO_FAKE, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 19:49:44 -0000 On Tue, Apr 14, 2020 at 07:38:13PM +0100, Giuliano Procida wrote: >Kernel symbol whitelisting symbol is implemented using a regex to >suppress all function and variable names that don't match the given >list. This was completely broken for variables, resulting in all >variables being filtered out if a kernel whitelist was specified. > > * src/abg-suppression-priv.h: In get_symbol_name_not_regex > method of variable_suppression::priv, fix typo causing > miscompilation of regex. > Nice catch! Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich Cheers, Matthias >Signed-off-by: Giuliano Procida >--- > src/abg-suppression-priv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h >index 71057ce1..1a9a7207 100644 >--- a/src/abg-suppression-priv.h >+++ b/src/abg-suppression-priv.h >@@ -680,7 +680,7 @@ struct variable_suppression::priv > { > sptr_utils::regex_t_sptr r = sptr_utils::build_sptr(); > if (regcomp(r.get(), symbol_name_not_regex_str_.c_str(), >- REG_EXTENDED == 0) == 0) >+ REG_EXTENDED) == 0) > symbol_name_not_regex_ = r; > } > return symbol_name_not_regex_; >-- >2.26.0.110.g2183baf09c-goog >