From: Matthias Maennich <maennich@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com
Subject: Re: [PATCH 2/3] test35-leaf.suppr: fix regex typo.
Date: Tue, 21 Apr 2020 12:20:47 +0200 [thread overview]
Message-ID: <20200421102047.GB80434@google.com> (raw)
In-Reply-To: <20200420164153.5213-2-gprocida@google.com>
On Mon, Apr 20, 2020 at 05:41:51PM +0100, Giuliano Procida wrote:
>Bad regexes are silently ignored. This will be fixed in a later
>commit.
>
> * tests/data/test-diff-suppr/test35-leaf.suppr: Fix typo in
> regex, "*." -> ".*".
>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>Signed-off-by: Giuliano Procida <gprocida@google.com>
>---
> tests/data/test-diff-suppr/test35-leaf.suppr | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/data/test-diff-suppr/test35-leaf.suppr b/tests/data/test-diff-suppr/test35-leaf.suppr
>index b4ec73c8..b49293ec 100644
>--- a/tests/data/test-diff-suppr/test35-leaf.suppr
>+++ b/tests/data/test-diff-suppr/test35-leaf.suppr
>@@ -4,5 +4,5 @@
> # member named 'member0'. That would be the type named
> # leaf_to_filter.
>
>- name_regexp = *.
>+ name_regexp = .*
> has_data_member_inserted_between = {offset_after(member0), end}
>--
>2.26.1.301.g55bc3eb7cb9-goog
>
next prev parent reply other threads:[~2020-04-21 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:41 [PATCH 1/3] test-diff-suppr: Improve regexes in tests Giuliano Procida
2020-04-20 16:41 ` [PATCH 2/3] test35-leaf.suppr: fix regex typo Giuliano Procida
2020-04-21 10:20 ` Matthias Maennich [this message]
2020-04-22 13:56 ` Dodji Seketeli
2020-04-20 16:41 ` [PATCH 3/3] test24-soname-suppr*txt: Fix suppression syntax Giuliano Procida
2020-04-20 17:20 ` Giuliano Procida
2020-04-20 17:23 ` [PATCH 3/3 v2] " Giuliano Procida
2020-04-21 10:24 ` Matthias Maennich
2020-04-22 15:05 ` Dodji Seketeli
2020-04-21 10:19 ` [PATCH 1/3] test-diff-suppr: Improve regexes in tests Matthias Maennich
2020-04-21 10:57 ` Giuliano Procida
2020-04-22 13:48 ` Dodji Seketeli
2020-04-22 19:11 ` Giuliano Procida
2020-05-01 15:56 ` Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421102047.GB80434@google.com \
--to=maennich@google.com \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).