From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com
Subject: [PATCH 2/3] abidiff: Blank line after declaration-only diff.
Date: Wed, 22 Apr 2020 22:20:58 +0100 [thread overview]
Message-ID: <20200422212059.258602-2-gprocida@google.com> (raw)
In-Reply-To: <20200422212059.258602-1-gprocida@google.com>
In the case where a type change is summarised as declaration-only to
defined or vice versa, the trailing new line was missing.
* src/abg-default-reporter.cc (default_reporter::report): In
the class_or_union_diff overload, emit a new line at the end
of the declaration-only reporting path.
* tests/data/test-abidiff-exit/test-decl-struct-report.txt:
Add missing blank lines.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-default-reporter.cc | 2 +-
tests/data/test-abidiff-exit/test-decl-struct-report.txt | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/abg-default-reporter.cc b/src/abg-default-reporter.cc
index ff7ed67e..04e2bb76 100644
--- a/src/abg-default-reporter.cc
+++ b/src/abg-default-reporter.cc
@@ -859,7 +859,7 @@ default_reporter::report(const class_or_union_diff& d,
: " and is now a defined type";
out << indent << "type " << first->get_pretty_representation()
- << was << is_now;
+ << was << is_now << "\n";
return;
}
diff --git a/tests/data/test-abidiff-exit/test-decl-struct-report.txt b/tests/data/test-abidiff-exit/test-decl-struct-report.txt
index aa5dedae..8bb712e6 100644
--- a/tests/data/test-abidiff-exit/test-decl-struct-report.txt
+++ b/tests/data/test-abidiff-exit/test-decl-struct-report.txt
@@ -9,9 +9,11 @@ Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
in unqualified underlying type 'struct embodied' at test-decl-struct-v1.c:1:1:
type size changed from 0 to 32 (in bits)
type struct embodied was a declaration-only type and is now a defined type
+
[C] 'function void reg2(const disembodied*)' at test-decl-struct-v1.c:5:1 has some indirect sub-type changes:
parameter 1 of type 'const disembodied*' has sub-type changes:
in pointed to type 'const disembodied':
in unqualified underlying type 'struct disembodied':
type size changed from 32 to 0 (in bits)
type struct disembodied was a defined type and is now a declaration-only type
+
--
2.26.1.301.g55bc3eb7cb9-goog
next prev parent reply other threads:[~2020-04-22 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 21:20 [PATCH 1/3] Add tests for declaration-only struct diffs Giuliano Procida
2020-04-22 21:20 ` Giuliano Procida [this message]
2020-04-27 11:15 ` [PATCH 2/3] abidiff: Blank line after declaration-only diff Dodji Seketeli
2020-04-22 21:20 ` [PATCH 3/3] abidiff: Omit declaration-only type size 0 diffs Giuliano Procida
2020-04-27 11:15 ` Dodji Seketeli
2020-04-27 11:15 ` [PATCH 1/3] Add tests for declaration-only struct diffs Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422212059.258602-2-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).