From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <37q-iXggKCtM5EGD172z5DD5A3.1DBA70z075z7AHDJG13LzG3.DG5@flex--gprocida.bounces.google.com> Received: from mail-wr1-x449.google.com (mail-wr1-x449.google.com [IPv6:2a00:1450:4864:20::449]) by sourceware.org (Postfix) with ESMTPS id 5E784389364F for ; Fri, 24 Apr 2020 09:22:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E784389364F Received: by mail-wr1-x449.google.com with SMTP id d17so4445332wrr.17 for ; Fri, 24 Apr 2020 02:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=VHhdr+v+wtVs4zVACAsUAlxwm4TDquJQEnlCUSJ1438=; b=SBEqw1S2hgSlOi2Bm6UzbPIr2EkLvW67gib7XxYspKfJBqHbSHBTG3iaFRBYqK02Di odSIzWCMAsGoevgfg8ymhEYYvzrFE51b1MOI7RpYy63U70OJ7R3KGN3pA29/H5J41sxw Alr7nCJA1qI7xGXjdpSa34qpyzWYNadEaCe7GRV8ZwRhYBGdClyh18Wl2RZlHYVUNL56 WVJBNjvsKvYGK1tOVaRrm4sZQN7H8q3hesMnEc2FXfbQlQgxUHv6kg5YdESi42jbJ/wm EiJw+OBk3YYcjmy25kkAnDdXnpV5wSws+WsKYwnmJwxDgdOkKFSqkgpvre7yWREn5vyN 7Ovw== X-Gm-Message-State: AGi0PuZgQgGkiUWasm4epTQRN8y/MO+g//db2hFirqIYkcacrZf95Y7c Li5dXwoV9L3+hvWM8kvcR9VXnbxdCgTNM/trTbqT9L0Sp6Mxt+kJ2mRBR3l+dGtOl0e61lc7lDQ sdRIO5l2nb9pA0y3OKYWJr7/7bN9vD99X/dAd4PdxY1BAmSBh4mRF2Vu/HxFXO1KbC3tKbVY= X-Google-Smtp-Source: APiQypIUr2Rb2aRWmpYKolzNmaSyH8HA7k1KDF/5hD2r/Ad9gIOXOolS3RGTjU/vPaCtY/y1mGaob6/gmeb3vQ== X-Received: by 2002:a5d:6091:: with SMTP id w17mr9575941wrt.382.1587720174348; Fri, 24 Apr 2020 02:22:54 -0700 (PDT) Date: Fri, 24 Apr 2020 10:21:32 +0100 In-Reply-To: <20200424092132.150547-1-gprocida@google.com> Message-Id: <20200424092132.150547-22-gprocida@google.com> Mime-Version: 1.0 References: <20200423154441.170531-1-gprocida@google.com> <20200424092132.150547-1-gprocida@google.com> X-Mailer: git-send-email 2.26.2.303.gf8c07b1a785-goog Subject: [PATCH v3 21/21] Remove unused suppression type priv constructors. From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-33.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 09:22:56 -0000 Following on from the previous commit, many constructors for the various priv types are now unused. This patch drops them. There are no behavioural changes. * src/abg-suppression-priv.h (suppression_base::priv) Drop all but default constructor. (function_suppression::parameter_spec::priv): Drop all but 3-argument constructor. (function_suppression::priv): Drop all but default constructor. (type_suppression::priv): Drop all but default constructor. Signed-off-by: Giuliano Procida --- src/abg-suppression-priv.h | 60 -------------------------------------- 1 file changed, 60 deletions(-) diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h index 7f98fb08..97c163fe 100644 --- a/src/abg-suppression-priv.h +++ b/src/abg-suppression-priv.h @@ -58,22 +58,6 @@ public: drops_artifact_() {} - priv(const string& label) - : is_artificial_(), - drops_artifact_(), - label_(label) - {} - - priv(const string& label, - const regex::regex_t_sptr& file_name_regex, - const regex::regex_t_sptr& file_name_not_regex) - : is_artificial_(), - drops_artifact_(), - label_(label), - file_name_regex_(file_name_regex), - file_name_not_regex_(file_name_not_regex) - {} - friend class suppression_base; }; // end class suppression_base::priv @@ -90,14 +74,6 @@ class function_suppression::parameter_spec::priv string type_name_; regex::regex_t_sptr type_name_regex_; - priv() - : index_() - {} - - priv(size_t i, const string& tn) - : index_(i), type_name_(tn) - {} - priv(size_t i, const string& tn, const regex::regex_t_sptr& tn_regex) : index_(i), type_name_(tn), type_name_regex_(tn_regex) {} @@ -128,28 +104,6 @@ struct function_suppression::priv change_kind_(ALL_CHANGE_KIND), allow_other_aliases_(true) {} - - priv(const string& name, - const regex::regex_t_sptr& name_regex, - const string& return_type_name, - const regex::regex_t_sptr& return_type_regex, - const parameter_specs_type& parm_specs, - const string& symbol_name, - const regex::regex_t_sptr& symbol_name_regex, - const string& symbol_version, - const regex::regex_t_sptr& symbol_version_regex) - : change_kind_(ALL_CHANGE_KIND), - name_(name), - name_regex_(name_regex), - return_type_name_(return_type_name), - return_type_regex_(return_type_regex), - parm_specs_(parm_specs), - symbol_name_(symbol_name), - symbol_name_regex_(symbol_name_regex), - symbol_version_(symbol_version), - symbol_version_regex_(symbol_version_regex), - allow_other_aliases_(true) - {} }; // end class function_suppression::priv bool @@ -293,20 +247,6 @@ public: reach_kind_(DIRECT_REACH_KIND) {} - priv(const regex::regex_t_sptr& type_name_regexp, - const string& type_name, - bool consider_type_kind, - type_suppression::type_kind type_kind, - bool consider_reach_kind, - type_suppression::reach_kind reach_kind) - : type_name_regex_(type_name_regexp), - type_name_(type_name), - consider_type_kind_(consider_type_kind), - type_kind_(type_kind), - consider_reach_kind_(consider_reach_kind), - reach_kind_(reach_kind) - {} - friend class type_suppression; }; // class type_suppression::priv -- 2.26.2.303.gf8c07b1a785-goog