From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 5C052386F830 for ; Mon, 27 Apr 2020 10:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C052386F830 Received: by mail-wr1-x441.google.com with SMTP id g13so19896646wrb.8 for ; Mon, 27 Apr 2020 03:34:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6gKeB5k4G8OYOdZSgYUO1+e5Eoze1oH5W/KsnaQ6GGw=; b=Pk14X2lFOKsYs+3sj9rXOLMU5w7QHej6BK0IC2gHxpoanBJfZcg+i+vCRVZRt/jzow IVZWFDl1F2RtB0Hv7qVfASW4NPLxFg1ESnOxqE3xuywOwspTNvu6FkGKZJFbuVpFVXMp PaV7gN91sY04fnMIF++3y+wz8o6NGPjxINxS3klNbv0v6tobUlTUVYD/HRVQbAd+MuT9 IhZyCvJsDWgL0zLGlVlbREijVthembs7sg7+FNVO+6GxsTvk0UhxwpHFtzOmYDn5uIyO C4BCZnSLyxCgUvby5bhItRu9cJG3vvg6Yd5gNTLpT+deo83RJSGHBf3aDgOs+NN1/fJM K4WQ== X-Gm-Message-State: AGi0Pua/3OZd2SZJdZ8opH+gL5uCvzCkCrytZtWRm3XB96lrzwHWRg8N eekIkT06RzNUHpRW19vw9YSQTdjfyTrKSQ== X-Google-Smtp-Source: APiQypKnXEINemo3IpjzrBsPjeg9fWN5coGBBM5JrF0/qFxDjU2jvVAtZC7Qtwpm7vbYsh4CSivCqA== X-Received: by 2002:adf:8b8e:: with SMTP id o14mr28605163wra.392.1587983640098; Mon, 27 Apr 2020 03:34:00 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id t17sm19895921wro.2.2020.04.27.03.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 03:33:59 -0700 (PDT) Date: Mon, 27 Apr 2020 12:33:59 +0200 From: Matthias Maennich To: "Mark J. Wielaard" Cc: libabigail@sourceware.org Subject: Re: [PATCH] Rename read_elf_symbol_binding to read_elf_symbol_visibility. Message-ID: <20200427103359.GC178393@google.com> References: <20200426205622.50864-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200426205622.50864-1-mark@klomp.org> X-Spam-Status: No, score=-41.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 10:34:08 -0000 On Sun, Apr 26, 2020 at 10:56:22PM +0200, Mark J. Wielaard wrote: >From: Mark Wielaard > >read_elf_symbol_binding was overloaded so that it could be called to >read either a binding or a visibility attribute. This is slightly >confusing, since another elf_symbol attribute, type, does have its own >read_elf_symbol_type. Rename the read_elf_symbol_binding that reads >the visibility to read_elf_symbol_visibility for claritiy. > > * src/abg-reader.cc (read_elf_symbol_binding): Renamed to... > (read_elf_symbol_visibility): ...this. > >Signed-off-by: Mark Wielaard Reviewed-by: Matthias Maennich Cheers, Matthias >--- > src/abg-reader.cc | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/src/abg-reader.cc b/src/abg-reader.cc >index dcaa27e1..3727e044 100644 >--- a/src/abg-reader.cc >+++ b/src/abg-reader.cc >@@ -1166,6 +1166,8 @@ static bool read_is_struct(xmlNodePtr, bool&); > static bool read_is_anonymous(xmlNodePtr, bool&); > static bool read_elf_symbol_type(xmlNodePtr, elf_symbol::type&); > static bool read_elf_symbol_binding(xmlNodePtr, elf_symbol::binding&); >+static bool read_elf_symbol_visibility(xmlNodePtr, >+ elf_symbol::visibility&); > > static namespace_decl_sptr > build_namespace_decl(read_context&, const xmlNodePtr, bool); >@@ -2743,7 +2745,7 @@ read_elf_symbol_binding(xmlNodePtr node, elf_symbol::binding& b) > /// > /// @return true iff the function completed successfully. > static bool >-read_elf_symbol_binding(xmlNodePtr node, elf_symbol::visibility& v) >+read_elf_symbol_visibility(xmlNodePtr node, elf_symbol::visibility& v) > { > if (xml_char_sptr s = XML_NODE_GET_ATTRIBUTE(node, "visibility")) > { >@@ -2883,7 +2885,7 @@ build_elf_symbol(read_context& ctxt, const xmlNodePtr node, > read_elf_symbol_binding(node, binding); > > elf_symbol::visibility visibility = elf_symbol::DEFAULT_VISIBILITY; >- read_elf_symbol_binding(node, visibility); >+ read_elf_symbol_visibility(node, visibility); > > elf_symbol::version version(version_string, is_default_version); > >-- >2.20.1 >