From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 96014388B028 for ; Mon, 27 Apr 2020 15:41:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 96014388B028 Received: by mail-wr1-x441.google.com with SMTP id j1so21130949wrt.1 for ; Mon, 27 Apr 2020 08:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FclTcPz2Z6BXQVnpmRF144uJkYRRfErpOYXa1Fc2Ne0=; b=fAP2fwUknIyxbsry/6DZ7MGKk7hCuDXe6HuRanhPtiZOmTT/ggkTEpoSeHau9VMYfl Rv45O7ag+lIL6FzwHEWdVot+X79ZsxowN1rtrKOBIy64dexgj8FcQvguQDwmrxkVbzlf hYjGgb+YTmpA2JrdBrMe4OS0grrT8NAU+ojc2d3ue4RzIexgbZhtVZVqew3jZ3SMcx+b 9f0Fed7USS4tsP6x3VfIPucL0EtaaDHnHOjO+rZXMTPK9wFZ9W0p+2vUS0fe7BPnKkgm IyM/4sy9Ma/9BMT0EQ2faclDHP3+EpoPEBs2LZNCBAGiy46x40+v6p+mXcEeXeCgRel+ IHaw== X-Gm-Message-State: AGi0PubROkfOLDGbU9+vdO3xAe3pk6WfaTwSDX7mdqNUhY9yvZ/wwFX2 0wLchNHw0wi/ywsFkZ9w+vRzAw== X-Google-Smtp-Source: APiQypKIDPqFDsgREvA74Rg5PB17TDTxz0c54itD/2NBQIUlGjWWRwzsm9rEqZED8s9hNiKxGXx/Sw== X-Received: by 2002:a5d:4748:: with SMTP id o8mr27446764wrs.422.1588002085289; Mon, 27 Apr 2020 08:41:25 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id o3sm21810899wru.68.2020.04.27.08.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 08:41:24 -0700 (PDT) Date: Mon, 27 Apr 2020 17:41:24 +0200 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH v3 21/21] Remove unused suppression type priv constructors. Message-ID: <20200427154124.GS159704@google.com> References: <20200423154441.170531-1-gprocida@google.com> <20200424092132.150547-1-gprocida@google.com> <20200424092132.150547-22-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200424092132.150547-22-gprocida@google.com> X-Spam-Status: No, score=-41.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2020 15:41:28 -0000 On Fri, Apr 24, 2020 at 10:21:32AM +0100, Giuliano Procida wrote: >Following on from the previous commit, many constructors for the >various priv types are now unused. This patch drops them. > >There are no behavioural changes. > > * src/abg-suppression-priv.h (suppression_base::priv) Drop all > but default constructor. > (function_suppression::parameter_spec::priv): Drop all but > 3-argument constructor. (function_suppression::priv): Drop all > but default constructor. (type_suppression::priv): Drop all > but default constructor. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > src/abg-suppression-priv.h | 60 -------------------------------------- > 1 file changed, 60 deletions(-) > >diff --git a/src/abg-suppression-priv.h b/src/abg-suppression-priv.h >index 7f98fb08..97c163fe 100644 >--- a/src/abg-suppression-priv.h >+++ b/src/abg-suppression-priv.h >@@ -58,22 +58,6 @@ public: > drops_artifact_() > {} > >- priv(const string& label) >- : is_artificial_(), >- drops_artifact_(), >- label_(label) >- {} >- >- priv(const string& label, >- const regex::regex_t_sptr& file_name_regex, >- const regex::regex_t_sptr& file_name_not_regex) >- : is_artificial_(), >- drops_artifact_(), >- label_(label), >- file_name_regex_(file_name_regex), >- file_name_not_regex_(file_name_not_regex) >- {} >- > friend class suppression_base; > }; // end class suppression_base::priv > >@@ -90,14 +74,6 @@ class function_suppression::parameter_spec::priv > string type_name_; > regex::regex_t_sptr type_name_regex_; > >- priv() >- : index_() >- {} >- >- priv(size_t i, const string& tn) >- : index_(i), type_name_(tn) >- {} >- > priv(size_t i, const string& tn, const regex::regex_t_sptr& tn_regex) > : index_(i), type_name_(tn), type_name_regex_(tn_regex) > {} >@@ -128,28 +104,6 @@ struct function_suppression::priv > change_kind_(ALL_CHANGE_KIND), > allow_other_aliases_(true) > {} >- >- priv(const string& name, >- const regex::regex_t_sptr& name_regex, >- const string& return_type_name, >- const regex::regex_t_sptr& return_type_regex, >- const parameter_specs_type& parm_specs, >- const string& symbol_name, >- const regex::regex_t_sptr& symbol_name_regex, >- const string& symbol_version, >- const regex::regex_t_sptr& symbol_version_regex) >- : change_kind_(ALL_CHANGE_KIND), >- name_(name), >- name_regex_(name_regex), >- return_type_name_(return_type_name), >- return_type_regex_(return_type_regex), >- parm_specs_(parm_specs), >- symbol_name_(symbol_name), >- symbol_name_regex_(symbol_name_regex), >- symbol_version_(symbol_version), >- symbol_version_regex_(symbol_version_regex), >- allow_other_aliases_(true) >- {} > }; // end class function_suppression::priv > > bool >@@ -293,20 +247,6 @@ public: > reach_kind_(DIRECT_REACH_KIND) > {} > >- priv(const regex::regex_t_sptr& type_name_regexp, >- const string& type_name, >- bool consider_type_kind, >- type_suppression::type_kind type_kind, >- bool consider_reach_kind, >- type_suppression::reach_kind reach_kind) >- : type_name_regex_(type_name_regexp), >- type_name_(type_name), >- consider_type_kind_(consider_type_kind), >- type_kind_(type_kind), >- consider_reach_kind_(consider_reach_kind), >- reach_kind_(reach_kind) >- {} >- > friend class type_suppression; > }; // class type_suppression::priv > >-- >2.26.2.303.gf8c07b1a785-goog >