public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
	 maennich@google.com
Subject: [PATCH 0/4] Fix incomplete function type bug in abg-reader
Date: Tue,  5 May 2020 19:06:08 +0100	[thread overview]
Message-ID: <20200505180612.232158-1-gprocida@google.com> (raw)

This series is to be applied in sequence. The test can be moved after
the other changes and folded into one commit, if you prefer.

This seemed liked the simplest way to fix the issue, side-stepping
some uses of type names completely.

Regards,
Giuliano.

Giuliano Procida (4):
  Add XML reader test for incomplete function types.
  abg-reader.cc: Late canonicalise all types.
  abg-reader.cc: Strip out WIP type tracking.
  Pass bind_function_type_life_time a complete type.

 src/abg-reader.cc                             | 173 ++++--------------
 tests/data/Makefile.am                        |   7 +
 .../test-fun-param-report.txt                 |  15 ++
 .../test-abidiff-exit/test-fun-param-v0.abi   |  44 +++++
 .../test-abidiff-exit/test-fun-param-v0.c     |   7 +
 .../test-abidiff-exit/test-fun-param-v0.o     | Bin 0 -> 2992 bytes
 .../test-abidiff-exit/test-fun-param-v1.abi   |  46 +++++
 .../test-abidiff-exit/test-fun-param-v1.c     |   7 +
 .../test-abidiff-exit/test-fun-param-v1.o     | Bin 0 -> 3000 bytes
 tests/test-abidiff-exit.cc                    |   9 +
 10 files changed, 168 insertions(+), 140 deletions(-)
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-report.txt
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.abi
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.c
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.o
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.abi
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.c
 create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.o

-- 
2.26.2.526.g744177e7f7-goog


             reply	other threads:[~2020-05-05 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 18:06 Giuliano Procida [this message]
2020-05-05 18:06 ` [PATCH 1/4] Add XML reader test for incomplete function types Giuliano Procida
2020-05-12 16:22   ` Matthias Maennich
2020-05-13 18:39     ` Giuliano Procida
2020-05-05 18:06 ` [PATCH 2/4] abg-reader.cc: Late canonicalise all types Giuliano Procida
2020-05-05 18:06 ` [PATCH 3/4] abg-reader.cc: Strip out WIP type tracking Giuliano Procida
2020-05-05 18:06 ` [PATCH 4/4] Pass bind_function_type_life_time a complete type Giuliano Procida
2020-05-13 14:38 ` [PATCH 0/4] Fix incomplete function type bug in abg-reader Dodji Seketeli
2020-05-13 18:30   ` Giuliano Procida
2020-05-14  8:14     ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505180612.232158-1-gprocida@google.com \
    --to=gprocida@google.com \
    --cc=dodji@seketeli.org \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).