From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3GauxXggKCjIUdfcQWROUccUZS.QcaZWPOPWUOWZgcifQSkOfS.cfU@flex--gprocida.bounces.google.com> Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by sourceware.org (Postfix) with ESMTPS id 2370D389040B for ; Tue, 5 May 2020 18:06:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2370D389040B Received: by mail-qt1-x84a.google.com with SMTP id x24so2605590qta.4 for ; Tue, 05 May 2020 11:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=tmD4EQmIbpRb09sNxrdUH91TqWd+6xqABiLRGPtQGBI=; b=HXQbInPJwzp+OVPxhf1E+nyBPiN56/b2SbVr1iaUL1dbxBqkVO02vyRg4AUR3P3GN9 /REm/13O3t1zgrVu6+S7V8eOweLIpUgntQuPUESDHIX/XU9uylZV8wYoyh7HQmuT7Ri6 aigMqKrhVF/i94l6VkgMv7vkqiPtUrd1WK6RbFqfHn/kMjowbYp41M48RrvG6YB0iwp8 R//wHyopdIlrBrvkpYm+GfmslIxMUVQmFtbBn7lDteNqbginvDOnsAjE/GRI2q1DBY/7 AToNIhvaAlgN7V3TUTNMnoLesx4W52UKxeo/SYxyaACcnPVJl/kOy99PZIAryb9MMqH/ supw== X-Gm-Message-State: AGi0Pua/auzDahDpwvVZBG4ppTS6HhrUoWxVhEN2XkCj2PoG8Gwh6rKJ KJ0wRIbK7AYl4NvpzLmWzHzUecfUUcx8F3idk3/rYrh6EjNVr99YVGa/crc9VlAbZA/Fj2b7pzr g0RvfGWN3US7stHtZF5AcwrVC6wTGkoaWfp9n98HrmzIjsshPjxx5NqVPzHDcOXTUxj7V/gg= X-Google-Smtp-Source: APiQypJFXzcxcmmMAwnvL3goKlGuiR4rA2Ys2d00VvR2njwhOzNlwCx52U573MjcY3Aq+G7gPDGL5Zck/35SPg== X-Received: by 2002:ad4:5843:: with SMTP id de3mr4058852qvb.92.1588701977574; Tue, 05 May 2020 11:06:17 -0700 (PDT) Date: Tue, 5 May 2020 19:06:08 +0100 Message-Id: <20200505180612.232158-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.26.2.526.g744177e7f7-goog Subject: [PATCH 0/4] Fix incomplete function type bug in abg-reader From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, maennich@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-20.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2020 18:06:28 -0000 This series is to be applied in sequence. The test can be moved after the other changes and folded into one commit, if you prefer. This seemed liked the simplest way to fix the issue, side-stepping some uses of type names completely. Regards, Giuliano. Giuliano Procida (4): Add XML reader test for incomplete function types. abg-reader.cc: Late canonicalise all types. abg-reader.cc: Strip out WIP type tracking. Pass bind_function_type_life_time a complete type. src/abg-reader.cc | 173 ++++-------------- tests/data/Makefile.am | 7 + .../test-fun-param-report.txt | 15 ++ .../test-abidiff-exit/test-fun-param-v0.abi | 44 +++++ .../test-abidiff-exit/test-fun-param-v0.c | 7 + .../test-abidiff-exit/test-fun-param-v0.o | Bin 0 -> 2992 bytes .../test-abidiff-exit/test-fun-param-v1.abi | 46 +++++ .../test-abidiff-exit/test-fun-param-v1.c | 7 + .../test-abidiff-exit/test-fun-param-v1.o | Bin 0 -> 3000 bytes tests/test-abidiff-exit.cc | 9 + 10 files changed, 168 insertions(+), 140 deletions(-) create mode 100644 tests/data/test-abidiff-exit/test-fun-param-report.txt create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.abi create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.c create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v0.o create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.abi create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.c create mode 100644 tests/data/test-abidiff-exit/test-fun-param-v1.o -- 2.26.2.526.g744177e7f7-goog