From: Matthias Maennich <maennich@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com
Subject: Re: [PATCH] Tidy get_pretty_representation qualified_name.
Date: Wed, 13 May 2020 10:04:46 +0200 [thread overview]
Message-ID: <20200513080446.GD179834@google.com> (raw)
In-Reply-To: <20200505181700.239417-1-gprocida@google.com>
On Tue, May 05, 2020 at 07:17:00PM +0100, Android Kernel Team wrote:
>The virtual function get_pretty_representation exists in many
>classes (derived from type_or_decl_base). It takes a qualified_name
>argumenta and this is defaulted to true in all but one case which
>seems to be an oversight.
>
>This commit changes this for no better reason than consistency.
>
> * include/abg-ir.h (type_decl::get_pretty_representation)
> Change default for qualified_name parameter to true.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> include/abg-ir.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index fda10de5..edfea863 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1920,7 +1920,7 @@ public:
>
> virtual string
> get_pretty_representation(bool internal = false,
>- bool qualified_name = false) const;
>+ bool qualified_name = true) const;
>
> virtual bool
> traverse(ir_node_visitor&);
>--
>2.26.2.526.g744177e7f7-goog
>
>
next prev parent reply other threads:[~2020-05-13 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:17 Giuliano Procida
2020-05-13 8:04 ` Matthias Maennich [this message]
2020-05-14 14:34 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513080446.GD179834@google.com \
--to=maennich@google.com \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).