From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3FzjnXggKCiIENPMAGB8EMMEJC.AMKJG989GE8GJQMSPACU8PC.MPE@flex--gprocida.bounces.google.com> Received: from mail-qv1-xf4a.google.com (mail-qv1-xf4a.google.com [IPv6:2607:f8b0:4864:20::f4a]) by sourceware.org (Postfix) with ESMTPS id 2D4503851C16 for ; Mon, 15 Jun 2020 08:58:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2D4503851C16 Received: by mail-qv1-xf4a.google.com with SMTP id f18so12474229qvr.22 for ; Mon, 15 Jun 2020 01:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=j+xh5DFmZLwqGSJP7Ks9ycd0IKdrGmcG1GvIinNktcM=; b=NAnOTw4pShtKNJujtotWRv3PwM2d89/sDmZbfe3iUMLK0PfhXqvihSUr6OUKEpqyWU LjkZEwzT8aiotFHgu2xY6oU8LkuVNXSW3XsifbNBD01fjSsjl3kZIQhDQBE6zsq2rvUT miOh70O2gDo8Q2oRsCi8e0EKDD87gHAYqoeGKrOCVPrt4uZZUrRXuABAnNJOW9qgsxdq fMqj9+u/N6YT+OjIxNMO8dJsSTF0PzKJH7g1tIijFVOlG+yP0CSuI9yRKTFRAeYdI87p ePfcloiNzaJCzFH8p2Z604RfQu6gSPiBUHOL4IIvWC8JUFQr0yDgWjTYOvC2Z9a9+KNL oJ1Q== X-Gm-Message-State: AOAM533p9Adj/COVcEYFB2U2VDVuNVUXwhPJ/kusjBAkjEp7m0MMfVYG +Qoq9jtmyc9J3WDpXE0IO7MrYc/fUn788hx+DfARLtFjQhgOHhORsxt9S7uijK1B7G6MojxvYSX 6QGl7KKPkNbUiYnPKdnX2T1M5+LHE1AG/cONUzJi5wNPKvfqVeH0PeKqqtT435dkbcmxHjYM= X-Google-Smtp-Source: ABdhPJw4ZaM1iPU6SJPnwYp89LnZGRiPDH6a46bWEp7ozmjH2bp5I8DNq7HhryrOZ7GFHDrpSgH/kxohF2O9sg== X-Received: by 2002:ad4:4309:: with SMTP id c9mr23977383qvs.50.1592211479589; Mon, 15 Jun 2020 01:57:59 -0700 (PDT) Date: Mon, 15 Jun 2020 09:57:56 +0100 Message-Id: <20200615085756.134066-1-gprocida@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog Subject: [PATCH] Fix bug that suppressed DWARF read tests. From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, Matthias Maennich Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 08:58:03 -0000 An earlier commit added code to allow the ABI write/reread and compare phases of the tests to skipped in the case that no ABI files are given for comparison. Unfortunately, the new code skipped those phases unconditionally. This patch changes the in_abi_path and out_abi_path values used in in_out_specs used to trigger the early termination from "" to nullptr and updates the conditional logic checking them. Several later commits also need adjustment to test specification or test data. The changes below are listed against the commit they fix. 4252dfd6 dwarf-reader: handle symtab.section_header.sh_entsize == 0 * tests/test-read-dwarf.cc (in_out_specs): Use nullptr instead of "" for test25 case. (perform): Check members of spec, rather than locals with same name, when deciding to terminate testing early. 4457c10e dwarf-reader: handle binaries with missing symtab * tests/test-read-dwarf.cc (in_out_specs): Use nullptr to signal early termination of test26. 34e867e7 dwarf-reader: remove superfluous ABG_ASSERT * tests/test-read-dwarf.cc (in_out_specs): Use nullptr to signal early termination of test27. 2d5389f2 Fix size calculations for multidimensional arrays. * tests/data/test-read-dwarf/test14-pr18893.so.abi: Update array sizes. * tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto. * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Ditto. * tests/data/test-read-dwarf/test7.so.abi: Ditto. 246ca200 corpus/writer: sort emitted translation units by path name * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: Update following translation unit ordering change. * tests/data/test-read-dwarf/test13-pr18894.so.abi: Ditto. * tests/data/test-read-dwarf/test14-pr18893.so.abi: Ditto. * tests/data/test-read-dwarf/test15-pr18892.so.abi: Ditto. * tests/data/test-read-dwarf/test16-pr18904.so.abi: Ditto. * tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto. * tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Ditto. * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Ditto. * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi: Ditto. * tests/data/test-read-dwarf/test21-pr19092.so.abi: Ditto. * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: Ditto. e8bf5b80 Bug 25989 - type_topo_comp doesn't meet irreflexive requirements * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update following code changes affecting ordering of some ABI elements. * tests/data/test-read-dwarf/test16-pr18904.so.abi Finally, this commit also corrects some bad code formatting. * tests/test-read-dwarf.cc (perform): Fix some whitespace. Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich Signed-off-by: Giuliano Procida --- .../data/test-read-dwarf/PR25007-sdhci.ko.abi | 3442 +- .../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 1072 +- .../test-read-dwarf/test13-pr18894.so.abi | 454 +- .../test-read-dwarf/test14-pr18893.so.abi | 10274 +-- .../test-read-dwarf/test15-pr18892.so.abi | 38226 ++++---- .../test-read-dwarf/test16-pr18904.so.abi | 44259 ++++----- .../test-read-dwarf/test17-pr19027.so.abi | 11110 +-- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 42 +- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 37213 ++++---- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 8540 +- .../test-read-dwarf/test21-pr19092.so.abi | 7734 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 75710 ++++++++-------- tests/data/test-read-dwarf/test7.so.abi | 2 +- tests/test-read-dwarf.cc | 19 +- 14 files changed, 119199 insertions(+), 118898 deletions(-) Patch omitted as too large to send by email. See: https://github.com/myxoid/libabigail/commit/6d52caf932a39267c4ee0e073a8f5010d566feae -- 2.27.0.290.gba653c62da-goog