From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com,
Matthias Maennich <maennich@google.com>
Subject: [PATCH v3] Fix bug that suppressed DWARF read tests.
Date: Tue, 16 Jun 2020 16:34:33 +0100 [thread overview]
Message-ID: <20200616153433.251298-1-gprocida@google.com> (raw)
In-Reply-To: <20200615085756.134066-1-gprocida@google.com>
Commit 4252dfd6 added code to allow the ABI write/reread and compare
phases of the tests to be skipped in the case that no ABI files are
given for comparison.
Unfortunately, the new code skipped those phases unconditionally.
This patch changes the in_abi_path and out_abi_path values used in
in_out_specs used to trigger the early termination from "" to NULL and
updates the conditional logic checking them. Several subsequent
commits which affect ABI output were missing these changes to the test
data files.
This change fixes the following list of commits.
4252dfd6 dwarf-reader: handle symtab.section_header.sh_entsize == 0
4457c10e dwarf-reader: handle binaries with missing symtab
34e867e7 dwarf-reader: remove superfluous ABG_ASSERT
2d5389f2 Fix size calculations for multidimensional arrays.
246ca200 corpus/writer: sort emitted translation units by path name
e8bf5b80 Bug 25989 - type_topo_comp doesn't meet irreflexive requirements
Finally, this commit also corrects some bad code formatting.
* tests/test-read-dwarf.cc (in_out_specs): Use NULL instead of
empty ABI paths for test25, test26 and test27. (perform):
Check members of spec, rather than locals with same name, when
deciding to terminate testing early; fix some code whitespace.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Update
multidimensional array sizes.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Ditto.
* tests/data/test-read-dwarf/test7.so.abi: Ditto.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
Update following translation unit ordering change.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Ditto.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Ditto.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Ditto.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Ditto.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto.
* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Ditto.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Ditto.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Ditto.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Ditto.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
Ditto.
* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update
following code changes affecting ordering of some ABI
elements.
* tests/data/test-read-dwarf/test16-pr18904.so.abi
Reviewed-by: Matthias Maennich <maennich@google.com>
Tested-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
.../data/test-read-dwarf/PR25007-sdhci.ko.abi | 3442 +-
.../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 1072 +-
.../test-read-dwarf/test13-pr18894.so.abi | 454 +-
.../test-read-dwarf/test14-pr18893.so.abi | 10274 +--
.../test-read-dwarf/test15-pr18892.so.abi | 38226 ++++----
.../test-read-dwarf/test16-pr18904.so.abi | 44259 ++++-----
.../test-read-dwarf/test17-pr19027.so.abi | 11110 +--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 42 +-
...19-pr19023-libtcmalloc_and_profiler.so.abi | 37213 ++++----
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 8540 +-
.../test-read-dwarf/test21-pr19092.so.abi | 7734 +-
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 75710 ++++++++--------
tests/data/test-read-dwarf/test7.so.abi | 2 +-
tests/test-read-dwarf.cc | 19 +-
14 files changed, 119199 insertions(+), 118898 deletions(-)
Patch omitted as too large to send by email.
See:
https://github.com/myxoid/libabigail/commit/15579d778efe0b79a35d7c8b1efa0867cc328956
--
2.27.0.290.gba653c62da-goog
next prev parent reply other threads:[~2020-06-16 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 8:57 [PATCH] " Giuliano Procida
2020-06-16 13:56 ` Dodji Seketeli
2020-06-16 15:29 ` Giuliano Procida
2020-06-16 15:28 ` [PATCH v2] " Giuliano Procida
2020-06-16 15:34 ` Giuliano Procida [this message]
2020-06-17 9:46 ` [PATCH v3] " Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616153433.251298-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).