From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3jOboXggKCvkhqspdjebhpphmf.dpnmjcbcjhbjmtpvsdfxbsf.psh@flex--gprocida.bounces.google.com> Received: from mail-qk1-x749.google.com (mail-qk1-x749.google.com [IPv6:2607:f8b0:4864:20::749]) by sourceware.org (Postfix) with ESMTPS id 1CB9F388F05D for ; Tue, 16 Jun 2020 15:34:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1CB9F388F05D Received: by mail-qk1-x749.google.com with SMTP id j16so17073713qka.11 for ; Tue, 16 Jun 2020 08:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=hYNr1QcjtB9AvsQno+B29v50Gm0i1IB8ntaNT6AlySc=; b=nGEBebYuKyfB5u3Di2L5GDO3blyj6tCDKofAy0fyWml7FX63NA+iIX+1hhuVy9WuYI 9kB5SAD6PyGejciz+/AfpyNSJ0zXaHkrbAi9l6YtnW/6hDksd0CPrPV4EISZedBpXa2y KrB0ZddjGLBIuZfWYv9C4I0WnsKQ+9mT/EeXcOP9YtioZjWeQC2Gg+w46ZEOUjff9t+R TYVfE9lVxmlU49ftifoD3y4aNtf7kRl2hUj+UsL1mzh+kXoHFUCUXlLv8RydblMgcs2o L0jhnX679jQF0r1vUlsaxTErnGLEniJtQe9toNmmLu8c3anOt0pNlgTKr/spYoZwlxmp LD0A== X-Gm-Message-State: AOAM53137wkPuqpoehFR45DONiQ8VCXnvCkHAYxbHq6AR40Ti5XeUhIK wG7A840F0X3XkV7qEYJHLyVNOykibG9CBB9AXVSGH6eSY//FQSALO6KsOC8Nk37dAYVBexBEA4P PRmEtyhkSyj6OwFV3N5WMnl492KqdgjIexeI8sLkKPk7fRzIpQzbkBblwcdwXuohP/WRfSFY= X-Google-Smtp-Source: ABdhPJxyvmWMFiZKl7myn/rS6sDh99G46O0htW5FBxF4VyY6E6VQQwzshrGlTB/bimklO4Nq7vwFzrF2PXAg6w== X-Received: by 2002:a05:6214:313:: with SMTP id i19mr2876951qvu.183.1592321676598; Tue, 16 Jun 2020 08:34:36 -0700 (PDT) Date: Tue, 16 Jun 2020 16:34:33 +0100 In-Reply-To: <20200615085756.134066-1-gprocida@google.com> Message-Id: <20200616153433.251298-1-gprocida@google.com> Mime-Version: 1.0 References: <20200615085756.134066-1-gprocida@google.com> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog Subject: [PATCH v3] Fix bug that suppressed DWARF read tests. From: Giuliano Procida To: libabigail@sourceware.org Cc: dodji@seketeli.org, kernel-team@android.com, gprocida@google.com, Matthias Maennich Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2020 15:34:38 -0000 Commit 4252dfd6 added code to allow the ABI write/reread and compare phases of the tests to be skipped in the case that no ABI files are given for comparison. Unfortunately, the new code skipped those phases unconditionally. This patch changes the in_abi_path and out_abi_path values used in in_out_specs used to trigger the early termination from "" to NULL and updates the conditional logic checking them. Several subsequent commits which affect ABI output were missing these changes to the test data files. This change fixes the following list of commits. 4252dfd6 dwarf-reader: handle symtab.section_header.sh_entsize == 0 4457c10e dwarf-reader: handle binaries with missing symtab 34e867e7 dwarf-reader: remove superfluous ABG_ASSERT 2d5389f2 Fix size calculations for multidimensional arrays. 246ca200 corpus/writer: sort emitted translation units by path name e8bf5b80 Bug 25989 - type_topo_comp doesn't meet irreflexive requirements Finally, this commit also corrects some bad code formatting. * tests/test-read-dwarf.cc (in_out_specs): Use NULL instead of empty ABI paths for test25, test26 and test27. (perform): Check members of spec, rather than locals with same name, when deciding to terminate testing early; fix some code whitespace. * tests/data/test-read-dwarf/test14-pr18893.so.abi: Update multidimensional array sizes. * tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto. * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Ditto. * tests/data/test-read-dwarf/test7.so.abi: Ditto. * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: Update following translation unit ordering change. * tests/data/test-read-dwarf/test13-pr18894.so.abi: Ditto. * tests/data/test-read-dwarf/test14-pr18893.so.abi: Ditto. * tests/data/test-read-dwarf/test15-pr18892.so.abi: Ditto. * tests/data/test-read-dwarf/test16-pr18904.so.abi: Ditto. * tests/data/test-read-dwarf/test17-pr19027.so.abi: Ditto. * tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi: Ditto. * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: Ditto. * tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi: Ditto. * tests/data/test-read-dwarf/test21-pr19092.so.abi: Ditto. * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: Ditto. * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update following code changes affecting ordering of some ABI elements. * tests/data/test-read-dwarf/test16-pr18904.so.abi Reviewed-by: Matthias Maennich Tested-by: Matthias Maennich Signed-off-by: Giuliano Procida --- .../data/test-read-dwarf/PR25007-sdhci.ko.abi | 3442 +- .../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 1072 +- .../test-read-dwarf/test13-pr18894.so.abi | 454 +- .../test-read-dwarf/test14-pr18893.so.abi | 10274 +-- .../test-read-dwarf/test15-pr18892.so.abi | 38226 ++++---- .../test-read-dwarf/test16-pr18904.so.abi | 44259 ++++----- .../test-read-dwarf/test17-pr19027.so.abi | 11110 +-- ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 42 +- ...19-pr19023-libtcmalloc_and_profiler.so.abi | 37213 ++++---- ...st20-pr19025-libvtkParallelCore-6.1.so.abi | 8540 +- .../test-read-dwarf/test21-pr19092.so.abi | 7734 +- .../test22-pr19097-libstdc++.so.6.0.17.so.abi | 75710 ++++++++-------- tests/data/test-read-dwarf/test7.so.abi | 2 +- tests/test-read-dwarf.cc | 19 +- 14 files changed, 119199 insertions(+), 118898 deletions(-) Patch omitted as too large to send by email. See: https://github.com/myxoid/libabigail/commit/15579d778efe0b79a35d7c8b1efa0867cc328956 -- 2.27.0.290.gba653c62da-goog